From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v3 0/8] Reduce differences between inbound and outbound socket binding
Date: Wed, 29 Oct 2025 17:26:20 +1100 [thread overview]
Message-ID: <20251029062628.1647051-1-david@gibson.dropbear.id.au> (raw)
The fact that outbound forwarding sockets are bound to the loopback
address, whereas inbound forwarding sockets are (by default) bound to
the unspecified address leads to some unexpected differences between
the paths setting up each of them.
An idea for tackling bug 100 suggested a different approach which will
also reduce some of those differences and allow more code to be shared
between the two paths. I've since discovered that this approach may
not help for bug 100, but it might still be worthwhile for the clean
up.
Patches 1..6/8 are cleanups which shouldn't change behaviour, and I
think are ready to merge. 7/8 is (arguably) a behavioural change, but
I've made my case for it in the patch comment. 8/8 needs some further
consideration, since I've discovered it does not fix bug 100 as is,
I'm including it for advance review, though.
v3:
- A number of additional fixes covering the handling of IPV6_V6ONLY sockopt
- Assorted trivial changes
v2:
- Some rearrangements and rewordings for clarity
David Gibson (8):
inany: Let length of sockaddr_inany be implicit from the family
util, flow, pif: Simplify sock_l4_sa() interface
tcp: Merge tcp_ns_sock_init[46]() into tcp_sock_init_one()
udp: Unify some more inbound/outbound parts of udp_sock_init()
udp: Move udp_sock_init() special case to its caller
util: Fix setting of IPV6_V6ONLY socket option
tcp, udp: Remove fallback if creating dual stack socket fails
[RFC, DO NOT APPLY] tcp, udp: Bind outbound listening sockets by
interface instead of address
conf.c | 4 +-
flow.c | 19 +++---
icmp.c | 3 +-
inany.h | 18 ++++++
pif.c | 26 ++------
pif.h | 2 +-
tcp.c | 164 +++++++++++++++++++--------------------------------
tcp.h | 5 +-
tcp_splice.c | 5 +-
udp.c | 102 +++++++++++++++-----------------
udp.h | 5 +-
util.c | 55 +++++++++++++----
util.h | 9 ++-
13 files changed, 201 insertions(+), 216 deletions(-)
--
2.51.0
next reply other threads:[~2025-10-29 6:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 6:26 David Gibson [this message]
2025-10-29 6:26 ` [PATCH v3 1/8] inany: Let length of sockaddr_inany be implicit from the family David Gibson
2025-11-13 6:33 ` Stefano Brivio
2025-11-13 22:53 ` David Gibson
2025-10-29 6:26 ` [PATCH v3 2/8] util, flow, pif: Simplify sock_l4_sa() interface David Gibson
2025-11-13 6:33 ` Stefano Brivio
2025-11-13 23:21 ` David Gibson
2025-11-18 0:19 ` Stefano Brivio
2025-11-18 3:34 ` David Gibson
2025-11-19 11:42 ` Stefano Brivio
2025-11-20 0:05 ` David Gibson
2025-11-20 2:22 ` David Gibson
2025-10-29 6:26 ` [PATCH v3 3/8] tcp: Merge tcp_ns_sock_init[46]() into tcp_sock_init_one() David Gibson
2025-10-29 6:26 ` [PATCH v3 4/8] udp: Unify some more inbound/outbound parts of udp_sock_init() David Gibson
2025-11-13 6:33 ` Stefano Brivio
2025-11-13 23:33 ` David Gibson
2025-10-29 6:26 ` [PATCH v3 5/8] udp: Move udp_sock_init() special case to its caller David Gibson
2025-10-29 6:26 ` [PATCH v3 6/8] util: Fix setting of IPV6_V6ONLY socket option David Gibson
2025-11-13 6:33 ` Stefano Brivio
2025-11-14 0:24 ` David Gibson
2025-11-18 0:19 ` Stefano Brivio
2025-10-29 6:26 ` [PATCH v3 7/8] tcp, udp: Remove fallback if creating dual stack socket fails David Gibson
2025-10-29 6:26 ` [PATCH v3 8/8] [RFC, DO NOT APPLY] tcp, udp: Bind outbound listening sockets by interface instead of address David Gibson
2025-10-30 3:58 ` [PATCH v3 0/8] Reduce differences between inbound and outbound socket binding David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029062628.1647051-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).