From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D3EinKxi; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 234BE5A0619 for ; Thu, 30 Oct 2025 18:00:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761843611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R5eUaDm4oPK0Q4569h6Orju9PzQsmCcPhV/Vwdpig+8=; b=D3EinKxiwDeGQyfjHN30mTI1qgrO/Wp5f+Ldm8HXIH0W1bQnvZP+RedaS4YgjIl2iveb8O WZYO3+OlBuZI41Szwua7ChpCuSyaWHVzOYwqDrOgQX+O+ZE4lVh+hZpWPWQFPvl0e3RowJ ZStQU0ZlrY/0swKWcYFd90aSvlIF8B4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-piQa2UT1NICmSBwIP4nB8A-1; Thu, 30 Oct 2025 13:00:09 -0400 X-MC-Unique: piQa2UT1NICmSBwIP4nB8A-1 X-Mimecast-MFC-AGG-ID: piQa2UT1NICmSBwIP4nB8A_1761843608 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-429b51f3fd8so693277f8f.3 for ; Thu, 30 Oct 2025 10:00:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761843608; x=1762448408; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=R5eUaDm4oPK0Q4569h6Orju9PzQsmCcPhV/Vwdpig+8=; b=E2eX4WIogBuS5YnsIf9ij06m3wAeUH9YhLYRd4BL5ENNbHPQGIWBTAP6e6V8i8c48A B8sg/ZW3AhT1NZJ/Kc6AQAK0H8pZSXeueKxccPSTzV8+qCazyo8ZkoRQ2NiX5mKU9zZ5 tvVQ0YzwHtYCfOaYA9Sfs1coqJlBbamRWWNBKxaZFw8rp4CcY+GEOydOxdfi2RqnJP4c Hcs3oKvO0f8qRHplz/kNWuetmT+sQrsCZa1bWj1/yhuIXVxeEseIgshWAhPwRDGT8XjU V1X97K3SswJP9HE4xpN4hW8LLZQ2SbN7dFTt8H8xaxQY7ru5QNP2lU+s+Tlzs0qwS1jm Zo5Q== X-Gm-Message-State: AOJu0YyrTpwPTZD2l9wAe3R4b8TybBUwNh35UWdkkNrCe3gVqRCyCkWK FSI+gTXgauR/U9T1tiyhmWOgcdUtvnBiNepSXCIwty/t0rvG0U56kl9SNtXztPb7yf2pcQfwKa6 UZyjwzQ5y//7YNdSC3eV2xFtohI+RBk9nFqKQBv79Hz2TN0ftqoP1/A== X-Gm-Gg: ASbGncvoL77qdZdGKGUr8p+3b2ExhfB89MgiQU7XZL5WIJnVdXBYKNg93VJhmPCGCxw 8GdVtrVf2hgyTkMOVNfMdqZhk1LbD9sj7pRurxhZnFDCep7gaaLRKFtLTVcVCJOXYTY1+iC5NVR BG3Z7TnjyyoJqXSaY47rCPjHLYtwSxf7MzmTfaXvS2+tkcJsR07/NwEAfzHRvwiEf+eDzjJbwwV 6Qe1RFmZ1zjwtWeSsJWKI9XEtErtsMnUMLQ/MA0y3ZYGs58XqWzVhEb/fvqQMzx3AefOq7WRRLv +xUlcOr279vRMDvQq47PEoJcD9kAN4jHvNiMh3bYJA/5Y4QMJp4NCLnItIo892qjC+B4wlfmcqt wIxVsbdO8Bg== X-Received: by 2002:a05:6000:2501:b0:429:b805:1165 with SMTP id ffacd0b85a97d-429bd6b0902mr244166f8f.49.1761843607678; Thu, 30 Oct 2025 10:00:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXzauuRhKyqw8D92BT3NWefQ7EJfcP4+YJ0EMAAYKPAnlv13FCS0YSylXbOkOigtEoz/SF+w== X-Received: by 2002:a05:6000:2501:b0:429:b805:1165 with SMTP id ffacd0b85a97d-429bd6b0902mr244112f8f.49.1761843606952; Thu, 30 Oct 2025 10:00:06 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477289b0bb3sm51688395e9.8.2025.10.30.10.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 10:00:06 -0700 (PDT) Date: Thu, 30 Oct 2025 18:00:04 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v5 4/7] tcp, flow: Replace per-connection in_epoll flag with an epollid in flow_common Message-ID: <20251030180004.3336c2bb@elisabeth> In-Reply-To: <20251021210116.314674-5-lvivier@redhat.com> References: <20251021210116.314674-1-lvivier@redhat.com> <20251021210116.314674-5-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9ewWN2L_umvfy-e8oqP3T-jnIN1zYC2cljdz-haU2hc_1761843608 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3I5EGJJ4KJMH3CENTA2TQDTOQGT4PGTB X-Message-ID-Hash: 3I5EGJJ4KJMH3CENTA2TQDTOQGT4PGTB X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 21 Oct 2025 23:01:13 +0200 Laurent Vivier wrote: > diff --git a/flow.h b/flow.h > index ef138b83add8..2c58b30ffc6a 100644 > --- a/flow.h > +++ b/flow.h > @@ -177,6 +177,7 @@ int flowside_connect(const struct ctx *c, int s, > * @type: Type of packet flow > * @pif[]: Interface for each side of the flow > * @side[]: Information for each side of the flow > + * @epollid: epollfd identifier, or EPOLLFD_ID_INVALID > */ > struct flow_common { > #ifdef __GNUC__ > @@ -192,8 +193,15 @@ struct flow_common { > #endif > uint8_t pif[SIDES]; > struct flowside side[SIDES]; > +#define EPOLLFD_ID_BITS 8 > + unsigned int epollid:EPOLLFD_ID_BITS; > }; Just to confirm, on top of Jon's series (adding tap_omac[6] before this): struct tcp_tap_conn { struct flow_common f; /* 0 84 */ /* --- cacheline 1 boundary (64 bytes) was 20 bytes ago --- */ [...] /* size: 128, cachelines: 2, members: 19 */ /* sum members: 115 */ /* sum bitfield members: 97 bits, bit holes: 1, sum bit holes: 7 bits */ }; ...perfect. Tight but we still have 7 bits (in a single chunk) should we ever need something else. -- Stefano