From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=UWXYkjb2; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 26A175A061B for ; Fri, 31 Oct 2025 05:19:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1761884372; bh=Ni9YT7jLwpov+K0GXJfdeFVPE4CfzyQJIcOb5yYaXKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UWXYkjb2Xy/bTn9Fwx9qlT7dUzUi70WklErylw8uATI4FqUV+ltIcoeN48wKzYEhn rWsd5x1aXl7ismUzZMZIQOo711Cgo1V8KxXJVbQsmxI/FmwwWLk0EFgxBae9vKzOaR 2V4y1BWooc5uSV4PN+iYUNaJ4GhahAxipX7YDQ5frnvo32GXgd0dgJo3h6AruKW+wV T5qr7pxYC7N46ja+gxlMVIxf2rjAXGHqjzLQdSvMeENm+VL9HxGhc+5Mpfa3zPD8hI F0dh2fb6f99Or7iAXrYbux6+p85WV/GsYyssSqrrkCpclzI7QgXhCKQm6ldE7XZFEi rdIjSA5Qb/cvQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cySRm1YW7z4xGx; Fri, 31 Oct 2025 15:19:32 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 1/8] icmp: Remove vestiges of ICMP timer Date: Fri, 31 Oct 2025 15:19:23 +1100 Message-ID: <20251031041930.1272259-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251031041930.1272259-1-david@gibson.dropbear.id.au> References: <20251031041930.1272259-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: OGEGWPD6RA2D5LIT7F6CRO4JNZR4PHND X-Message-ID-Hash: OGEGWPD6RA2D5LIT7F6CRO4JNZR4PHND X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We no longer have a global ICMP timer (timers for individual flows are handled through the flow timer). We still have an ICMP_TIMER_INTERVAL define, though. Remove it. Signed-off-by: David Gibson --- icmp.h | 2 -- passt.c | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/icmp.h b/icmp.h index d1cecb20..1a0e6205 100644 --- a/icmp.h +++ b/icmp.h @@ -6,8 +6,6 @@ #ifndef ICMP_H #define ICMP_H -#define ICMP_TIMER_INTERVAL 10000 /* ms */ - struct ctx; struct icmp_ping_flow; diff --git a/passt.c b/passt.c index dc3e1141..5d3ad55c 100644 --- a/passt.c +++ b/passt.c @@ -57,8 +57,7 @@ #define NUM_EPOLL_EVENTS 8 -#define TIMER_INTERVAL__ MIN(TCP_TIMER_INTERVAL, UDP_TIMER_INTERVAL) -#define TIMER_INTERVAL_ MIN(TIMER_INTERVAL__, ICMP_TIMER_INTERVAL) +#define TIMER_INTERVAL_ MIN(TCP_TIMER_INTERVAL, UDP_TIMER_INTERVAL) #define TIMER_INTERVAL MIN(TIMER_INTERVAL_, FLOW_TIMER_INTERVAL) char pkt_buf[PKT_BUF_BYTES] __attribute__ ((aligned(PAGE_SIZE))); -- 2.51.0