From: Stefano Brivio <sbrivio@redhat.com>
To: Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top, david@gibson.dropbear.id.au
Subject: Re: [PATCH v7 4/5] tcp: Update data retransmission timeout
Date: Fri, 31 Oct 2025 09:04:37 +0100 [thread overview]
Message-ID: <20251031090437.5c9f75a4@elisabeth> (raw)
In-Reply-To: <CANsz47nChaw=cAPmwi6Ycte9k79egd7gt0X9D5BHXJw6oT4cOg@mail.gmail.com>
On Fri, 31 Oct 2025 13:56:41 +0800
Yumei Huang <yuhuang@redhat.com> wrote:
> On Fri, Oct 31, 2025 at 1:43 PM Yumei Huang <yuhuang@redhat.com> wrote:
> >
> > Use an exponential backoff timeout for data retransmission according
> > to RFC 2988 and RFC 6298. Set the initial RTO to one second as discussed
> > in Appendix A of RFC 6298.
> >
> > Also combine the macros defining the initial RTO for both SYN and ACK.
> >
> > Signed-off-by: Yumei Huang <yuhuang@redhat.com>
> > Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> I probably should have removed the reviewed-by since there are some
> code changes.
Thanks for reporting.
I eventually notice during review and drop tags as needed but if you
notice you carried a tag by mistake, it's very appreciated that you
report it as it saves me some time and probably avoid confusion for
other reviewers.
--
Stefano
next prev parent reply other threads:[~2025-10-31 8:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 5:42 [PATCH v7 0/5] Retry SYNs for inbound connections Yumei Huang
2025-10-31 5:42 ` [PATCH v7 1/5] tcp: Rename "retrans" to "retries" Yumei Huang
2025-10-31 5:42 ` [PATCH v7 2/5] util: Introduce read_file() and read_file_integer() function Yumei Huang
2025-11-03 0:53 ` David Gibson
2025-10-31 5:42 ` [PATCH v7 3/5] tcp: Resend SYN for inbound connections Yumei Huang
2025-11-03 1:09 ` David Gibson
2025-11-03 2:31 ` Yumei Huang
2025-11-03 9:01 ` David Gibson
2025-11-04 4:42 ` Stefano Brivio
2025-11-04 4:42 ` Stefano Brivio
2025-11-05 4:24 ` David Gibson
2025-11-05 7:00 ` Stefano Brivio
2025-11-07 9:56 ` Yumei Huang
2025-11-07 10:05 ` Stefano Brivio
2025-11-10 2:52 ` Yumei Huang
2025-11-10 4:25 ` David Gibson
2025-10-31 5:42 ` [PATCH v7 4/5] tcp: Update data retransmission timeout Yumei Huang
2025-10-31 5:56 ` Yumei Huang
2025-10-31 8:04 ` Stefano Brivio [this message]
2025-11-03 1:18 ` David Gibson
2025-11-03 2:57 ` Yumei Huang
2025-11-03 9:32 ` David Gibson
2025-11-04 4:42 ` Stefano Brivio
2025-11-05 4:19 ` David Gibson
2025-10-31 5:42 ` [PATCH v7 5/5] tcp: Clamp the retry timeout Yumei Huang
2025-10-31 8:38 ` Stefano Brivio
2025-11-03 3:11 ` Yumei Huang
2025-11-03 9:37 ` David Gibson
2025-11-03 10:55 ` Stefano Brivio
2025-11-03 1:37 ` David Gibson
2025-11-03 4:06 ` Yumei Huang
2025-11-03 10:38 ` Stefano Brivio
2025-11-05 4:22 ` David Gibson
2025-11-04 4:42 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031090437.5c9f75a4@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).