From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A+Or+a6h; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 032705A026F for ; Fri, 31 Oct 2025 09:04:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761897883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BY5qEd+Ih7G8qC8bVK0zARiDaJggRS78YM2wHNWl9wU=; b=A+Or+a6hB16o8J16jfRee99zavDxl9SYTOBjMXJeVBxFb97TGroiF3IDxH1+qCIaisGB7j F9ySovV9gjgSgHNpOvH5JmwPNcc/QV2E9AwzYcnoyUGL2SInWi0fIQnpmHjT9D32RMxdNV 1GwNil8zgZ8SSZVAoUdBOE8TF24ozQ0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-_DFwZFvyOiqnUiStm2FXeA-1; Fri, 31 Oct 2025 04:04:41 -0400 X-MC-Unique: _DFwZFvyOiqnUiStm2FXeA-1 X-Mimecast-MFC-AGG-ID: _DFwZFvyOiqnUiStm2FXeA_1761897880 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-475de0566adso15419835e9.0 for ; Fri, 31 Oct 2025 01:04:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761897880; x=1762502680; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pMvrlHRVav1ecVWn/F4ApqQUyBCpq7HGAAHAqFG5/+w=; b=YZ+Jz3M9h0XRmaeMBPYClTFT2/Puv4aPwr2IJoxvuRcmAFWdTsxiZNhH2ixUDlMRPm 4+8OkavSdMSU42Qgv+++0SorcCSkrR8c5VSkw7Q8C7NbebYPcGuBcnYlzc6VW9aZqch7 Ahry3nNtHWOvgGpysPc3CONW601JMl3DoDF5yy5mt/IHhal4B2/09NwLUhhWzDYsEAWX Hy48xkkkFYlfdJa7eWNomrLXhAdOdm1N2zCmT/XBVKBRb8utZJXK4jaDMBIGatDT9gVg Oe0B/OFSHcUY3xg96rdfXdiuecfx2Cn/cfZGOILblLNeZ99MUBKatDwAWPEWbosQBMhk Q0Fw== X-Gm-Message-State: AOJu0YxVFzba3AW+4Z1IZeNTXkV0mrv0Av1qLlnWQW8NwzKJulWM23hz rbs8Yox9cpfW/yodhYZgUZiJGcBZGN7P/XtcpD/kV1Ppz8yQp0Ptgj0/WNvwVkfGOYrbUbxJcBn QwSWwl4EODZJKmlz98QKKpsUkHFvKzlJO7oEPClFO2xCimsebsP417Q== X-Gm-Gg: ASbGncveoMVVh2XBvcLzLAk2QPgKFQ+mko6boqbYfTH0O7PpmsjBCSfM6mqAXMArsfw uxjtZtlhlbNAZcEiNIvPWV5S8q1JwiCBHyR/HobAN2Gc5DT+iXxzjcOfFxij1UH/G+eCxStH6vb M/bI1dfqOdJmZBIh+4ZRjPit47Aw3ABERxKejkHPo9A/zdXuN1eqjlq2cvg3X0I1DVtdI+dAbLv /5ntWWDNYpJWQx1ZCR6fgVfTraXGQJ9CdNxF43YqiJHTwYn5o5MIS47C8AP5lX7dvf0lNq9NQPg RbSlnJJzE/95y9Te39d50wlS6ETBWoIqUedd1d4sdjK6gV1ypRcd5J6+NTnAuvc81VjGOWHXOq/ 7LERzr86Mjv63c2h9VGTJLOmkhu8= X-Received: by 2002:a05:600c:5026:b0:475:da13:256b with SMTP id 5b1f17b1804b1-477308c6094mr20107235e9.38.1761897880021; Fri, 31 Oct 2025 01:04:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcNSYcD7NNhDPYDlyaKmfKMaCNmEjcN41qf/6Rix3f1DAxZcrHtpZFBCFI+HuQKHbZ5vwkpA== X-Received: by 2002:a05:600c:5026:b0:475:da13:256b with SMTP id 5b1f17b1804b1-477308c6094mr20106885e9.38.1761897879392; Fri, 31 Oct 2025 01:04:39 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477289adc18sm84685345e9.6.2025.10.31.01.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 01:04:38 -0700 (PDT) Date: Fri, 31 Oct 2025 09:04:37 +0100 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH v7 4/5] tcp: Update data retransmission timeout Message-ID: <20251031090437.5c9f75a4@elisabeth> In-Reply-To: References: <20251031054242.7334-1-yuhuang@redhat.com> <20251031054242.7334-5-yuhuang@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AxuFPqi3kdXkW1wgcCzNYnr-ocX6oabb1ta786WEUPE_1761897880 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XYQICXGUOQMANWIOHDVENYN7UKUWTAX7 X-Message-ID-Hash: XYQICXGUOQMANWIOHDVENYN7UKUWTAX7 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 31 Oct 2025 13:56:41 +0800 Yumei Huang wrote: > On Fri, Oct 31, 2025 at 1:43=E2=80=AFPM Yumei Huang = wrote: > > > > Use an exponential backoff timeout for data retransmission according > > to RFC 2988 and RFC 6298. Set the initial RTO to one second as discusse= d > > in Appendix A of RFC 6298. > > > > Also combine the macros defining the initial RTO for both SYN and ACK. > > > > Signed-off-by: Yumei Huang > > Reviewed-by: David Gibson =20 >=20 > I probably should have removed the reviewed-by since there are some > code changes. Thanks for reporting. I eventually notice during review and drop tags as needed but if you notice you carried a tag by mistake, it's very appreciated that you report it as it saves me some time and probably avoid confusion for other reviewers. --=20 Stefano