From: Stefano Brivio <sbrivio@redhat.com>
To: Danish Prakash <contact@danishpraka.sh>, git@maxchernoff.ca
Cc: passt-dev@passt.top, pholzing@redhat.com
Subject: Re: [PATCH v2] contrib/selinux: use regex instead of SELinux template
Date: Tue, 4 Nov 2025 22:13:44 +0100 [thread overview]
Message-ID: <20251104221344.5ba5355d@elisabeth> (raw)
In-Reply-To: <20251030104925.529411-1-contact@danishpraka.sh>
On Thu, 30 Oct 2025 16:19:13 +0530
Danish Prakash <contact@danishpraka.sh> wrote:
> It might be possible to avoid using SELinux template (%USERID),
> and instead using regex to match user ids. This would allow
> discarding the explicit restorecon call while during package builds[1].
>
> Original suggestion from cathy.hu@suse.com:
>
> > running restorecon would be unnecessary if the passt upstream selinux
> > module would not use ${USERID} in pasta.fc (gets converted to [0-9]+ anyway)
>
> [1] - https://passt.top/passt/commit/?id=e019323538699967c155c29411545223dadfc0f5
Applied, thanks for the patch and for following up!
Max, thanks for testing and reviewing, I took the liberty to translate
your comments into Tested-by: and Reviewed-by: tags as they clearly
seemed to indicate that.
--
Stefano
next prev parent reply other threads:[~2025-11-04 21:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 7:40 [PATCH] contrib/selinux: use regex instead of non-standard bash macro Danish Prakash
2025-10-16 8:21 ` Stefano Brivio
2025-10-16 10:56 ` Max Chernoff
2025-10-27 8:49 ` Danish Prakash
2025-10-27 9:07 ` Stefano Brivio
2025-10-27 9:41 ` Max Chernoff
2025-10-28 6:28 ` Danish Prakash
2025-10-28 23:17 ` Stefano Brivio
2025-10-30 8:20 ` [PATCH v2] contrib/selinux: use regex instead of SELinux template Danish Prakash
2025-10-30 8:37 ` [PATCH] contrib/selinux: use regex instead of non-standard bash macro Danish Prakash
2025-10-30 8:43 ` Stefano Brivio
2025-10-30 10:06 ` Stefano Brivio
2025-10-30 10:50 ` Danish Prakash
2025-10-30 10:49 ` [PATCH v2] contrib/selinux: use regex instead of SELinux template Danish Prakash
2025-11-04 6:48 ` Max Chernoff
2025-11-04 21:13 ` Stefano Brivio [this message]
2025-11-05 10:28 ` Max Chernoff
2025-11-05 15:31 ` Stefano Brivio
2025-11-06 12:09 ` Max Chernoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104221344.5ba5355d@elisabeth \
--to=sbrivio@redhat.com \
--cc=contact@danishpraka.sh \
--cc=git@maxchernoff.ca \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).