Re: [PATCH v2] contrib/selinux: use regex instead of SELinux template

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 05 Nov 2025 03:28:22 -0700
Max Chernoff <git@maxchernoff.ca> wrote:

> Hi Stefano,
> 
> On Tue, 2025-11-04 at 22:13 +0100, Stefano Brivio wrote:
> > Max, thanks for testing and reviewing, I took the liberty to translate
> > your comments into Tested-by: and Reviewed-by: tags as they clearly
> > seemed to indicate that.  
> 
> Ah, thanks for that! I'm still fairly new to the patch-on-a-mailing-list
> workflow, so is there something that I should have done differently?

We use pretty much the same tags as the Linux kernel does:

  https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

(except we only use Link:, not Closes:) which are nice because they're
machine-readable, so one could use, say, for instance, a script like:

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/get_maintainer.pl

to Cc: you automatically on a patch if you often reviewed or tested
the code or file affected by it.

So, here, you could have simply replied with:

    Reviewed-by: Max Chernoff <git@maxchernoff.ca>
    Tested-by: Max Chernoff <git@maxchernoff.ca>

to unequivocally state what you did with that submission.

Now, passt is small enough that we don't really have much of a use for
that at the moment, but it still sounds like a good idea in general,
also to future-proof things. It's also small enough that I can add /
fix tags as I merge patches without much fuss.

And yes, this should also be added to the new CONTRIBUTING.md file, I
have a growing list of small items to add and I'll do that in a batch
at some point. :)

-- 
Stefano