From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EYsvQCjp; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id BC8F05A061B for ; Wed, 05 Nov 2025 16:31:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762356704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3Lypve7IvV8N2oL6XJ15z/zGzzvNuHCHILDc/8pSWk=; b=EYsvQCjp5USdRt50xKEGCGkUPGcgwoFLCEQCYOifdsosdZPq+Uqm1hZ/0/u9HIO7oo/acB oWb5k3YPm+X5Zlan1XCxlgh0s3d48u0fGYrwfth8eefvGe0f5EpnfTGi0rihvrDpRvQWnL nZowHQX8WbiPZNzgeWdUSXpeEeIGx5A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-ecBtkBMFN6m21g-74R3kjQ-1; Wed, 05 Nov 2025 10:31:43 -0500 X-MC-Unique: ecBtkBMFN6m21g-74R3kjQ-1 X-Mimecast-MFC-AGG-ID: ecBtkBMFN6m21g-74R3kjQ_1762356702 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-429cd447398so2038730f8f.1 for ; Wed, 05 Nov 2025 07:31:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762356702; x=1762961502; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=D3Lypve7IvV8N2oL6XJ15z/zGzzvNuHCHILDc/8pSWk=; b=gh/E5Q7MpNe1QUvR3ZxSCAzgbTH+Qv8cvPBOg7PaLFZCAuVAVlLtcQivYOOq+y3zif l8XCg7qRBXl42e0KITsKlX2+t5FtFq0Spc9RsCP0UkQtRn1TBhsZoglOTJhc8kjHtn7K lKMlz/TEVtSVEn5o4Un065kXrJiSvaIG90QBM8w0wH1NIEenz98CjT3DxALEyFpZcvAb EN95ainMMktqi3fHrPK8Kq9CK+ARAjW9zd4kyuFwQU/DAomNvJuGwR8gU/WYe+Qs20s0 Qbg3aIcOg42vJUIWvl15DjZNIAjJ9UR5CIjx02fcXOA8mCmPJWzqaqWkdRG2OODTmj8A 733g== X-Forwarded-Encrypted: i=1; AJvYcCUzNB0tY25p+91Mp2ZM8M0GzD9MZ1MN35cznjDrRnmrZlrJSKvRU3NHtDti6igfeQ/pjvJwigUtj+g=@passt.top X-Gm-Message-State: AOJu0YzOKzFT7HA5gzBx+zCyxfXsYMHBONjQ2h5zpe3HEnsjx1wCKnHK Kpd/Hq2hgicajcn8bvHqlp/5ouk4tzUn0/YIuxZbnhCg75XTrhl1kWUMoXvUo0ks31Zdcl1Tsq4 tppaz99llI87NcpMYXWJGPG3Ww8p7ahQRi9rMKvenzxXAf2CzQDxx7g== X-Gm-Gg: ASbGncsnidMJ7z/caZ29qsFMQTPc454kTdl81899aiSWLzI+9HqtzrceY0zWIRvsCB2 9qPq76Sh7jXOPT30pzj1+VtutFZSQ8jo9/fMd4+hYOCVR0MBvPvHkbuGQYvJiwXGm/zbzVyUWcv Piwa4WRwg6LoN70QzwvAfUKaKEDCLZ9+/NYXP1MeaHSMnpWBSDHsQtA6JD8OmibR7XhJK2n7cVo p8XfiJy914NFn9AKSFs+FKzvc/tjTK2UGV5nAC7UFNdks3qZ7xr4HZjfb1KnMn03NodcpHnzoXh 7uVi0UW0o+pAn/8fIcmxX9DnDX2BE+/1mdtegiQMA6syfAfAOOD62P7DRhholEu3pNAjqU6innV 22BS5y7FVI6dqY9Z+qMbpX4LXghU= X-Received: by 2002:a05:6000:186e:b0:427:6c7:66f8 with SMTP id ffacd0b85a97d-429e330ae57mr3727055f8f.52.1762356701913; Wed, 05 Nov 2025 07:31:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyWFs6HinPJPSp5PdR3aWhpcGjbe/XGbRiZH8k8iAojawNqkil4Lu13DBZNlczh/QeEDn1KA== X-Received: by 2002:a05:6000:186e:b0:427:6c7:66f8 with SMTP id ffacd0b85a97d-429e330ae57mr3727012f8f.52.1762356701333; Wed, 05 Nov 2025 07:31:41 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429dc1f5c72sm11844249f8f.26.2025.11.05.07.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 07:31:40 -0800 (PST) Date: Wed, 5 Nov 2025 16:31:37 +0100 From: Stefano Brivio To: Max Chernoff Subject: Re: [PATCH v2] contrib/selinux: use regex instead of SELinux template Message-ID: <20251105163137.424a6537@elisabeth> In-Reply-To: References: <20251029001704.43f73a42@elisabeth> <20251030104925.529411-1-contact@danishpraka.sh> <20251104221344.5ba5355d@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: anlneEzoE4tylqihyxtRf6TCUebse_tHSpq13wLywiw_1762356702 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7HDP5RTJOXOP7JXM4GB62IAFPQK2UVUI X-Message-ID-Hash: 7HDP5RTJOXOP7JXM4GB62IAFPQK2UVUI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Danish Prakash , passt-dev@passt.top, pholzing@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 05 Nov 2025 03:28:22 -0700 Max Chernoff wrote: > Hi Stefano, > > On Tue, 2025-11-04 at 22:13 +0100, Stefano Brivio wrote: > > Max, thanks for testing and reviewing, I took the liberty to translate > > your comments into Tested-by: and Reviewed-by: tags as they clearly > > seemed to indicate that. > > Ah, thanks for that! I'm still fairly new to the patch-on-a-mailing-list > workflow, so is there something that I should have done differently? We use pretty much the same tags as the Linux kernel does: https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes (except we only use Link:, not Closes:) which are nice because they're machine-readable, so one could use, say, for instance, a script like: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/get_maintainer.pl to Cc: you automatically on a patch if you often reviewed or tested the code or file affected by it. So, here, you could have simply replied with: Reviewed-by: Max Chernoff Tested-by: Max Chernoff to unequivocally state what you did with that submission. Now, passt is small enough that we don't really have much of a use for that at the moment, but it still sounds like a good idea in general, also to future-proof things. It's also small enough that I can add / fix tags as I merge patches without much fuss. And yes, this should also be added to the new CONTRIBUTING.md file, I have a growing list of small items to add and I'll do that in a batch at some point. :) -- Stefano