From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KqsQwVaX; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 624915A061E for ; Thu, 13 Nov 2025 12:10:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763032220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R2DqniQe+Lrr30oold9Jb3XEdGjQDQpoioMXCyNp19E=; b=KqsQwVaXPuNz+7D2Wk1aVHkTlI7Ah9E0KVIJ4HcPfjCzxHvf+cjXddNUfE04g4/qdWNiLE JRcpPBypigRIerGi6Q/Av7BQ4Yc8Gk6m08dzYWQ5O4PDOS/QPmX9m60yB1N6Wixk7zpamZ AqDv4g3VKeupRcAZAXepNW04/snT4F0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-yTiBd6u8MBGEKP1Lpjqdag-1; Thu, 13 Nov 2025 06:10:18 -0500 X-MC-Unique: yTiBd6u8MBGEKP1Lpjqdag-1 X-Mimecast-MFC-AGG-ID: yTiBd6u8MBGEKP1Lpjqdag_1763032218 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47788165c97so4949875e9.0 for ; Thu, 13 Nov 2025 03:10:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763032217; x=1763637017; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R2DqniQe+Lrr30oold9Jb3XEdGjQDQpoioMXCyNp19E=; b=DlCPSVJmU3J9er+JlMkOr6HHBOsYlRnNlAXc5xLR7NbVHFi8owdMbrqdEJ9OEpp24k Tx+CAc5hMe+NrMhPDtw40JKJbXgtYEcBZ8ViolBx81s3AZIH+a6bJNmdYbxmuJLakZKG il7jcBogv9tjPHMLiFBzqFPQ2lHytZYcAI3L4ky4rpiPtLKuopohlj/RKeLIZzk0w+cx 0sNhrLSrMhycewHhbROBercH89bJCuKpVmuCOGwnr31omCZZz/029ZXsup1PWgXJArUC k1GJFN/q5co3bGJhPPo2N1ba9O7mKmQBRzyXWOnpggEUFYAutkRKj9kQjXs4alFK0ezT N8RQ== X-Gm-Message-State: AOJu0Yx4LDJAK2SbsPW5kPZNKCR1pMmaIo21vNba1yfHSejBTVnNfrIG xERr7YMQQu00wAw5xUFHOyZWixUhlTxkXd2uuat0SciA1ExAJ19KxpSp31/Y0ZPj4LFt94qDDBW KPtJqjRKwB6lopjU4OU4j/iiax+Mkyj4QRtniDgkyg0TLMjgFM/bVSQ== X-Gm-Gg: ASbGncu4toVk4bftB7PtKHe2/m1gt7MBltwRfRtNKZiPCgmss/kX7JIXxB0wVAqAqyM uhQQ5+H1vjgtlM/oyl811W7QeFfWto9LYFl/2BsWZG3euknoY4JNDI3Ug2wK/Z0twrGnlvECjfy iWp0XAH4AF9CfZeSmp9/7V9Q/pHj4J/4i3H0w6l34hvX2uNxQOw5L9YtU37SUZWQ1tvnzwuyKfa pAOjyVM/OPjekOlF6HYy520JSNYTpSm/PINxARTY7s0CPc1f2x+x1vkbaMu/4sffi6z73Ru4fFI uP+odvyeurry4vo7x+j0dcAzHTYP7lqS7PH8OpXVHWPIUWPV6usNg13Ugtle3yyJ7BXysW+kwsX bTGxV/v9/e4amcDnsxFLZMbOM9zI= X-Received: by 2002:a05:600c:35c9:b0:477:6373:f3eb with SMTP id 5b1f17b1804b1-477870a8b57mr65665355e9.31.1763032217469; Thu, 13 Nov 2025 03:10:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeiqY8iQNm2FkAY0BH3r567pjekTzwPiz3kS7ryY4wJPM/x/iAOXDZHEYBgmjWufSUpBcW2A== X-Received: by 2002:a05:600c:35c9:b0:477:6373:f3eb with SMTP id 5b1f17b1804b1-477870a8b57mr65664855e9.31.1763032216821; Thu, 13 Nov 2025 03:10:16 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c857311sm33864935e9.8.2025.11.13.03.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 03:10:16 -0800 (PST) Date: Thu, 13 Nov 2025 12:10:14 +0100 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH] spec: use %selinux_requires macro, drop overlapping dependencies Message-ID: <20251113121014.7c89b322@elisabeth> In-Reply-To: <8b1f10d9a674474e6d042b27cdee8d230bd15c0c.camel@maxchernoff.ca> References: <20251113072256.4034068-1-contact@danishpraka.sh> <8b1f10d9a674474e6d042b27cdee8d230bd15c0c.camel@maxchernoff.ca> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: og1AIQpgqdfOsCZK4gMUm2CslO2a29jXmwdX8RTgwA8_1763032218 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: SJU3KUK4L7PUXKW4IOXHJC6KX2TOOOZS X-Message-ID-Hash: SJU3KUK4L7PUXKW4IOXHJC6KX2TOOOZS X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Max Chernoff , Danish Prakash , pholzing@redhat.com, Vit Mojzis X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Adding Vit as author of some parts now changed by this patch. Full discussion thread at: https://archives.passt.top/passt-dev/20251113072256.4034068-1-contact@danishpraka.sh/ On Thu, 13 Nov 2025 02:47:42 -0700 Max Chernoff wrote: > Hi Danish, > > On Thu, 2025-11-13 at 12:52 +0530, Danish Prakash wrote: > > Also, drop unused preun policycoreutils requires. > > > > Signed-off-by: Danish Prakash > > --- > > contrib/fedora/passt.spec | 20 ++++++++------------ > > 1 file changed, 8 insertions(+), 12 deletions(-) > > > > diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec > > index d1bcf4a74338..cab2bb4c409b 100644 > > --- a/contrib/fedora/passt.spec > > +++ b/contrib/fedora/passt.spec > > @@ -34,19 +34,15 @@ for network namespaces: traffic is forwarded using a tap interface inside the > > namespace, without the need to create further interfaces on the host, hence not > > requiring any capabilities or privileges. > > > > -%package selinux > > -BuildArch: noarch > > -Summary: SELinux support for passt and pasta > > -Requires: selinux-policy-%{selinuxtype} > > -Requires: container-selinux > > -Requires(post): selinux-policy-%{selinuxtype} > > +%package selinux > > +BuildArch: noarch > > +Summary: SELinux support for passt and pasta > > +%selinux_requires > > I think that we want "%selinux_requires_min" instead, since > "%selinux_requires" also pulls in "policycoreutils-python-utils" (and > hence all of Python). > > (I'm not very familiar with spec files, but since the RPM macro > "%selinux_requires" is provided by the "selinux-policy" package, do we > also need to add a Requires/BuildRequires for that?) > > > +Requires: container-selinux > > +Requires: selinux-policy-%{selinuxtype} > > I think that "selinux-policy-%{selinuxtype}" is included via > "%selinux_requires" above. > > > Requires(post): container-selinux > > -Requires(post): policycoreutils > > -Requires(post): libselinux-utils > > -Requires(preun): policycoreutils > > -BuildRequires: selinux-policy-devel > > -BuildRequires: pkgconfig(systemd) > > -Recommends: selinux-policy-%{selinuxtype} >= %{selinux_policy_version} > > +Requires(post): selinux-policy-%{selinuxtype} > > +Recommends: selinux-policy-%{selinuxtype} >= %{selinux_policy_version} > > > > %description selinux > > This package adds SELinux enforcement to passt(1), pasta(1), passt-repair(1). > > Everything else looks good to me. > > Thanks, > -- Max > -- Stefano