From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] tcp: Properly remove sockets from epoll loop when connection is closed
Date: Thu, 13 Nov 2025 23:21:58 +0100 [thread overview]
Message-ID: <20251113232158.280b89e3@elisabeth> (raw)
In-Reply-To: <20251111032520.64266-1-david@gibson.dropbear.id.au>
On Tue, 11 Nov 2025 14:25:20 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> Most of the handling for closing a TCP connectin is in conn_event_do() when
> it receives a 'CLOSED' event. We specifically check for this case and,
> correctly, remove the connection from the flow hash table. However, we
> also bypass the call tp tcp_epoll_ctl() which is not correct. By skipping
> tcp_epoll_ctl() we skip it's specific handling of the CLOSED event, which
> includes removing the TCP socket from epoll.
>
> If we somehow get an event on such a stale socket, we'll get a stale flow
> reference. That flow slot might have been re-used, leading to to a crash
> in conn_at_sidx().
>
> Fixes: b86afe3559c0 ("tcp: Don't defer hash table removal")
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
prev parent reply other threads:[~2025-11-13 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 3:25 David Gibson
2025-11-13 22:21 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113232158.280b89e3@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).