From: Stefano Brivio <sbrivio@redhat.com>
To: Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top, david@gibson.dropbear.id.au
Subject: Re: [PATCH v8 4/6] tcp: Resend SYN for inbound connections
Date: Tue, 18 Nov 2025 01:19:42 +0100 [thread overview]
Message-ID: <20251118011942.623bf281@elisabeth> (raw)
In-Reply-To: <20251110093137.87705-5-yuhuang@redhat.com>
On Mon, 10 Nov 2025 17:31:35 +0800
Yumei Huang <yuhuang@redhat.com> wrote:
> +/**
> + * tcp_get_rto_params() - Get host kernel RTO parameters
> + * @c: Execution context
> + */
> +void tcp_get_rto_params(struct ctx *c)
> +{
> + intmax_t v;
> +
> + v = read_file_integer(SYN_RETRIES, SYN_RETRIES_DEFAULT);
> + c->tcp.syn_retries = MIN(v, MAX_SYNCNT);
> +
> + v = read_file_integer(SYN_LINEAR_TIMEOUTS, SYN_LINEAR_TIMEOUTS_DEFAULT);
> + c->tcp.syn_linear_timeouts = MIN(v, MAX_SYNCNT);
> +
> + debug("Read sysctl values syn_retries: %"PRIu8
> + ", syn_linear_timeouts: %"PRIu8,
> + c->tcp.syn_retries,
> + c->tcp.syn_linear_timeouts);
See my comment to 2/6: this should be "Using sysctl values ..." instead.
--
Stefano
next prev parent reply other threads:[~2025-11-18 0:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 9:31 [PATCH v8 0/6] Retry SYNs " Yumei Huang
2025-11-10 9:31 ` [PATCH v8 1/6] tcp: Rename "retrans" to "retries" Yumei Huang
2025-11-10 9:31 ` [PATCH v8 2/6] util: Introduce read_file() and read_file_integer() function Yumei Huang
2025-11-14 0:01 ` Stefano Brivio
2025-11-14 1:58 ` Yumei Huang
2025-11-14 4:32 ` David Gibson
2025-11-14 10:12 ` Stefano Brivio
2025-11-17 1:10 ` Yumei Huang
2025-11-18 0:19 ` Stefano Brivio
2025-11-18 0:19 ` Stefano Brivio
2025-11-18 3:22 ` David Gibson
2025-11-19 9:04 ` Yumei Huang
2025-11-19 9:38 ` David Gibson
2025-11-10 9:31 ` [PATCH v8 3/6] tcp: Add parameter struct ctx *c to tcp_timer_ctl() Yumei Huang
2025-11-10 10:35 ` David Gibson
2025-11-14 0:01 ` Stefano Brivio
2025-11-14 0:36 ` David Gibson
2025-11-10 9:31 ` [PATCH v8 4/6] tcp: Resend SYN for inbound connections Yumei Huang
2025-11-10 10:46 ` David Gibson
2025-11-14 0:00 ` Stefano Brivio
2025-11-14 0:31 ` David Gibson
2025-11-18 0:19 ` Stefano Brivio [this message]
2025-11-10 9:31 ` [PATCH v8 5/6] tcp: Update data retransmission timeout Yumei Huang
2025-11-10 9:31 ` [PATCH v8 6/6] tcp: Clamp the retry timeout Yumei Huang
2025-11-10 10:56 ` David Gibson
2025-11-14 0:01 ` Stefano Brivio
2025-11-14 0:35 ` David Gibson
2025-11-14 3:05 ` Yumei Huang
2025-11-14 3:35 ` David Gibson
2025-11-17 2:38 ` Yumei Huang
2025-11-17 4:50 ` David Gibson
2025-11-18 0:19 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118011942.623bf281@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).