From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=ILMi9ZIF; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 7430F5A0272 for ; Wed, 19 Nov 2025 05:26:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1763526396; bh=FyfVBShJ8h+BeT2A0vQj1v0B3MQMdMyVndeIce+plHA=; h=From:To:Cc:Subject:Date:From; b=ILMi9ZIFuQs6UgLEEs13RQNJlO+qGiW2KKNcMymveldfarAECfrpKMlK042ihNHQ5 JpgtCm7jyDuezzYOBxPHegUglG07l9WEu02vEIp/TPwr/7K0m8tT9ubRJFRoduW4Q/ JCNmyCurH9EQDCoHFfNHcgKpp33Td3skVJxZCCUTaJQxtqtfxY48snJXGzbxUR0gmn +yzA3ju7aM5y+gHP0+xehbCPKpL4RAw+CjiwXcRdUvn0kCv9OybHLV9I2/F9kTpqdV MqEQp7vyzCUF0VZ0xhA80qr6i1FdEQMccZoZoyqosBkxMUhcTo+ybsFPBdCUwP4vys oJ3jWfQAVNddg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4dB7j85rcXz4wGv; Wed, 19 Nov 2025 15:26:36 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 0/3] Fix regression in auto port forwarding Date: Wed, 19 Nov 2025 15:26:31 +1100 Message-ID: <20251119042634.2978171-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: FSN2C2HT3GZKZIT4ADD7BMB3C66BH2G6 X-Message-ID-Hash: FSN2C2HT3GZKZIT4ADD7BMB3C66BH2G6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: My recently merged series cleaning up the auto-port-forward scanning contained a series bug: automatic forwards would only appear on alternating seconds. This turned out to be due to a fundamentally broken premise in my thinking. I was thinking that for consistency we wanted the most recent port map information throughout the process. But that's not really true: for the purposes of exclusion what we really need to know is which of the listening sockets we scan are ours. That's given by the *prior* state of the forward maps, not the updated one based on a new scan. The series also had a number of worthwhile changes though. This series fixes it up, by reverting the most misguided of the patches and correcting behaviour of another one while preserving the accompanying code re-orgs. Link: https://bugs.passt.top/show_bug.cgi?id=176 David Gibson (3): Revert "fwd: Update all port maps before applying exclusions" fwd: Exclude ports based on prior mapping state fwd: Don't explicitly exclude reverse-direction TCP ports for UDP fwd.c | 44 ++++++++++++++++++++------------------------ 1 file changed, 20 insertions(+), 24 deletions(-) -- 2.51.1