[PATCH v4 0/9] Reduce differences between inbound and outbound socket binding

[David Gibson <david@gibson.dropbear.id.au>]

This series is based on my series fixing bug 176 (regression in auto
forwarding).

The fact that outbound forwarding sockets are bound to the loopback
address, whereas inbound forwarding sockets are (by default) bound to
the unspecified address leads to some unexpected differences between
the paths setting up each of them.

An idea for tackling bug 100 suggested a different approach which will
also reduce some of those differences and allow more code to be shared
between the two paths.  I've since discovered that this approach
doesn't help for bug 100, but I think it's still worthwhile for other reasons.

Patches 1..7/9 are cleanups which shouldn't change behaviour, and I
think are ready to merge.  8/9 and 9/9 introduce behavioural changes,
but I've made the case for them in the patch comments.

v4:
 - Add cleanup patch removing unused structure field
 - Rebase, fixing conflicts with Laurent's changes
 - A bunch of spelling and other cosmetic fixes
 - Clarify relation to bug 100 and bug 113
v3:
 - A number of additional fixes covering the handling of IPV6_V6ONLY sockopt
 - Assorted trivial changes
v2:
 - Some rearrangements and rewordings for clarity

David Gibson (9):
  flow: Remove bogus @path field from flowside_sock_args
  inany: Let length of sockaddr_inany be implicit from the family
  util, flow, pif: Simplify sock_l4_sa() interface
  tcp: Merge tcp_ns_sock_init[46]() into tcp_sock_init_one()
  udp: Unify some more inbound/outbound parts of udp_sock_init()
  udp: Move udp_sock_init() special case to its caller
  util: Fix setting of IPV6_V6ONLY socket option
  tcp, udp: Remove fallback if creating dual stack socket fails
  tcp, udp: Bind outbound listening sockets by interface instead of
    address

 conf.c       |   4 +-
 flow.c       |  22 +++----
 icmp.c       |   3 +-
 inany.h      |  17 ++++++
 pif.c        |  27 ++-------
 pif.h        |   2 +-
 tcp.c        | 164 +++++++++++++++++++--------------------------------
 tcp.h        |   5 +-
 tcp_splice.c |   5 +-
 udp.c        | 102 +++++++++++++++-----------------
 udp.h        |   5 +-
 util.c       |  76 ++++++++++++++++++++----
 util.h       |   8 ++-
 13 files changed, 221 insertions(+), 219 deletions(-)

-- 
2.51.1