From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ATmFhVa8; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 80CA05A0272 for ; Fri, 21 Nov 2025 05:46:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763700359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZtWIqDNF/1vfl61RBLKmV65kbcYXtlkVxJcRylwCYM=; b=ATmFhVa8QSz29HbZZzINcOVo4KcDDLqkN7YyAiO+N6Ec4byfv6Yg6/8KildAGePc2otShz RB7E50rjweuCeZ5PXr+QwSdL+dBiMHhuywvQ9+WKql9QgOvHUvIpfTOKgFiCxTWQYKRQpl Oib3uOB/GaU8A/JMMI5UuzFw29EFTaY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-mKZYF1XSPCa2qAou8yUN8w-1; Thu, 20 Nov 2025 23:45:56 -0500 X-MC-Unique: mKZYF1XSPCa2qAou8yUN8w-1 X-Mimecast-MFC-AGG-ID: mKZYF1XSPCa2qAou8yUN8w_1763700355 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-477a0ddd1d4so19148755e9.0 for ; Thu, 20 Nov 2025 20:45:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763700355; x=1764305155; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gZtWIqDNF/1vfl61RBLKmV65kbcYXtlkVxJcRylwCYM=; b=YaF4TI8gtbn7A22xARqKE2E4/ygsYmLwy6+EJmb4nDzp5Zkb68aebPmCBtDzqFzNkI LswDTVtyTbiHVgEeeZuNGEAEC/xrhggCkgFtyoi2B9jzAehWLHY3oX4uffjX/ckP2Zsm RXiwL7qemwLzNMm9yByWDbCHOWJn3q4OYzM9sPmTUeWwUdH0b1cc92KZfex4LDTdsj9z 2Z2rnkAGYksjeoneBHsQY4aCrjnmlEFKUtl+lzRHy0d7e0OgRAFXfYT9KJKyvEFcDynN sdgzOYpcgX+MFuX6tr9QvECUkuiaaUDhArA7y6TaFKTkg0GSOm3FtajJgRWvsVXImUkJ gVbw== X-Gm-Message-State: AOJu0YwATmno3iYzfsGeCnsYZk0+x42Rtsag9e4KV5V8PovFv/JsEEdS /JyAF3+9fnloagbDOd3L4fkIQawn6SU+z0jXJi5XplAMRDLKUxGCgRmd6M//MWGjhVC+fpb+BcI npLtcBv/VsUnvUBo9yaEPqvHj/a9ZI3HwQ9Wksy0SHam6Rtxtk4fRww== X-Gm-Gg: ASbGncv8+7Nt55jlCfVbR3k9mH0fFGvXOBVyhuRYPdnLcjfpLheaac5SGS+l9ska6sd KGkFYPkNHCA9jlkGTkoh1d4Z7NdCSr+lwSXg/npVuEi3P/8ZOGmqYJ3rHB/b4IWPC6wgKc6qgMW +ailGoYmjpeDDFrdHxHG+l7yTUQ3paFDewT/gRlDy3QEoO2yl6SbhOyMtW/MP9zBFV8sAcn/RuX SD02urieMaxoSC+lqYwIYa3zoLAG9Au/hwa9Dg7nJyYS0/aygpsotVGHQreHNDNcEkcoesamGY4 qCL6SD9w3DQMInymmq5wMfHx0iZqnqKd6o+WIHF5HJr0sLKWP9NSND7oyLD5UwJU12JlvyOAaw/ vRKTInY+DX0Vbduhqu6ZqmrZnyx61kvwZQGbgSw== X-Received: by 2002:a05:6000:401f:b0:42b:3d9d:c5f8 with SMTP id ffacd0b85a97d-42cc1cd8ee0mr628588f8f.6.1763700355104; Thu, 20 Nov 2025 20:45:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRhAcPMVkuvCwtQZ4dXOZ4m2jx+LLuQ0Mmzyg7IO/edn50dt0edHABhdpZ9isbCRHG9R0F1A== X-Received: by 2002:a05:6000:401f:b0:42b:3d9d:c5f8 with SMTP id ffacd0b85a97d-42cc1cd8ee0mr628579f8f.6.1763700354634; Thu, 20 Nov 2025 20:45:54 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e432sm8512564f8f.9.2025.11.20.20.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 20:45:53 -0800 (PST) Date: Fri, 21 Nov 2025 05:45:51 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/3] Fix regression in auto port forwarding Message-ID: <20251121054551.5c079b4c@elisabeth> In-Reply-To: <20251119042634.2978171-1-david@gibson.dropbear.id.au> References: <20251119042634.2978171-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tt2HILFdkDBZR01oe6adjHEUxv4seZJ6Qa2yzHaIUEc_1763700355 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: M7GOV3PYORXETFQXMQD3MTDIJYP6WYNK X-Message-ID-Hash: M7GOV3PYORXETFQXMQD3MTDIJYP6WYNK X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 19 Nov 2025 15:26:31 +1100 David Gibson wrote: > My recently merged series cleaning up the auto-port-forward scanning > contained a series bug: automatic forwards would only appear on > alternating seconds. > > This turned out to be due to a fundamentally broken premise in my > thinking. I was thinking that for consistency we wanted the most > recent port map information throughout the process. But that's not > really true: for the purposes of exclusion what we really need to know > is which of the listening sockets we scan are ours. That's given by > the *prior* state of the forward maps, not the updated one based on a > new scan. > > The series also had a number of worthwhile changes though. This > series fixes it up, by reverting the most misguided of the patches and > correcting behaviour of another one while preserving the accompanying > code re-orgs. > > Link: https://bugs.passt.top/show_bug.cgi?id=176 > > David Gibson (3): > Revert "fwd: Update all port maps before applying exclusions" > fwd: Exclude ports based on prior mapping state > fwd: Don't explicitly exclude reverse-direction TCP ports for UDP Applied. -- Stefano