From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Dominic Kohls <Dominic.Wenzler@rewe-group.com>
Subject: [PATCH] tcp: Enable SO_KEEPALIVE if we see keep-alive segments from container / guest
Date: Thu, 4 Dec 2025 22:25:30 +0100 [thread overview]
Message-ID: <20251204212530.2237432-1-sbrivio@redhat.com> (raw)
This is an approximation, as enabling SO_KEEPALIVE doesn't mean that
a keep-alive segment will be sent right away, rather that keep-alive
segments will start being sent if the connection is idle.
On the other hand, we don't have direct control over the host-side
TCP, so this is probably the best approximation we can get.
By default, namespaces inherit keep-alive parameters from their parent
namespace, so we can assume that, in case of a container, we'll wait
for the same interval it took for the container to start sending us
keep-alives, effectively doubling that interval.
To keep this simple, set SO_KEEPALIVE whenever we see a keep-alive
segment, instead of tracking its state. Keep-alive segments are
relatively infrequent, so we don't expect any substantial cost from
doing that.
Reported-by: Dominic Kohls <Dominic.Wenzler@rewe-group.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
tcp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tcp.c b/tcp.c
index 8357c0e..c5486bc 100644
--- a/tcp.c
+++ b/tcp.c
@@ -1838,6 +1838,9 @@ static int tcp_data_from_tap(const struct ctx *c, struct tcp_tap_conn *conn,
tcp_send_flag(c, conn, ACK);
tcp_timer_ctl(c, conn);
+ setsockopt(conn->sock, SOL_SOCKET, SO_KEEPALIVE,
+ &((int){ 1 }), sizeof(int));
+
if (p->count == 1) {
tcp_tap_window_update(c, conn,
ntohs(th->window));
--
2.43.0
next reply other threads:[~2025-12-04 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 21:25 Stefano Brivio [this message]
2025-12-05 2:54 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204212530.2237432-1-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=Dominic.Wenzler@rewe-group.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).