From: Stefano Brivio <sbrivio@redhat.com>
To: Paul Holzinger <pholzing@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] conf: Separate local mode for each IP version, don't enable disabled IP version
Date: Fri, 5 Dec 2025 13:19:13 +0100 [thread overview]
Message-ID: <20251205131913.5ea0abe2@elisabeth> (raw)
In-Reply-To: <7e69fce2-bdfb-4dbd-9336-c2ccf748afe2@redhat.com>
On Fri, 5 Dec 2025 13:00:37 +0100
Paul Holzinger <pholzing@redhat.com> wrote:
> On 05/12/2025 12:31, Stefano Brivio wrote:
> > On Fri, 5 Dec 2025 12:26:06 +0100
> > Paul Holzinger <pholzing@redhat.com> wrote:
> >
> >> On 05/12/2025 01:51, Stefano Brivio wrote:
> >>> This fixes an issue and introduces a feature:
> >>>
> >>> - in local mode, we accidentally ignored the -4 / --ipv4-only and
> >>> -6 / --ipv6-only command line options
> >>>
> >>> - if no template interface is available for a given IP version,
> >>> instead of disabling that IP version, use local mode, separately,
> >>> for it
> >>>
> >>> Link: https://bugs.passt.top/show_bug.cgi?id=129
> >>> Link: https://bugs.passt.top/show_bug.cgi?id=128
> >>> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> >> Tested-by: Paul Holzinger <pholzing@redhat.com>
> > Ah, thanks, that's quite reassuring / much needed for this one.
>
> FWIW, this is how I tested:
>
> unshare -rn sh -c "ip link add test type bridge && ip link set test up
> && ip addr add 192.168.0.0/24 dev test && ./pasta --config-net ip a"
>
> unshare -rn sh -c "ip link add test type bridge && ip link set test up
> && ip addr add 2620::1/64 dev test && ./pasta --config-net ip a"
>
> And then the variations with adding -4/-6.
I went another way:
$ ./pasta --config-net -4 -- ./pasta --config-net ip a
$ ./pasta --config-net -6 -- ./pasta --config-net ip a
...maybe we should consider to slowly start making --config-net the default.
--
Stefano
prev parent reply other threads:[~2025-12-05 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 0:51 Stefano Brivio
2025-12-05 3:01 ` David Gibson
2025-12-05 11:26 ` Paul Holzinger
2025-12-05 11:31 ` Stefano Brivio
2025-12-05 12:00 ` Paul Holzinger
2025-12-05 12:19 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205131913.5ea0abe2@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).