From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Mc+cJ+U8; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 1A50A5A0271 for ; Mon, 08 Dec 2025 11:37:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765190273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GGAcwSC9Cs84139Ar1vFxImTj3KDtANnwcJNo2NGRfk=; b=Mc+cJ+U8mPOXwEz8LKos2ppShf/2sMPM94mJls8AaNcFHHFEuQc7IQac/KqcWVBxfszH7h 4xw6/xs0zS0kYZnFHw1zEd1jKDfOfX0wkNh3l4TcJUv0rnSnuxItAlAepokMhvzYuRV1eq u5XnYJ9Y32QWSyISG1+RaTvCfZYD0pc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-GOgY0PpzNO2cmei34u9RYA-1; Mon, 08 Dec 2025 05:37:51 -0500 X-MC-Unique: GOgY0PpzNO2cmei34u9RYA-1 X-Mimecast-MFC-AGG-ID: GOgY0PpzNO2cmei34u9RYA_1765190270 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4779981523fso32237615e9.2 for ; Mon, 08 Dec 2025 02:37:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765190270; x=1765795070; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GGAcwSC9Cs84139Ar1vFxImTj3KDtANnwcJNo2NGRfk=; b=XFGD4toZ5IuCGXUZ1ZNZFpssIzVqqBOELsk1gSv7/lspVskjbxQeUVQVVZujUUy3c4 GR7QXmvPqW6dTXzydYMxESHvvMTOaU2FIiuc6Tshcm0CgduDmDkOIgQdj4Ck/mek9Wxf YzJx9yTR74Bt3PIdqP2XWHz9RCmuZee6Adp5jvHFRo4VUfMm6O9SKNBJe6JmNV2bRMlS nKZoME1XVSBG8SGapuCdOzns8GT4VZclOPw5aTRWbR3+uGKxBwQRqfaZIsE58aR6SD5C x+kOOvJjB6sVBh3ofO2nO2m+3SUVo64UmaCmBmjQXLwPjAAxL0gqM5FZWJEEtp1ck+vo J4Jw== X-Gm-Message-State: AOJu0Yz4asWZ5YGhs15YSFZ/eAlBrux1JNjwfF+PmKdM31CIzZVAukAU i0DECzmnlKeZPrygDlFdViWSf/ff+3vVc5kD9B5+DOz4OCgRgL4s7IxeL8xFvDvwYpz0kTWOvNd XNg75tyXikW4lHhJS0KKmlKbycGQ8M5ujAjQS8NkLruNbDl8IZJGAIw== X-Gm-Gg: ASbGncvtR4hbzVROmCUlQHj4QXlAxGcTZ7sfT5mKBd3/PR4U2AB9Mq1Db9Smtph/wfU hkzDaj+mLAqk74D+u+17jXnSji+XuOpiZPws2oUo/3Q8hIx76bipYZ1Z2NAka7Apo7ovxua16Xc J4Kj3cTfgW4y9k/ITi+CGFleFAaAfj61Aa7t+lYp1oDYxPICPeP9JqOElVJ7ZPF/c6AOMdZjuOL bbRqNjHO9uD3Yy0eiEao8TYiE4xJiUnDQVn1hwV2sy3wJLBsvTuoV07TyQfo6l0Yi668EM/Lmwa BOL6LWdFwi/LpO8ua9AXD3hWSbkerodj+CNFTjhB2KDy3kd2CjT5S5LDsTgseJkKgGdvmf97vj0 78372PtZr3997zSHQdeQh X-Received: by 2002:a05:600c:528a:b0:471:14f5:126f with SMTP id 5b1f17b1804b1-47939e49135mr76234735e9.33.1765190270364; Mon, 08 Dec 2025 02:37:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJ+KpHo5ohglV3fNKfli2ly4oGwTVtFbMXB5QwtmZ9JFZIFxdsletiBWCqrEpsaPHUuPCEWg== X-Received: by 2002:a05:600c:528a:b0:471:14f5:126f with SMTP id 5b1f17b1804b1-47939e49135mr76234505e9.33.1765190269989; Mon, 08 Dec 2025 02:37:49 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479310b8e70sm237908235e9.5.2025.12.08.02.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 02:37:49 -0800 (PST) Date: Mon, 8 Dec 2025 11:37:47 +0100 From: Stefano Brivio To: Max Chernoff , Danish Prakash , vmojzis@redhat.com Subject: Re: [PATCH v2] spec: use %selinux_requires_min macro, drop overlapping dependencies Message-ID: <20251208113747.21e70ba2@elisabeth> In-Reply-To: <12872851fcbd10d1c37d074ebf88daef07cc50a0.camel@maxchernoff.ca> References: <4c552ad9-ab11-4011-aee8-1f9f1246f863@redhat.com> <20251121124842.459206-1-contact@danishpraka.sh> <12872851fcbd10d1c37d074ebf88daef07cc50a0.camel@maxchernoff.ca> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kXWZ5lGThXv_pBZjKzCM8PEXvluZueE3lMKvINignqg_1765190270 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: Y5ORZSDPU3P52PAMGNFYC5Q3XF2KJSLO X-Message-ID-Hash: Y5ORZSDPU3P52PAMGNFYC5Q3XF2KJSLO X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, pholzing@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 23 Nov 2025 00:37:24 -0700 Max Chernoff wrote: > Hi Danish, > > On Fri, 2025-11-21 at 18:17 +0530, Danish Prakash wrote: > > Also, drop unused preun policycoreutils requires, and Recommends on > > selinux-policy-%{targeted}, it has since been added to > > %selinux_requires_min. > > > > Signed-off-by: Danish Prakash > > Reviewed-by: Max Chernoff > Tested-by: Max Chernoff > > (I've only tested this on F43, but the non-F43 changes also look good to > me) ...for some reason, this broke Fedora 43 Copr builds on most builders, so I just applied and posted a quick build fix: https://archives.passt.top/passt-dev/20251208103427.2535279-1-sbrivio@redhat.com/ I guess it's not a drama to start using %selinux_requires_min starting from Fedora 44 instead, regardless of whether that's the right fix. Let me know if I'm missing something though. -- Stefano > > > --- > > contrib/fedora/passt.spec | 26 ++++++++++++++------------ > > 1 file changed, 14 insertions(+), 12 deletions(-) > > > > diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec > > index d1bcf4a74338..bcbe1f77bb6c 100644 > > --- a/contrib/fedora/passt.spec > > +++ b/contrib/fedora/passt.spec > > @@ -34,19 +34,21 @@ for network namespaces: traffic is forwarded using a tap interface inside the > > namespace, without the need to create further interfaces on the host, hence not > > requiring any capabilities or privileges. > > > > -%package selinux > > -BuildArch: noarch > > -Summary: SELinux support for passt and pasta > > -Requires: selinux-policy-%{selinuxtype} > > -Requires: container-selinux > > -Requires(post): selinux-policy-%{selinuxtype} > > +%package selinux > > +BuildArch: noarch > > +Summary: SELinux support for passt and pasta > > +%if 0%{?fedora} >= 43 > > +BuildRequires: selinux-policy-devel > > +%selinux_requires_min > > +%else > > +BuildRequires: pkgconfig(systemd) > > +Requires(post): libselinux-utils > > +Requires(post): policycoreutils > > +%endif > > +Requires: container-selinux > > +Requires: selinux-policy-%{selinuxtype} > > Requires(post): container-selinux > > -Requires(post): policycoreutils > > -Requires(post): libselinux-utils > > -Requires(preun): policycoreutils > > -BuildRequires: selinux-policy-devel > > -BuildRequires: pkgconfig(systemd) > > -Recommends: selinux-policy-%{selinuxtype} >= %{selinux_policy_version} > > +Requires(post): selinux-policy-%{selinuxtype} > > > > %description selinux > > This package adds SELinux enforcement to passt(1), pasta(1), passt-repair(1). > > Thanks, > -- Max >