From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=V48nbZyv; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id A47565A0271 for ; Mon, 08 Dec 2025 22:54:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765230845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EHeWHE9NXWqAK9WtuvnWO/9bujBUo0S4yZQkT595yX8=; b=V48nbZyvhlBtB1ZDFz9dkt7Kv52SAD33seA5E4RDeG7CNirIWjuoJYmVvi2hbugRjfCVRs Lv9daddCL3+e79dLhXVfp1P7MwCd5Glleigls0dP4N42y0aUp+XOMJUMYQdXboEfQYKYUy 5+MZ2b0ZyHoTE5zkcpufE+pqsmBIbTU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633--UmiV_61OfeTVXo3wVobRA-1; Mon, 08 Dec 2025 16:54:03 -0500 X-MC-Unique: -UmiV_61OfeTVXo3wVobRA-1 X-Mimecast-MFC-AGG-ID: -UmiV_61OfeTVXo3wVobRA_1765230843 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42b2ad29140so2130104f8f.0 for ; Mon, 08 Dec 2025 13:54:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765230843; x=1765835643; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EHeWHE9NXWqAK9WtuvnWO/9bujBUo0S4yZQkT595yX8=; b=jwOkt7acCM3Cg4gR9sQtb/gslcCJCVc3krdRV/hESj/ogwFB2m9WRNQy6kxXPpwp42 HHyckZrOrxaxmuF7alHzRcjaAoHQF5YQC2q9LyrM2JLGG7snr/cdSkOG76WdDDj5Zg6f kqS1Pxx9E+hDgEbdaAYJJXymnIGIprj0t5TvhpruKTZcnLFs/hLlLPjjYrbcxwc7H5NS aBJ2YEtGbcIu1cF+WYcNqA8jbCvFWWdyGMdmLx6WvazuUTOg/vExpWWuZuzVudYaeSle zg93EoGpQrqwLVtdv6ywzSv9smOYi2Bma51BMknOXAOskyN4kJe1jz1idB7sSz7iabxJ 75yQ== X-Gm-Message-State: AOJu0Yz5Sul7RuevOxyfY79XUGOkqxDMiFGKHNcyBimJ3zmbbhz8kOq8 ePLGBppDtoWQ9D646o/f0vo4K/aatpfpiUCUKE9tKuILcvDzGCxSpUrB6fPSWGrPh1kRbB/W9B2 l+9Yps+GyxzRoj1Pt/qrvCR/TKLwanCj1eX8wiKFdnkvVA8KRtTKEtg== X-Gm-Gg: ASbGncv1NvgN4IjumIXgHizSejrXwjxTW7WMJKWv/w8W3aZ++L2qiS6uy071TiPYEuj +xmxqQiATj7cDL1FvQRTSBpP4hmI4LrLKR7ADU7rYFzugz6SrV9+v2TgLo5fd8f+1HcQzs2F83f 5qr+VFve+tXQ6kQT0j4Fb+n1bSJMRDA2KWtAFktsWRx8lyaj9t/R8yt+YzsVQwHWa4qm+ONEA0+ sby8LFtAaSslzLPM9T9meaMv+BtX5GQF5W0+bdXgK0tX63V0BFRb1D0LtfdHaFwV7Ouv61Pw/A7 /YVX+krO9WY6Oi1LvYc8MYNvg6nkbcQFnrJW0MP4fS4DiwAmVruyPuRwgyG2RsR0c82z53rLF67 szL49GVNnIUvnwhSesS6Tj9FHCPLQ0bCECvC7sw== X-Received: by 2002:a05:6000:26cf:b0:42b:4223:e63c with SMTP id ffacd0b85a97d-42f89f09f23mr10060735f8f.11.1765230842641; Mon, 08 Dec 2025 13:54:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKQ731cPPNHF6GABel8qcFCD7MB5jJIJuRRXY3q5J8MV7M6XQuYqk0PUMfQocupdGKUMMuXw== X-Received: by 2002:a05:6000:26cf:b0:42b:4223:e63c with SMTP id ffacd0b85a97d-42f89f09f23mr10060717f8f.11.1765230842215; Mon, 08 Dec 2025 13:54:02 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d331a4fsm31207850f8f.33.2025.12.08.13.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 13:54:01 -0800 (PST) Date: Mon, 8 Dec 2025 22:54:00 +0100 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH] flow: Set EPOLLFD_ID_DEFAULT on newly allocated flows, not EPOLLFD_ID_INVALID Message-ID: <20251208225400.6a054d22@elisabeth> In-Reply-To: <20251208212822.2721774-1-sbrivio@redhat.com> References: <20251208212822.2721774-1-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: L-DAxQ0_SLu9sBeC6sD8vHBQuOAENr5EHf3svdkmhqs_1765230843 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: FAZX7OIXLSWTGVYKCU7EJL6EJBU7XPIP X-Message-ID-Hash: FAZX7OIXLSWTGVYKCU7EJL6EJBU7XPIP X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 8 Dec 2025 22:28:22 +0100 Stefano Brivio wrote: > We're somehow hitting: > > ASSERTION FAILED in flow_epollfd (flow.c:362): f->epollid < ((1 << 8) - 1) > > on an inbound spliced connection, with a single forwarded port, an > HTTP server in a Podman container, and a GET request. Reproducer at > https://bodhi.fedoraproject.org/updates/FEDORA-2025-93b4eb64c3#comment-4473411 > > printf 'FROM registry.fedoraproject.org/fedora:latest\nRUN /usr/bin/dnf install -y httpd\nEXPOSE 80\nCMD ["-D", "FOREGROUND"]\nENTRYPOINT ["/usr/sbin/httpd"]\n' > Containerfile > podman build -t fedora-httpd $(pwd) > podman run -d -p 8080:80 localhost/fedora-httpd > > curl http://localhost:8080 > > I guess we don't set EPOLLFD_ID_DEFAULT early enough on inbound spliced > sockets for some reason and we get a socket event while we still have > EPOLLFD_ID_INVALID set. > > As we're not really using epoll identifiers yet, set > EPOLLFD_ID_DEFAULT right away on newly allocated flows, while we > figure this out. > > Link: https://bodhi.fedoraproject.org/updates/FEDORA-2025-93b4eb64c3#comment-4473411 > Signed-off-by: Stefano Brivio > --- > I just merged this, posting for awareness / review. Ah, never mind, this makes it worse somehow: 5.6384: Flow 0 (TCP connection (spliced)): SPLICE_CONNECT 5.6384: Flow 0 (TCP connection (spliced)): ERROR on epoll_ctl(): No such file or directory ...still looking for a workaround / fix. -- Stefano