From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GlT2Esws; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 991C95A0271 for ; Tue, 09 Dec 2025 00:46:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765237613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YZYNxCPJVLxndPHMRovK1T+1NN6C1a+0w3wGUMWpMUw=; b=GlT2EswsjbwScceOrgh7Pu9bD95ntB3jguSswrlBBAU+aGNGNKzXb4JdgHbhuddTQ0fFAN Rzbe18RrSwV/6KpcJhOK2A3FEuSsLcI7oapffiaafevySjk5a/fRycts6yQ/2LRXWqmcVc Yv68vqD3aAvaDlO/7hcPenIKMRxFCDg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-Wb788ynnMyOiwniEmWxmeA-1; Mon, 08 Dec 2025 18:46:45 -0500 X-MC-Unique: Wb788ynnMyOiwniEmWxmeA-1 X-Mimecast-MFC-AGG-ID: Wb788ynnMyOiwniEmWxmeA_1765237604 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42f9f4da5a5so34837f8f.0 for ; Mon, 08 Dec 2025 15:46:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765237604; x=1765842404; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YZYNxCPJVLxndPHMRovK1T+1NN6C1a+0w3wGUMWpMUw=; b=l9h+aiWqhorpLulDUt5HmIath+X+Z3Wdz2cFE4LhvvXGOpLgP7blJNLd2whZYio1r7 ac1sGZsmsdfr83PnVW3lqLmfmD9YA+oQgpHp/+vLgvPakzzKgRPTn1Uu39jqRMa3LpPE Jvk36ZQYMGoPU13/5LeydJpmFBI1Ob2C92QQZQYw/BiCPD7JvZgKZWXS7kb7UkVGuneK +c9GmdeOTsB0/QP7fEtKHleCoMNnAQDaClciH6hgU1tm4atOnz79BxeopaPwtMeclV8e ZpuB+Tc8rqWOOLJ7zHWEOvAHYOYBQjfOUGPONzsKDp5eSnB7ZJbAojorIlR+o7Nxh5Pk xV7Q== X-Gm-Message-State: AOJu0YwREssGcir97fX5NWoDm+M/TB2pusP4rO3+sCKzJtTT8M3R+eBk FKo4cYTmA52M93AwVOZxdDEBfHQ+p1LL4d5NFBYReXbwRqzb2GMRFJ78/FUtEZChZtL39M9KPJy mp6qo0acT7A4oGBQsPA84XhhUzqT9upF1bUc28X9HrrFzn7jQNZrQaQ== X-Gm-Gg: ASbGncs4MDXk0tjtSMTBfWv6XGUkejrDP+bSfmWBk354cXVI4UeW1mBY3stU6m+Zo1w IQXX40LAF3+sjKolyTPqYxos3I/HbbORMLIzfY3l1lgFmvTCRBkVS7WKUCXxBO9924ZqkHAywOf Y+zvUEHHZpH9dZN0In7ca3NOM5pdOpTQqoxl+MfsghVQxuq7AD4EX2dp9Ut8f3ECrK9KZfWcjDU purTkN23eS2MB00tygZjL9BpTRVFZZlhYhquaiWmItcJ0+3HWG4oJ0tySqo+PUR53j4ncXuL0Et EfE8Bf/gomM1touhnAG3DsQakAk1ZLtdCkmSn2TyG+nwfmuJ3pJrPIynFEitdcxQzZonAHNZZnt J+EDz5uq52KyVIrQHeXSVocmDBfDisQCcOVendA== X-Received: by 2002:a05:6000:24c1:b0:429:d66b:507f with SMTP id ffacd0b85a97d-42f89f529f1mr9301257f8f.48.1765237603816; Mon, 08 Dec 2025 15:46:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEG5SmAlDMFFOl2shB2PbpUJqtdbjNwqFAk25trJEaNnmkmqym/BsgcQlXOi7gRYPhvDOBOQ== X-Received: by 2002:a05:6000:24c1:b0:429:d66b:507f with SMTP id ffacd0b85a97d-42f89f529f1mr9301244f8f.48.1765237603296; Mon, 08 Dec 2025 15:46:43 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbe9070sm28004814f8f.7.2025.12.08.15.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 15:46:42 -0800 (PST) Date: Tue, 9 Dec 2025 00:46:41 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] flow: Set EPOLLFD_ID_DEFAULT on newly allocated flows, not EPOLLFD_ID_INVALID Message-ID: <20251209004641.1c0b6bc3@elisabeth> In-Reply-To: References: <20251208212822.2721774-1-sbrivio@redhat.com> <20251208225400.6a054d22@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7vvRqr1daNQAlO694T4Oo-Yydt66VTL3EsutdTw7Qn0_1765237604 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: CPLRQBQ6C6GTJM4LK6TBRXH33TJEZIWB X-Message-ID-Hash: CPLRQBQ6C6GTJM4LK6TBRXH33TJEZIWB X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 9 Dec 2025 10:36:01 +1100 David Gibson wrote: > On Mon, Dec 08, 2025 at 10:54:00PM +0100, Stefano Brivio wrote: > > On Mon, 8 Dec 2025 22:28:22 +0100 > > Stefano Brivio wrote: > > > > > We're somehow hitting: > > > > > > ASSERTION FAILED in flow_epollfd (flow.c:362): f->epollid < ((1 << 8) - 1) > > > > > > on an inbound spliced connection, with a single forwarded port, an > > > HTTP server in a Podman container, and a GET request. Reproducer at > > > https://bodhi.fedoraproject.org/updates/FEDORA-2025-93b4eb64c3#comment-4473411 > > > > > > printf 'FROM registry.fedoraproject.org/fedora:latest\nRUN /usr/bin/dnf install -y httpd\nEXPOSE 80\nCMD ["-D", "FOREGROUND"]\nENTRYPOINT ["/usr/sbin/httpd"]\n' > Containerfile > > > podman build -t fedora-httpd $(pwd) > > > podman run -d -p 8080:80 localhost/fedora-httpd > > > > > > curl http://localhost:8080 > > > > > > I guess we don't set EPOLLFD_ID_DEFAULT early enough on inbound spliced > > > sockets for some reason and we get a socket event while we still have > > > EPOLLFD_ID_INVALID set. > > > > > > As we're not really using epoll identifiers yet, set > > > EPOLLFD_ID_DEFAULT right away on newly allocated flows, while we > > > figure this out. > > > > > > Link: https://bodhi.fedoraproject.org/updates/FEDORA-2025-93b4eb64c3#comment-4473411 > > > Signed-off-by: Stefano Brivio > > > --- > > > I just merged this, posting for awareness / review. > > > > Ah, never mind, this makes it worse somehow: > > > > 5.6384: Flow 0 (TCP connection (spliced)): SPLICE_CONNECT > > 5.6384: Flow 0 (TCP connection (spliced)): ERROR on epoll_ctl(): No such file or directory > > Does this imply you managed to reproduce locally? You hadn't as of > your comment a few after the one linked. I also haven't managed to > reproduce this. Just simulate an error (that's not EINPROGRESS) on connect() in tcp_splice_connect(). Patch coming. -- Stefano