From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hkPtd0Dr; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 9CD555A0271 for ; Tue, 09 Dec 2025 01:05:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765238726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CNmgSmBA2gmxc2J0M5ERsekaV8OUjW4LHEVYQrA/Xps=; b=hkPtd0Dr0yaK9u7PsS9XCm/eJqHeaVwex/5CdTLQ1oU2+zzQTtOjuA0ERQ33Hby/wSNLab cd2DnL87A1UNbH1OUVpEVajyHSmZSyQ/9M1gHanh0ZK0x6TO06q2Oo0RTdYHWyAs9e8Xj6 w4+w8mBUAwztAqLWXATj7uOaDmQvY44= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-685-gLEcIEfTOp6y552i7Mccaw-1; Mon, 08 Dec 2025 19:05:15 -0500 X-MC-Unique: gLEcIEfTOp6y552i7Mccaw-1 X-Mimecast-MFC-AGG-ID: gLEcIEfTOp6y552i7Mccaw_1765238714 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779b432aecso30039345e9.0 for ; Mon, 08 Dec 2025 16:05:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765238714; x=1765843514; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CNmgSmBA2gmxc2J0M5ERsekaV8OUjW4LHEVYQrA/Xps=; b=TMRlChzAyvCUc1BNYUKXtelDalXdO4MbYoqD5y6P2XkMEY1tYFWIFwCbQ26Y0zXl8n UgDbY8ZCEsgAaz5it4N5EV79bVF2FQqcdygBiiP3YLuw6kFKs4u/K66FXpBDpj6/EuQB 3pamtxtvgyN5NBW8mg1Q62wsE/Vh96UL/cJPRmMZ8OMhWQvrzfvkxvekyYnJoOXdRw6d PVHhOTdSv3IdcLTeUNB7Gg/KdAaCeAtY0kU+1397mfNbu3EGO1pQk6+Z5RFScZrsBkaW ikTqe+mJ880AiRJgv8pStCpIgzHvu1WPkxW4caujpnsnaXqGhln+66Ald4dhzw5RYrJT t5wQ== X-Gm-Message-State: AOJu0Ywww/gkgaOkb8k0u4RsVTTxIrY0HfekCybt6Mw54eWa909WHvvL 5zoE2wOfKW8Rw/OljARX2EFBbK5TgHy2ReXrlTJClrmzQhqQ15lpeDNSqUV4s+VXcEJxsxiFk0X 7kdUSdkrGcE1Nms9uusRgb5E6C/wmlXUBwWQEv50CBA5O5WtRQbgEEA== X-Gm-Gg: ASbGncsp0OqWbj1yoeI4zJkRbGbhyPhNIhkwhKGcuqA3NJ/6u4goqnoycvYWb6aCi+7 G2uNKtlSZ0oAw8Tvpya9uts8579rrFOkX5KZgUKsF2xZ1Ds6s30oB50hhNSNkEzLqyGASPOGRY1 2z9+NHW1jl+Edni6frG28+osZvIG9epH0ro7tuajQXPLGDgvyxS1BI/6tU0c5IgL3v+VZDdRwGE KCDnXU91ZFmzRlwRppZPyC2gomFPygWMcQNHMxe/unuKERzMaZOU4PtSM9Ibpe5kXyRdMfrOWmT ibiJ/dfrx7Chslc8PArkM4H7aQiKfu/y+eTfdp8GtJRWI1fnOuJJpgXr9Up70t1o1UmZJayfsAJ DpqyYY2TSIN8f3mQf0ZA8 X-Received: by 2002:a05:6000:1863:b0:42b:2c53:3aba with SMTP id ffacd0b85a97d-42f89f0aaafmr10839385f8f.10.1765238713703; Mon, 08 Dec 2025 16:05:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/hYc8PMPr0Vf+OWCRB+838g0xnqrnrE/NQSeEUwqxnewy4t2/wb4api8S6hcsNNMWydllzw== X-Received: by 2002:a05:6000:1863:b0:42b:2c53:3aba with SMTP id ffacd0b85a97d-42f89f0aaafmr10839369f8f.10.1765238713173; Mon, 08 Dec 2025 16:05:13 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbfeb38sm27794282f8f.12.2025.12.08.16.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 16:05:12 -0800 (PST) Date: Tue, 9 Dec 2025 01:05:11 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] flow: Set EPOLLFD_ID_DEFAULT on newly allocated flows, not EPOLLFD_ID_INVALID Message-ID: <20251209010511.5759a219@elisabeth> In-Reply-To: References: <20251208212822.2721774-1-sbrivio@redhat.com> <20251208225400.6a054d22@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7CoZPDlyHvNy4vg6Kin5uAvc225NJbVxn9ue7XetkMM_1765238714 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KV3PPD45C3R5IHAF3PK7D5V7BW2NRIYC X-Message-ID-Hash: KV3PPD45C3R5IHAF3PK7D5V7BW2NRIYC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 9 Dec 2025 11:01:27 +1100 David Gibson wrote: > Could the flow - for some other reason - be closing almost > immediately, before it even adds itself to the epoll? If that's the > case, we could potentially trigger this in the (flag == CLOSING) > section of conn_flag_do(). Yes, that's what happens, see my previous email. -- Stefano