From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KhUe3aRV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 0589E5A0624 for ; Tue, 09 Dec 2025 14:49:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765288148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=07ZqUOW1N4b2wjZrHOw2XliDvLVXTAn4oNtyolMk0NI=; b=KhUe3aRVwF5xZ2m8Ln9o4YD7p5mgZ1fitWqG/gGw1ozdxz/B4Df8SWbra28KCnmMas8SrN lBEaTWq2N2aNRE9a3O6siYMpK+Qxy9XDvBRDJbkhRlYQozS5s/1pE4/8NmmdhbHvgfIpp8 sZqYmaEp1E9NjpiNu8sja+Ge+VUgyK0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-HGLCuJmbPqSkWbgUtwroGQ-1; Tue, 09 Dec 2025 08:49:07 -0500 X-MC-Unique: HGLCuJmbPqSkWbgUtwroGQ-1 X-Mimecast-MFC-AGG-ID: HGLCuJmbPqSkWbgUtwroGQ_1765288146 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97BFA19560A2 for ; Tue, 9 Dec 2025 13:49:06 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.45.224.167]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 948FA30001A5; Tue, 9 Dec 2025 13:49:05 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH] tcp: Suppress false positive cppcheck warning in tcp_update_seqack_wnd() Date: Tue, 9 Dec 2025 14:49:04 +0100 Message-ID: <20251209134904.3237912-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -uM_27MVMrQRd8LZ0u5ROiqOQ06yAz4HwWgZHgLZ20g_1765288146 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: HZRJVXBYAN7PSJXBDNHKEC23WWTEOZFG X-Message-ID-Hash: HZRJVXBYAN7PSJXBDNHKEC23WWTEOZFG X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Cppcheck doesn't track that tinfo is reassigned to &tinfo_new when NULL, leading to a false uninitvar warning at line 1099. Add inline suppression. Signed-off-by: Laurent Vivier --- tcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tcp.c b/tcp.c index 17fda5dcd7db..8dabfd3042d2 100644 --- a/tcp.c +++ b/tcp.c @@ -1132,6 +1132,7 @@ int tcp_update_seqack_wnd(const struct ctx *c, struct tcp_tap_conn *conn, return 0; } + /* cppcheck-suppress uninitvar */ if ((unsigned)SNDBUF_GET(conn) > (long long)tinfo->tcpi_rtt * tinfo->tcpi_delivery_rate / 1000 / 1000 * -- 2.51.1