public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Jon Maloy <jmaloy@redhat.com>
To: sbrivio@redhat.com, dgibson@redhat.com,
	david@gibson.dropbear.id.au, jmaloy@redhat.com,
	passt-dev@passt.top
Subject: [RFC  04/12] conf: Apply -n/--netmask to most recently added address
Date: Sun, 14 Dec 2025 20:54:33 -0500	[thread overview]
Message-ID: <20251215015441.887736-5-jmaloy@redhat.com> (raw)
In-Reply-To: <20251215015441.887736-1-jmaloy@redhat.com>

We allow for multiple -n/--netmask options, and update the handling so
that each given prefix length is applied to the most recently added
address instead of always to addrs[0].

This allows per-address prefix configuration, such as:

    -a 10.0.0.1 -n 24 -a 10.0.0.2 -n 16

If no address has been added yet, -n still applies to addrs[0] for
backwards compatibility.

Signed-off-by: Jon Maloy <jmaloy@redhat.com>
---
 conf.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/conf.c b/conf.c
index e9f217b..0a4a28a 100644
--- a/conf.c
+++ b/conf.c
@@ -1528,6 +1528,7 @@ void conf(struct ctx *c, int argc, char **argv)
 	size_t logsize = 0;
 	char *runas = NULL;
 	long fd_tap_opt;
+	int prefix, idx;
 	int name, ret;
 	uid_t uid;
 	gid_t gid;
@@ -1872,10 +1873,14 @@ void conf(struct ctx *c, int argc, char **argv)
 			die("Invalid address: %s", optarg);
 			break;
 		case 'n':
-			c->ip4.addrs[0].prefix_len = conf_ip4_prefix(optarg);
-			if (c->ip4.addrs[0].prefix_len < 0)
+			prefix = conf_ip4_prefix(optarg);
+
+			if (prefix < 0)
 				die("Invalid netmask: %s", optarg);
 
+			/* Apply to most recent address, or addrs[0] if none yet */
+			idx = c->ip4.addr_count ? c->ip4.addr_count - 1 : 0;
+			c->ip4.addrs[idx].prefix_len = prefix;
 			break;
 		case 'M':
 			parse_mac(c->our_tap_mac, optarg);
-- 
2.51.1


  parent reply	other threads:[~2025-12-15  1:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15  1:54 [RFC 00/12] Support for multiple address and late binding Jon Maloy
2025-12-15  1:54 ` [RFC 01/12] ip: Introduce multi-address data structures for IPv4 and IPv6 Jon Maloy
2025-12-15  9:40   ` David Gibson
2025-12-15 22:05     ` Jon Maloy
2025-12-16  1:58       ` Jon Maloy
2025-12-16  3:14         ` David Gibson
2025-12-15  9:46   ` David Gibson
2025-12-15  1:54 ` [RFC 02/12] ip: Add ip4_default_prefix_len() helper function for class-based prefix Jon Maloy
2025-12-15  9:41   ` David Gibson
2025-12-15  1:54 ` [RFC 03/12] conf: Allow multiple -a/--address options per address family Jon Maloy
2025-12-15  9:53   ` David Gibson
2025-12-15  1:54 ` Jon Maloy [this message]
2025-12-15  9:54   ` [RFC 04/12] conf: Apply -n/--netmask to most recently added address David Gibson
2025-12-15 22:43     ` Jon Maloy
2025-12-15  1:54 ` [RFC 05/12] fwd: Check all configured addresses in guest accessibility functions Jon Maloy
2025-12-15 10:06   ` David Gibson
2025-12-15  1:54 ` [RFC 06/12] arp: Check all configured addresses in ARP filtering Jon Maloy
2025-12-15 10:07   ` David Gibson
2025-12-15  1:54 ` [RFC 07/12] netlink: Subscribe to link/address changes in namespace Jon Maloy
2025-12-15 10:32   ` David Gibson
2025-12-15 23:25     ` Jon Maloy
2025-12-16  3:21       ` David Gibson
2025-12-15  1:54 ` [RFC 08/12] netlink: Subscribe to route " Jon Maloy
2025-12-15 10:38   ` David Gibson
2025-12-15  1:54 ` [RFC 09/12] netlink: Add host-side monitoring for late template interface binding Jon Maloy
2025-12-15  1:54 ` [RFC 10/12] netlink: Add host-side route monitoring and propagation Jon Maloy
2025-12-15  1:54 ` [RFC 11/12] netlink: Prevent host route events from overwriting guest-configured gateway Jon Maloy
2025-12-15  1:54 ` [RFC 12/12] netlink: Rename tap interface when late binding discovers template name Jon Maloy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251215015441.887736-5-jmaloy@redhat.com \
    --to=jmaloy@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgibson@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).