From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IGmLRE1/; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 16B515A0773 for ; Mon, 15 Dec 2025 13:40:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765802422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cM7UgOQltmE2NT7F3qoG/JFPi4cxcsvLrbiap1Qw9mI=; b=IGmLRE1/tDvg8bk0grh21SfNNteKuqDunrTNVVj+CqFlqUjNJctUAbgFh4uqwr4Q/4vqyM B6aq8PM454nm8X4a4hKx8sJhASk6wWqDNrNAauzkYzuvR82Xj0rKw/S+M1S7OmyYoC4P6y gsBftruglg7taGDsNSCMmy3OLxEihjo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-9mIzdZKIN0KhN2j1jeHK0g-1; Mon, 15 Dec 2025 07:40:20 -0500 X-MC-Unique: 9mIzdZKIN0KhN2j1jeHK0g-1 X-Mimecast-MFC-AGG-ID: 9mIzdZKIN0KhN2j1jeHK0g_1765802419 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7EF161956054 for ; Mon, 15 Dec 2025 12:40:19 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.34.89]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 85A2E180044F; Mon, 15 Dec 2025 12:40:18 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH v4 5/6] tap: Convert packet pools to per-queue-pair arrays for multiqueue Date: Mon, 15 Dec 2025 13:40:06 +0100 Message-ID: <20251215124007.1549660-6-lvivier@redhat.com> In-Reply-To: <20251215124007.1549660-1-lvivier@redhat.com> References: <20251215124007.1549660-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EYszAzCA8lLWuARcv9A-zpk6kB655R9yWfs7J13xzWE_1765802419 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: MBCQSX42CZWQ4AS77UJY5TAOGRMUKKW3 X-Message-ID-Hash: MBCQSX42CZWQ4AS77UJY5TAOGRMUKKW3 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Convert the global pool_tap4 and pool_tap6 packet pools from single pools to arrays of pools, one for each queue pair. This change is necessary to support multiqueue operation in vhost-user mode, where multiple queue pairs may be processing packets concurrently. The pool storage structures (pool_tap4_storage and pool_tap6_storage) are now arrays of VHOST_USER_MAX_VQS/2 elements, with corresponding pointer arrays (pool_tap4 and pool_tap6) for accessing them. Update tap_flush_pools() and tap_handler() to take a qpair parameter that selects which pool to operate on. Add bounds checking assertions to ensure qpair is within valid range. In passt and pasta modes, all operations use queue pair 0 (hardcoded in tap_passt_input and tap_pasta_input). In vhost-user mode, the queue pair is derived from the virtqueue index (index / 2, as TX/RX queues come in pairs). All pools within the array share the same buffer pointer: - In vhost-user mode: Points to the vhost-user memory structure, which is safe as packet data remains in guest memory and pools only track iovecs - In passt/pasta mode: Points to pkt_buf, which is safe as only queue pair 0 is used Signed-off-by: Laurent Vivier --- tap.c | 77 ++++++++++++++++++++++++++++++----------------------- tap.h | 5 ++-- vu_common.c | 2 +- 3 files changed, 48 insertions(+), 36 deletions(-) diff --git a/tap.c b/tap.c index 1bbf6d2c897e..332a1187aa06 100644 --- a/tap.c +++ b/tap.c @@ -94,9 +94,13 @@ CHECK_FRAME_LEN(L2_MAX_LEN_VU); DIV_ROUND_UP(sizeof(pkt_buf), \ ETH_HLEN + sizeof(struct ipv6hdr) + sizeof(struct udphdr)) -/* IPv4 (plus ARP) and IPv6 message batches from tap/guest to IP handlers */ -static PACKET_POOL_NOINIT(pool_tap4, TAP_MSGS_IP4); -static PACKET_POOL_NOINIT(pool_tap6, TAP_MSGS_IP6); +/* IPv4 (plus ARP) and IPv6 message batches from tap/guest to IP handlers + * One pool per queue pair for multiqueue support + */ +static PACKET_POOL_DECL(pool_tap4, TAP_MSGS_IP4) pool_tap4_storage[VHOST_USER_MAX_VQS / 2]; +static struct pool *pool_tap4[VHOST_USER_MAX_VQS / 2]; +static PACKET_POOL_DECL(pool_tap6, TAP_MSGS_IP6) pool_tap6_storage[VHOST_USER_MAX_VQS / 2]; +static struct pool *pool_tap6[VHOST_USER_MAX_VQS / 2]; #define TAP_SEQS 128 /* Different L4 tuples in one batch */ #define FRAGMENT_MSG_RATE 10 /* # seconds between fragment warnings */ @@ -723,12 +727,12 @@ static int tap4_handler(struct ctx *c, unsigned int qpair, unsigned int i, j, seq_count; struct tap4_l4_t *seq; - if (!c->ifi4 || !pool_tap4->count) - return pool_tap4->count; + if (!c->ifi4 || !pool_tap4[qpair]->count) + return pool_tap4[qpair]->count; i = 0; resume: - for (seq_count = 0, seq = NULL; i < pool_tap4->count; i++) { + for (seq_count = 0, seq = NULL; i < pool_tap4[qpair]->count; i++) { size_t l3len, hlen, l4len; struct ethhdr eh_storage; struct iphdr iph_storage; @@ -738,7 +742,7 @@ resume: struct iov_tail data; struct iphdr *iph; - if (!packet_get(pool_tap4, i, &data)) + if (!packet_get(pool_tap4[qpair], i, &data)) continue; eh = IOV_PEEK_HEADER(&data, eh_storage); @@ -805,7 +809,7 @@ resume: if (iph->protocol == IPPROTO_UDP) { struct iov_tail eh_data; - packet_get(pool_tap4, i, &eh_data); + packet_get(pool_tap4[qpair], i, &eh_data); if (dhcp(c, qpair, &eh_data)) continue; } @@ -836,7 +840,7 @@ resume: goto append; if (seq_count == TAP_SEQS) - break; /* Resume after flushing if i < pool_tap4->count */ + break; /* Resume after flushing if i < pool_tap4[qpair]->count */ for (seq = tap4_l4 + seq_count - 1; seq >= tap4_l4; seq--) { if (L4_MATCH(iph, uh, seq)) { @@ -882,10 +886,10 @@ append: } } - if (i < pool_tap4->count) + if (i < pool_tap4[qpair]->count) goto resume; - return pool_tap4->count; + return pool_tap4[qpair]->count; } /** @@ -901,12 +905,12 @@ static int tap6_handler(struct ctx *c, unsigned int qpair, const struct timespec unsigned int i, j, seq_count = 0; struct tap6_l4_t *seq; - if (!c->ifi6 || !pool_tap6->count) - return pool_tap6->count; + if (!c->ifi6 || !pool_tap6[qpair]->count) + return pool_tap6[qpair]->count; i = 0; resume: - for (seq_count = 0, seq = NULL; i < pool_tap6->count; i++) { + for (seq_count = 0, seq = NULL; i < pool_tap6[qpair]->count; i++) { size_t l4len, plen, check; struct in6_addr *saddr, *daddr; struct ipv6hdr ip6h_storage; @@ -918,7 +922,7 @@ resume: struct ipv6hdr *ip6h; uint8_t proto; - if (!packet_get(pool_tap6, i, &data)) + if (!packet_get(pool_tap6[qpair], i, &data)) return -1; eh = IOV_REMOVE_HEADER(&data, eh_storage); @@ -1026,7 +1030,7 @@ resume: goto append; if (seq_count == TAP_SEQS) - break; /* Resume after flushing if i < pool_tap6->count */ + break; /* Resume after flushing if i < pool_tap6[qpair]->count */ for (seq = tap6_l4 + seq_count - 1; seq >= tap6_l4; seq--) { if (L4_MATCH(ip6h, proto, uh, seq)) { @@ -1073,19 +1077,19 @@ append: } } - if (i < pool_tap6->count) + if (i < pool_tap6[qpair]->count) goto resume; - return pool_tap6->count; + return pool_tap6[qpair]->count; } /** - * tap_flush_pools() - Flush both IPv4 and IPv6 packet pools + * tap_flush_pools() - Flush both IPv4 and IPv6 packet pools for a given qpair */ -void tap_flush_pools(void) +void tap_flush_pools(unsigned int qpair) { - pool_flush(pool_tap4); - pool_flush(pool_tap6); + pool_flush(pool_tap4[qpair]); + pool_flush(pool_tap6[qpair]); } /** @@ -1096,6 +1100,7 @@ void tap_flush_pools(void) */ void tap_handler(struct ctx *c, unsigned int qpair, const struct timespec *now) { + ASSERT(qpair < VHOST_USER_MAX_VQS / 2); tap4_handler(c, qpair, now); tap6_handler(c, qpair, now); } @@ -1128,21 +1133,23 @@ void tap_add_packet(struct ctx *c, unsigned int qpair, struct iov_tail *data, proto_update_l2_buf(c->guest_mac); } + ASSERT(qpair < VHOST_USER_MAX_VQS / 2); + switch (ntohs(eh->h_proto)) { case ETH_P_ARP: case ETH_P_IP: - if (!pool_can_fit(pool_tap4, data)) { + if (!pool_can_fit(pool_tap4[qpair], data)) { tap4_handler(c, qpair, now); - pool_flush(pool_tap4); + pool_flush(pool_tap4[qpair]); } - packet_add(pool_tap4, data); + packet_add(pool_tap4[qpair], data); break; case ETH_P_IPV6: - if (!pool_can_fit(pool_tap6, data)) { + if (!pool_can_fit(pool_tap6[qpair], data)) { tap6_handler(c, qpair, now); - pool_flush(pool_tap6); + pool_flush(pool_tap6[qpair]); } - packet_add(pool_tap6, data); + packet_add(pool_tap6[qpair], data); break; default: break; @@ -1182,7 +1189,7 @@ static void tap_passt_input(struct ctx *c, const struct timespec *now) ssize_t n; char *p; - tap_flush_pools(); + tap_flush_pools(0); if (partial_len) { /* We have a partial frame from an earlier pass. Move it to the @@ -1265,7 +1272,7 @@ static void tap_pasta_input(struct ctx *c, const struct timespec *now) { ssize_t n, len; - tap_flush_pools(); + tap_flush_pools(0); for (n = 0; n <= (ssize_t)(sizeof(pkt_buf) - L2_MAX_LEN_PASTA); @@ -1522,10 +1529,14 @@ static void tap_sock_tun_init(struct ctx *c) */ static void tap_sock_update_pool(void *base, size_t size) { - int i; + unsigned int i; - pool_tap4_storage = PACKET_INIT(pool_tap4, TAP_MSGS_IP4, base, size); - pool_tap6_storage = PACKET_INIT(pool_tap6, TAP_MSGS_IP6, base, size); + for (i = 0; i < VHOST_USER_MAX_VQS / 2; i++) { + pool_tap4_storage[i] = PACKET_INIT(pool_tap4, TAP_MSGS_IP4, base, size); + pool_tap4[i] = (struct pool *)&pool_tap4_storage[i]; + pool_tap6_storage[i] = PACKET_INIT(pool_tap6, TAP_MSGS_IP6, base, size); + pool_tap6[i] = (struct pool *)&pool_tap6_storage[i]; + } for (i = 0; i < TAP_SEQS; i++) { tap4_l4[i].p = PACKET_INIT(pool_l4, UIO_MAXIOV, base, size); diff --git a/tap.h b/tap.h index 463bb710d344..c695fec4b5b2 100644 --- a/tap.h +++ b/tap.h @@ -119,8 +119,9 @@ void tap_handler_passt(struct ctx *c, uint32_t events, int tap_sock_unix_open(char *sock_path); void tap_sock_reset(struct ctx *c); void tap_backend_init(struct ctx *c); -void tap_flush_pools(void); -void tap_handler(struct ctx *c, unsigned int qpair, const struct timespec *now); +void tap_flush_pools(unsigned int qpair); +void tap_handler(struct ctx *c, unsigned int qpair, + const struct timespec *now); void tap_add_packet(struct ctx *c, unsigned int qpair, struct iov_tail *data, const struct timespec *now); #endif /* TAP_H */ diff --git a/vu_common.c b/vu_common.c index ce945150a0ce..03ded08db72e 100644 --- a/vu_common.c +++ b/vu_common.c @@ -171,7 +171,7 @@ static void vu_handle_tx(struct vu_dev *vdev, int index, ASSERT(QPAIR_FROMGUEST_QUEUE(QPAIR_FROM_QUEUE(index)) == (unsigned int)index); - tap_flush_pools(); + tap_flush_pools(QPAIR_FROM_QUEUE(index)); count = 0; out_sg_count = 0; -- 2.51.1