public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 1/3] treewide: Fix more pointers which can be const
Date: Tue, 13 Jan 2026 14:54:13 +1100	[thread overview]
Message-ID: <20260113035415.685242-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260113035415.685242-1-david@gibson.dropbear.id.au>

Here are some more pointers which can be const, as reported by cppcheck
2.19.1.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 conf.c       | 2 +-
 dhcpv6.c     | 3 ++-
 vhost_user.c | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/conf.c b/conf.c
index b1fc4b9f..a242fda1 100644
--- a/conf.c
+++ b/conf.c
@@ -1224,7 +1224,7 @@ dns6:
  *
  * Return: 0 on success, negative error code on failure
  */
-static int conf_runas(char *opt, unsigned int *uid, unsigned int *gid)
+static int conf_runas(const char *opt, unsigned int *uid, unsigned int *gid)
 {
 	const char *uopt, *gopt = NULL;
 	char *sep = strchr(opt, ':');
diff --git a/dhcpv6.c b/dhcpv6.c
index d94be23a..97c04e2c 100644
--- a/dhcpv6.c
+++ b/dhcpv6.c
@@ -320,7 +320,7 @@ static bool dhcpv6_opt(struct iov_tail *data, uint16_t type)
 static bool dhcpv6_ia_notonlink(struct iov_tail *data,
 				struct in6_addr *la)
 {
-	int ia_types[2] = { OPT_IA_NA, OPT_IA_TA }, *ia_type;
+	int ia_types[2] = { OPT_IA_NA, OPT_IA_TA };
 	struct opt_ia_addr opt_addr_storage;
 	const struct opt_ia_addr *opt_addr;
 	struct iov_tail current, ia_base;
@@ -330,6 +330,7 @@ static bool dhcpv6_ia_notonlink(struct iov_tail *data,
 	struct in6_addr req_addr;
 	struct opt_hdr h_storage;
 	const struct opt_hdr *h;
+	const int *ia_type;
 
 	foreach(ia_type, ia_types) {
 		current = *data;
diff --git a/vhost_user.c b/vhost_user.c
index 1e320bff..9fe12411 100644
--- a/vhost_user.c
+++ b/vhost_user.c
@@ -442,7 +442,7 @@ static bool vu_set_mem_table_exec(struct vu_dev *vdev,
 	for (i = 0; i < vdev->memory.nregions; i++) {
 		struct vhost_user_memory_region *msg_region = &memory->regions[i];
 		struct vu_dev_region *dev_region = &vdev->memory.regions[i];
-		void *mmap_addr;
+		const void *mmap_addr;
 
 		debug("vhost-user region %d", i);
 		debug("    guest_phys_addr: 0x%016"PRIx64,
-- 
2.52.0


  reply	other threads:[~2026-01-13  3:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  3:54 [PATCH 0/3] cppcheck-2.19.1 fixes David Gibson
2026-01-13  3:54 ` David Gibson [this message]
2026-01-13  3:54 ` [PATCH 2/3] epoll_ctl: Move u64 variant first for safer initialisation David Gibson
2026-01-13  3:54 ` [PATCH 3/3] igmp: Remove apparently unneeded suppression David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113035415.685242-2-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).