From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 2/3] epoll_ctl: Move u64 variant first for safer initialisation
Date: Tue, 13 Jan 2026 14:54:14 +1100 [thread overview]
Message-ID: <20260113035415.685242-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260113035415.685242-1-david@gibson.dropbear.id.au>
cppcheck-2.19.1 pointed out that an initialiser like:
union epoll_ref foo = { 0 };
doesn't necessarily zero the whole union, because the first variant listed
may not be the full length. I don't think this is actually broken in
practice, but I'm not 100% certain about that.
In any case, make it more clearly correct, and stop cppcheck complaining
by moving the @u64 variant to be the first one.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
epoll_ctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/epoll_ctl.h b/epoll_ctl.h
index 3f802e76..2c103cde 100644
--- a/epoll_ctl.h
+++ b/epoll_ctl.h
@@ -17,6 +17,7 @@
/**
* union epoll_ref - Breakdown of reference for epoll fd bookkeeping
+ * @u64: Opaque reference for epoll_ctl() and epoll_wait()
* @type: Type of fd (tells us what to do with events)
* @fd: File descriptor number (implies < 2^24 total descriptors)
* @flow: Index of the flow this fd is linked to
@@ -25,9 +26,9 @@
* @data: Data handled by protocol handlers
* @nsdir_fd: netns dirfd for fallback timer checking if namespace is gone
* @queue: vhost-user queue index for this fd
- * @u64: Opaque reference for epoll_ctl() and epoll_wait()
*/
union epoll_ref {
+ uint64_t u64;
struct {
enum epoll_type type:8;
int32_t fd:FD_REF_BITS;
@@ -40,7 +41,6 @@ union epoll_ref {
int queue;
};
};
- uint64_t u64;
};
static_assert(sizeof(union epoll_ref) <= sizeof(union epoll_data),
"epoll_ref must have same size as epoll_data");
--
2.52.0
next prev parent reply other threads:[~2026-01-13 3:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 3:54 [PATCH 0/3] cppcheck-2.19.1 fixes David Gibson
2026-01-13 3:54 ` [PATCH 1/3] treewide: Fix more pointers which can be const David Gibson
2026-01-13 3:54 ` David Gibson [this message]
2026-01-13 3:54 ` [PATCH 3/3] igmp: Remove apparently unneeded suppression David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113035415.685242-3-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).