public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 3/3] igmp: Remove apparently unneeded suppression
Date: Tue, 13 Jan 2026 14:54:15 +1100	[thread overview]
Message-ID: <20260113035415.685242-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20260113035415.685242-1-david@gibson.dropbear.id.au>

cppcheck-2.19.1 complains that the unusedFunction suppression in igmp.c
doesn't match.  That seems like a cppcheck bug, because the function
clearly *is* unused.  The function exists because otherwise the compiler
fails because "ISO C forbids an empty translation unit".

mld.c contains an identical unused definition for the same reason, but
without the suppression.  It doesn't seem to have caused unusedFunction
warnings,  so maybe cppcheck counts the non-empty translation unit
requirement as a "use" of the function?

In any case, since omitting the suppression in mld.c seems to be fine, do
the same in igmp.c to stop the complaints.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 igmp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/igmp.c b/igmp.c
index 0e775843..a3971fc6 100644
--- a/igmp.c
+++ b/igmp.c
@@ -13,5 +13,4 @@
  */
 
 /* TO BE IMPLEMENTED */
-/* cppcheck-suppress unusedFunction */
 __attribute__((__unused__)) static void unused(void) { }
-- 
2.52.0


      parent reply	other threads:[~2026-01-13  3:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  3:54 [PATCH 0/3] cppcheck-2.19.1 fixes David Gibson
2026-01-13  3:54 ` [PATCH 1/3] treewide: Fix more pointers which can be const David Gibson
2026-01-13  3:54 ` [PATCH 2/3] epoll_ctl: Move u64 variant first for safer initialisation David Gibson
2026-01-13  3:54 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113035415.685242-4-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).