From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=CcmbLRhX; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 3D21C5A0625 for ; Tue, 13 Jan 2026 04:54:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1768276457; bh=gD37/uRIqlZjQNMUTuzR88IL6tZoeIG/1WwSHIthTMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CcmbLRhXC3QCjpWDSdzFajF3L0jZc7ItifR10v5dk/mznI9EbZQ2rp8k583aTirHa OJ7Ic7LwEzdNSnjoJeyhoOgr9BXNbA6YtZwHvLA2mzgkge7drSVZW4i0uMXYQXoqHR FUFRCWsuBbxj91DIo1MdrLYrmclvIq6fu5WyN62OQaYPmSXIB9TIoiS/hZr4z4Wv3g xoHvDwS/tQHkLHmgNlSdbZ/CDItWtcZkLDLhPKj0UxqZJAVDc5oRvANxQk1nCVmcLo p/mOT5lmGKJBtI2en/ODQuA0WSDimGbIbaZCVOXEfr2AyIvDEp0QnV3kkhpYzs10dK bcmGdIOspcadA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4dqwNT6hP4z4wRG; Tue, 13 Jan 2026 14:54:17 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 3/3] igmp: Remove apparently unneeded suppression Date: Tue, 13 Jan 2026 14:54:15 +1100 Message-ID: <20260113035415.685242-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113035415.685242-1-david@gibson.dropbear.id.au> References: <20260113035415.685242-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: CKGNLCAQ6SQY427KSCSATIGBJSX66LTX X-Message-ID-Hash: CKGNLCAQ6SQY427KSCSATIGBJSX66LTX X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: cppcheck-2.19.1 complains that the unusedFunction suppression in igmp.c doesn't match. That seems like a cppcheck bug, because the function clearly *is* unused. The function exists because otherwise the compiler fails because "ISO C forbids an empty translation unit". mld.c contains an identical unused definition for the same reason, but without the suppression. It doesn't seem to have caused unusedFunction warnings, so maybe cppcheck counts the non-empty translation unit requirement as a "use" of the function? In any case, since omitting the suppression in mld.c seems to be fine, do the same in igmp.c to stop the complaints. Signed-off-by: David Gibson --- igmp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/igmp.c b/igmp.c index 0e775843..a3971fc6 100644 --- a/igmp.c +++ b/igmp.c @@ -13,5 +13,4 @@ */ /* TO BE IMPLEMENTED */ -/* cppcheck-suppress unusedFunction */ __attribute__((__unused__)) static void unused(void) { } -- 2.52.0