From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WyDv9aAS; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 49AC85A0623 for ; Tue, 13 Jan 2026 23:13:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768342411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+dRea3ZHcwxJtGbL1oslK+Bl69rU6d17Zg1Fmoczs5A=; b=WyDv9aASAsOj8ifV9ZYjuHe4OHvYFR1rlMiIPOhoFi5DFYyVTqlWxnBgk2HwoeEwk84BNJ yek6TSlPHgV+BIvESRSYXtzL02wtxu/xeg//Wtg6woYgwZIG+XcenU9v2Go2iHgqz6IF1w FcjQgqHAuV9Ayu+QLULkORlxyLQuR1w= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-a0PyTEEjPYycXoWBnVZUNA-1; Tue, 13 Jan 2026 17:13:29 -0500 X-MC-Unique: a0PyTEEjPYycXoWBnVZUNA-1 X-Mimecast-MFC-AGG-ID: a0PyTEEjPYycXoWBnVZUNA_1768342409 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso61947525e9.2 for ; Tue, 13 Jan 2026 14:13:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768342408; x=1768947208; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+dRea3ZHcwxJtGbL1oslK+Bl69rU6d17Zg1Fmoczs5A=; b=C8dcQpTfQI6n2pulGJQ32FUWRX2u7rxl8IjGWvCCTXV3T4fZPOlLMv/krDYOSg+nWe NIlWgkoMZA4BqMZBKPOCz9ttrQzsCpv3FTAw17tpI0+UBx3hxw2i+BH3yBbCABSi8Rrh z6xjuYrsKApJqVDRi+SqHUMVLhsS4KCOr9bhMA36BL576brjiGCeOXyzCOo891C2V6eK 325OyIeuNhv78a+sGy5P3WNPcjGsXTNC5tHHNFeu8+Vs6kS0qlnnlbgfDeiLvjSx4tLH r+tQUsx+AY/cyQsTHoFO5fihZ80F9w/tIhASBA4a7GcKT5irVqqE3oYHVSk5sd4DELsj eBQw== X-Gm-Message-State: AOJu0YxfjEa19NG2mMsJH7GEyt6uI8Mnd0nwQf0mSWF/OcSES8HVNwIk iWxlcSF4DTUi48GGTNRamACtsxQEsUg1OPRbGiXOcZ35jmbrFb0pGlPo6NEsE9e1CXGdhrfdkrT Mq81Dcvv84Pi/gbqriZWESp7tAl60a44/c9v4L7fbTaXUNn90fTvK8EumQrqjWA== X-Gm-Gg: AY/fxX6rDaxraKqA4jQmMPcnQyM7MMKAjBvsfgBm4AHlMkxNIriNNFcqgeSjwNhsncQ g1SKZo0x1m2QcoA8JWXyZ11El9EVrkR4dl+rT3NLb/jwIipS64R40HKOQQ5ma7CSEbLH1qf1zGI gAVIE2UQFrIAlzBJ6y0eckiiDT0DhtcfL9FBMs2IshTcRO7cl7mgOPCgclh4/ZeG/wuCCMCcY4d N+sMKNxYD5MGqn6nk6/uadi2Rn+G2jBH/7Sm9YDbfSqj4fDjdNAPrdH2gTHzSBS9W9PMS0StLq9 gpcP9ZLEzuoalWHV9q5y8pQ3L4fsc97ENBzj4Yix0QhZ2XRPWd9zcy2wwu9vhdhqk68/iAHLdh0 Yelzg1giHWQsTvytoNXoE X-Received: by 2002:a05:600c:1383:b0:477:a9e:859a with SMTP id 5b1f17b1804b1-47ee3353f47mr7596035e9.22.1768342408282; Tue, 13 Jan 2026 14:13:28 -0800 (PST) X-Received: by 2002:a05:600c:1383:b0:477:a9e:859a with SMTP id 5b1f17b1804b1-47ee3353f47mr7595855e9.22.1768342407904; Tue, 13 Jan 2026 14:13:27 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f68f4ddsm438154885e9.2.2026.01.13.14.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 14:13:27 -0800 (PST) Date: Tue, 13 Jan 2026 23:13:26 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 02/14] conf, fwd: Keep a table of our port forwarding configuration Message-ID: <20260113231326.6bc2ecf2@elisabeth> In-Reply-To: References: <20260108022948.2657573-1-david@gibson.dropbear.id.au> <20260108022948.2657573-3-david@gibson.dropbear.id.au> <20260113002610.5168fd6a@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AIV2WKMK9zEZjLG7gFT6riQoPMtMPGFhmoReww-biq8_1768342409 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PXROTJV6Y5PMHL36ABSYWCXB67YXZE4E X-Message-ID-Hash: PXROTJV6Y5PMHL36ABSYWCXB67YXZE4E X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 13 Jan 2026 16:12:02 +1100 David Gibson wrote: > On Tue, Jan 13, 2026 at 12:26:10AM +0100, Stefano Brivio wrote: > > > > On Thu, 8 Jan 2026 13:29:36 +1100 > > David Gibson wrote: > > > > > +/** > > > + * fwd_rules_print() - Print forwarding rules for debugging > > > + * @fwd: Table to print > > > + */ > > > +void fwd_rules_print(const struct fwd_ports *fwd) > > > +{ > > > + unsigned i; > > > + > > > + for (i = 0; i < fwd->count; i++) { > > > + const struct fwd_rule *rule = &fwd->rules[i]; > > > + const char *weak = rule->flags & FWD_WEAK ? " WEAK" : ""; > > > > Should we print " might fail" or " can fail" instead of " WEAK"? This > > is for users. > > Good point. THough I'm not sure "might fail" or "can fail" is > terribly clear in context either. I've gone with " (best effort)" for > now. Or maybe " (if available)"? I always find "best effort" a bit ambiguous because, well, it's a pretty good effort, being it's the best one, but it actually means we'll just give it a quick try, once. No strong preference though, "best effort" is rather idiomatic anyway. -- Stefano