From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LynsX7MH; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 9A5595A004E for ; Tue, 13 Jan 2026 23:13:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768342416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rZw0HtYkchQzlciEQBh7/tJdgW7DgeqVTZVoRi40tUY=; b=LynsX7MH6GwxZEgsQhTZnW19+ITvmfZ+THeBXpJBKxbTAKt9LJQAVloxXK4qn/UeaqPhoP if86v47P/0t3po3IYy5OoNkkJzODmF7OCtBuFn7pPDln9RXOdPivIsSOnQB0LOvf9Q7LzW b6hoHuCI8iUUV2Y/JnAHZGke8BKXqW0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-fHbNSeV3MW2hA3-lLS26mg-1; Tue, 13 Jan 2026 17:13:35 -0500 X-MC-Unique: fHbNSeV3MW2hA3-lLS26mg-1 X-Mimecast-MFC-AGG-ID: fHbNSeV3MW2hA3-lLS26mg_1768342414 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47edee0b11cso4727875e9.1 for ; Tue, 13 Jan 2026 14:13:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768342414; x=1768947214; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rZw0HtYkchQzlciEQBh7/tJdgW7DgeqVTZVoRi40tUY=; b=TkPLj7eCAvwAmt9IXNL5vEcFc55chrjoT8WeYU7VkJSwGF9uXXDSH7CKTRMIijPnqQ t/JkyWaNVd91XiKIYAVUa5NOzlKWvH5HCKqzjF7lo0bJ3A995ZrQism7RjsasycBlD6V JewCpKgphQMwBjowwrvM7vc1FDAzNgbhp5F913WNEzLS77wOLg+B67hucAkv4n2IKMoJ N8a1jJfiG6Qhhg2/FS7KzER4VPU6dYhfSyyFgm/qFbVte432yxGY7tr18AXoENim4Dvd u1CuY5gbM3oeidRvlHnrVMe6vIzwty9lr1d6iMaEudIvkAQEqOQRG6AJ+KL+qBStDZcM Hu3A== X-Gm-Message-State: AOJu0YzdgNwn20G0BRoq+xja5OxqcKJjly0u1b97nGwPMZBfdMIVnm2G v+q5QdZNXCB9cOUVCfEHEvFcZh4kHL76uD21QeuoZaWcFs0n25GJC0cgQ1ofZOn5fJkYzHyFxaZ CepGSTMMj1PdpeaHAUGjiCna0O8dpsFGFFsXMh/m2Vofs0Og/ilSivLO2G27ZbA== X-Gm-Gg: AY/fxX6B5ZSbhUaqNJlwB7crOLMc0C7T6xy5p/TQNySEvixSsTnYcK8RuxRUVv4k0Ff Rwr+wLBCxVE1jKsfBHKs+ktdseU1NJsE7YaRjzdP11cC4aDSAMGyogF9Bdeph/o2z8dChVSHuuI BiI6pPA05cywJ3JVcFtGH24w2+kJV8eR4jRD7VqNehCB1JFOBUeA/W6MJZH6OzzMab94cHqt17w iLoM2Yc0bkRGSQF0Wled4l3eSoA/Mq3hkEnJeHpKnEOxVautRyFQ7Ibnqm+K/Uq60i/kZ3chqnh JtHDesEUQE0l5QDSgZdSklKkb3yDAfNOChJxcEGdiHfTBj9PssXXFrrxY5UWA7EjSg1s65WGi7I kQWRwuwp+1GLI7YgihydR X-Received: by 2002:a05:600c:45ce:b0:477:8b2e:aa7d with SMTP id 5b1f17b1804b1-47ee33a322bmr6488695e9.30.1768342413668; Tue, 13 Jan 2026 14:13:33 -0800 (PST) X-Received: by 2002:a05:600c:45ce:b0:477:8b2e:aa7d with SMTP id 5b1f17b1804b1-47ee33a322bmr6488615e9.30.1768342413246; Tue, 13 Jan 2026 14:13:33 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ec5d95edbsm213174895e9.3.2026.01.13.14.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 14:13:32 -0800 (PST) Date: Tue, 13 Jan 2026 23:13:31 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 05/14] fwd: Make space to store listening sockets in forward table Message-ID: <20260113231331.086bd504@elisabeth> In-Reply-To: References: <20260108022948.2657573-1-david@gibson.dropbear.id.au> <20260108022948.2657573-6-david@gibson.dropbear.id.au> <20260113002622.48f32d54@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZoqpWb0Yij94-O4aka_k29atVsnzpk01vwwiUb9IqXU_1768342414 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: B47IDB2ODXZ6ZRWLBZ4YIK4V56UTP4UM X-Message-ID-Hash: B47IDB2ODXZ6ZRWLBZ4YIK4V56UTP4UM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 13 Jan 2026 16:28:27 +1100 David Gibson wrote: > On Tue, Jan 13, 2026 at 12:26:22AM +0100, Stefano Brivio wrote: > > On Thu, 8 Jan 2026 13:29:39 +1100 > > David Gibson wrote: > > > > > @@ -74,6 +83,8 @@ enum fwd_ports_mode { > > > * @rules: Array of forwarding rules > > > * @map: Bitmap describing which ports are forwarded > > > * @delta: Offset between the original destination and mapped port number > > > + * @listen_sock_count: Number of entries used in @listen_socks > > > + * @listen_socks: Listening sockets for forwarding > > > > To keep those aligned: > > > > /** > > * fwd_ports() - Describes port forwarding for one protocol and direction > > * @mode: Overall forwarding mode (all, none, auto, some ports) > > * @scan4: /proc/net fd to scan for IPv4 ports when in AUTO mode > > * @scan6: /proc/net fd to scan for IPv6 ports when in AUTO mode > > * @count: Number of forwarding rules > > * @rules: Array of forwarding rules > > * @map: Bitmap describing which ports are forwarded > > * @delta: Offset between original and mapped destination port > > * @listen_sock_count: Number of entries used in @listen_socks > > * @listen_socks: Listening sockets for forwarding > > */ > > Done. I'd also be very open to more succinct names for these fields, > but they haven't occurred to me yet. @sockets: Array of listening sockets for inbound port forwarding @sockets_count: Count of used @sockets ? I mean, they're obviously listening sockets. -- Stefano