From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Yf9Shl52; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id DE0E45A0625 for ; Wed, 14 Jan 2026 00:34:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768347286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUPD9XB+g2WDXcmFX1np4Ze4u8OpzmxiTwTnrWl6qvw=; b=Yf9Shl52wBBzL+pN7penxZK/RAQ7kBkP6C3O2m9LAxdl85kT6sA9wjMdhE8X2JUVk1h5W8 JSLUcRt8aMFqFQkqYMeINMfGyZAo3HZSZw1da8StUdjpfbzR2iupfSNf0Q3oxYTDsIOr4X jNFho9pp8v1xYryskqsEjx2/84lWyEM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-xUSMbmatO7Cf4hXWYHGCFg-1; Tue, 13 Jan 2026 18:34:45 -0500 X-MC-Unique: xUSMbmatO7Cf4hXWYHGCFg-1 X-Mimecast-MFC-AGG-ID: xUSMbmatO7Cf4hXWYHGCFg_1768347284 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-432488a0ce8so6047157f8f.2 for ; Tue, 13 Jan 2026 15:34:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768347284; x=1768952084; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ce1AyknbF+6yuoFRF5Ybgn6AhODwrpQwmK7v/FXsZ+U=; b=BJO33CuhCM3tOOJtFKFL4MofMjgYT4rvaYYicsz3r7dnnTenBqZVLy5ihMP28kOvX2 opAsIW9Ju9Hahol5HF9L0Nex8NPhzoKkPt2bv1pBvKHwe5s85Y6ORCJ3PRTAWdp4Ac2U /GjiZYu8PuMp2zeWdUQJa6CmS4bl6mhpwygxAWyg6IdTBHwQHq6gksegN1Vv+7IXHCG1 mC9UWTcrisckuatb8E2j4ynOAr6JmqL/9lszItEeToD9eT9P7vywsvM3a2xMAukqHnZ/ 40/DpRdNm8Ng6vnQMQ79tMO7bKVcGZmVWCIOt2ngv00ZOqqVrcfhVbq+MnXxdQnpUFY6 mI7g== X-Gm-Message-State: AOJu0YwJ6fv7E+3S2Y57SzOQ24VBXviMOdIjkeMBOo5wGl/cxpQ0Ujdb JoY2ral08nSRCllEar2GQ5wc3yN19xdToicsllWrkRlDY1GaD8s+7viHh5qBhQcogXONdFE5syX a8Doaq7Uta27FpZDzt4v0qE2sPOwE/FC5iZdDU/iYsiVdaP01tdf38q+Nb+Vn8Q== X-Gm-Gg: AY/fxX5Ap41VrYSnGUcLcyxjIrX84eQbPlVM3bXi0I3welpgT8BA8sGKIdss+2iwen6 39GJanIY6PsmwFtovKQPkiwnotG2nACdHU0IriRLdC7wQR8zWssm0bVGcrucTAi93dRHDYJU3CS MGeoSltZBfoS8Vn01z+BW5NWqWZZdPrGSTU66N7/w5QXPeBopVtHN3LSPrJWDDTq7WxEma2sKtD OEmtJ9JbxcLWlHtR8+T+FlGEObslMUGF71D4cVl2XB8bqgLuEXzIDDkC4daz6yxXmvDD5gE2Rwh lqU0relc3E4YLLqMNnwTis5C1jjPUqcUdZekOZW5iu0E2S6cfBfoOPL6UaoTK08JMZOoFr3supv 6zTsQv+D1yXKYafeCP4TF X-Received: by 2002:a05:6000:1ace:b0:432:dc23:368 with SMTP id ffacd0b85a97d-4342c553668mr521957f8f.49.1768347283901; Tue, 13 Jan 2026 15:34:43 -0800 (PST) X-Received: by 2002:a05:6000:1ace:b0:432:dc23:368 with SMTP id ffacd0b85a97d-4342c553668mr521943f8f.49.1768347283374; Tue, 13 Jan 2026 15:34:43 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dacc5sm46612400f8f.5.2026.01.13.15.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 15:34:42 -0800 (PST) Date: Wed, 14 Jan 2026 00:34:41 +0100 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH] conf, pasta: Add --no-tap option Message-ID: <20260114003441.044df424@elisabeth> In-Reply-To: References: <20251229095558.918055-1-yuhuang@redhat.com> <20260110191226.570a3f0b@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dytBeZHPr-QCzE8IF9967HLEueHR0DC5HAJf7IAywBY_1768347284 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3UO5PKU2MWDUOPYLO4JJTGRODE5Z4G5C X-Message-ID-Hash: 3UO5PKU2MWDUOPYLO4JJTGRODE5Z4G5C X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 13 Jan 2026 19:20:47 +0800 Yumei Huang wrote: > On Sun, Jan 11, 2026 at 2:12=E2=80=AFAM Stefano Brivio wrote: > > > > On Mon, 29 Dec 2025 17:55:58 +0800 > > Yumei Huang wrote: > > =20 > > > This patch introduces a mode where we only forward loopback connectio= ns > > > and traffic between two namespaces (via the loopback interface, 'lo')= , > > > without a tap device. > > > > > > With this, podman can support forwarding ::1 in custom networks when = using > > > rootlesskit for forwarding ports. > > > > > > In --no-tap mode, --host-lo-to-ns-lo, --no-icmp and --no-ra is automa= tically > > > enabled. Options requiring a tap device (--ns-ifname, --ns-mac-addr, > > > --config-net, --outbound-if4/6) are rejected. > > > > > > Link: https://bugs.passt.top/show_bug.cgi?id=3D149 > > > Signed-off-by: Yumei Huang > > > --- > > > conf.c | 56 +++++++++++++++++++++++++++++++++++++++++--------------= - > > > fwd.c | 3 +++ > > > passt.1 | 5 +++++ > > > passt.h | 2 ++ > > > pasta.c | 3 +++ > > > tap.c | 11 +++++++---- > > > 6 files changed, 61 insertions(+), 19 deletions(-) > > > > > > diff --git a/conf.c b/conf.c > > > index 84ae12b..353d0a5 100644 > > > --- a/conf.c > > > +++ b/conf.c > > > @@ -1049,7 +1049,8 @@ pasta_opts: > > > " --no-copy-addrs DEPRECATED:\n" > > > " Don't copy all addresses to nam= espace\n" > > > " --ns-mac-addr ADDR Set MAC address on tap interfac= e\n" > > > - " --no-splice Disable inbound socket splicing= \n"); > > > + " --no-splice Disable inbound socket splicing= \n" > > > + " --no-tap Don't create tap device\n"); > > > > > > passt_exit(status); > > > } > > > @@ -1451,6 +1452,7 @@ void conf(struct ctx *c, int argc, char **argv) > > > {"no-ndp", no_argument, &c->no_ndp, = 1 }, > > > {"no-ra", no_argument, &c->no_ra, = 1 }, > > > {"no-splice", no_argument, &c->no_splice, = 1 }, > > > + {"no-tap", no_argument, &c->no_tap, = 1 }, > > > {"freebind", no_argument, &c->freebind, = 1 }, > > > {"no-map-gw", no_argument, &no_map_gw, = 1 }, > > > {"ipv4-only", no_argument, NULL, = '4' }, > > > @@ -1947,8 +1949,11 @@ void conf(struct ctx *c, int argc, char **argv= ) > > > } > > > } while (name !=3D -1); > > > > > > - if (c->mode !=3D MODE_PASTA) > > > + if (c->mode !=3D MODE_PASTA) { > > > c->no_splice =3D 1; > > > + if (c->no_tap) > > > + die("--no-tap is for pasta mode only"); > > > + } > > > > > > if (c->mode =3D=3D MODE_PASTA && !c->pasta_conf_ns) { > > > if (copy_routes_opt) > > > @@ -1957,6 +1962,25 @@ void conf(struct ctx *c, int argc, char **argv= ) > > > die("--no-copy-addrs needs --config-net"); > > > } > > > > > > + if (c->mode =3D=3D MODE_PASTA && c->no_tap) { > > > + if (c->no_splice) > > > + die("--no-tap is incompatible with --no-splice"= ); =20 > > > > I'm not sure if you need this for other reasons, but as long as it's > > called --no-tap, it's not really incompatible with --no-splice. =20 >=20 > I will update it to --splice-only >=20 > > > > Maybe users just want to get a disconnected namespace for whatever > > reason ('pasta' is shorter to type than 'unshare -rUn'). > > =20 > > > + if (*c->ip4.ifname_out || *c->ip6.ifname_out) > > > + die("--no-tap is incompatible with --outbound-i= f4/6"); > > > + if (*c->pasta_ifn) > > > + die("--no-tap is incompatible with --ns-ifname"= ); > > > + if (*c->guest_mac) > > > + die("--no-tap is incompatible with --ns-mac-add= r"); > > > + if (c->pasta_conf_ns) > > > + die("--no-tap is incompatible with --config-net= "); =20 > > > > I guess all these checks are to save some checks later, which looks lik= e > > a good reason to have them here. > > > > If not, though, I don't think we *really* need to tell the user that > > --ns-ifname will be ignored with --no-tap. > > > > One thing that might confuse users, though, is this: > > > > $ ./pasta --no-tap --mtu 1500 -- ip l > > 1: lo: mtu 65536 qdisc noqueue state UNKNOWN mod= e DEFAULT group default qlen 1000 > > link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 > > > > or even this: > > > > $ ./pasta --no-tap -a 192.0.2.1 -- ip a > > 1: lo: mtu 65536 qdisc noqueue state UNKNOWN gro= up default qlen 1000 > > link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 > > inet 127.0.0.1/8 scope host lo > > valid_lft forever preferred_lft forever > > inet6 ::1/128 scope host proto kernel_lo > > valid_lft forever preferred_lft forever > > > > but I would rather *not* add conditions and checks for those even if > > there's a *slight* potential for confusion, otherwise this becomes > > really long. And it's really not worth it, I think. =20 >=20 > Then I guess we only need the c->no_splice check, right? ...maybe? About *needing*, yes, I guess so, but if other checks save more checks later, I would keep them. > > > + > > > + c->host_lo_to_ns_lo =3D 1; > > > + c->no_icmp =3D 1; > > > + c->no_ra =3D 1; > > > + c->no_dns =3D 1; > > > + c->no_dns_search =3D 1; > > > + } > > > + > > > if (!ifi4 && *c->ip4.ifname_out) > > > ifi4 =3D if_nametoindex(c->ip4.ifname_out); > > > > > > @@ -1980,9 +2004,9 @@ void conf(struct ctx *c, int argc, char **argv) > > > log_conf_parsed =3D true; /* Stop printing everything *= / > > > > > > nl_sock_init(c, false); > > > - if (!v6_only) > > > + if (!v6_only && !c->no_tap) > > > c->ifi4 =3D conf_ip4(ifi4, &c->ip4); > > > - if (!v4_only) > > > + if (!v4_only && !c->no_tap) > > > c->ifi6 =3D conf_ip6(ifi6, &c->ip6); > > > > > > if (c->ifi4 && c->mtu < IPV4_MIN_MTU) { > > > @@ -1998,30 +2022,32 @@ void conf(struct ctx *c, int argc, char **arg= v) > > > (*c->ip6.ifname_out && !c->ifi6)) > > > die("External interface not usable"); > > > > > > - if (!c->ifi4 && !c->ifi6 && !*c->pasta_ifn) { > > > + if (!c->ifi4 && !c->ifi6 && !*c->pasta_ifn && !c->no_tap) { =20 > > > > You already checked that !*c->pasta_ifn above. =20 >=20 > I guess the check above (aka. if (*c->pasta_ifn && c->no_tap)) doesn't > affect this one? If c->pasta_ifn is assigned, we won't come to the > check !c->no_tap here. Otherwise, we do need to check !c->no_tap. Right, but you don't care about resetting c->pasta_ifn to the default value if !c->no_tap, because in that case you know that c->pasta_ifn wasn't set, so you can happily override it. I guess, at least, I haven't thoroughly checked what might happen later with it. > > =20 > > > strncpy(c->pasta_ifn, pasta_default_ifn, > > > sizeof(c->pasta_ifn) - 1); > > > } > > > > > > if (!c->ifi4 && !v6_only) { > > > - info("IPv4: no external interface as template, use loca= l mode"); > > > - > > > - conf_ip4_local(&c->ip4); > > > + if (!c->no_tap) { > > > + info("IPv4: no external interface as template, = use local mode"); > > > + conf_ip4_local(&c->ip4); > > > + } > > > c->ifi4 =3D -1; > > > } > > > > > > if (!c->ifi6 && !v4_only) { > > > - info("IPv6: no external interface as template, use loca= l mode"); > > > - > > > - conf_ip6_local(&c->ip6); > > > + if (!c->no_tap) { > > > + info("IPv6: no external interface as template, = use local mode"); > > > + conf_ip6_local(&c->ip6); > > > + } > > > c->ifi6 =3D -1; > > > } > > > > > > - if (c->ifi4 && !no_map_gw && > > > + if (c->ifi4 > 0 && !no_map_gw && > > > IN4_IS_ADDR_UNSPECIFIED(&c->ip4.map_host_loopback)) > > > c->ip4.map_host_loopback =3D c->ip4.guest_gw; > > > > > > - if (c->ifi6 && !no_map_gw && > > > + if (c->ifi6 > 0 && !no_map_gw && > > > IN6_IS_ADDR_UNSPECIFIED(&c->ip6.map_host_loopback)) > > > c->ip6.map_host_loopback =3D c->ip6.guest_gw; > > > > > > @@ -2116,10 +2142,10 @@ void conf(struct ctx *c, int argc, char **arg= v) > > > conf_ports(c, name, optarg, &c->udp.fwd_out); > > > } while (name !=3D -1); > > > > > > - if (!c->ifi4) > > > + if (c->ifi4 <=3D 0) > > > c->no_dhcp =3D 1; > > > > > > - if (!c->ifi6) { > > > + if (c->ifi6 <=3D 0) { > > > c->no_ndp =3D 1; > > > c->no_dhcpv6 =3D 1; > > > } else if (IN6_IS_ADDR_UNSPECIFIED(&c->ip6.addr)) { > > > diff --git a/fwd.c b/fwd.c > > > index 44a0e10..2f4a89a 100644 > > > --- a/fwd.c > > > +++ b/fwd.c > > > @@ -780,6 +780,9 @@ uint8_t fwd_nat_from_host(const struct ctx *c, ui= nt8_t proto, > > > return PIF_SPLICE; > > > } > > > > > > + if (c->no_tap) > > > + return PIF_NONE; > > > + > > > if (!nat_inbound(c, &ini->eaddr, &tgt->oaddr)) { > > > if (inany_v4(&ini->eaddr)) { > > > if (IN4_IS_ADDR_UNSPECIFIED(&c->ip4.our_tap_add= r)) > > > diff --git a/passt.1 b/passt.1 > > > index db0d662..2d643f7 100644 > > > --- a/passt.1 > > > +++ b/passt.1 > > > @@ -755,6 +755,11 @@ Default is to let the tap driver build a pseudor= andom hardware address. > > > Disable the bypass path for inbound, local traffic. See the section = \fBHandling > > > of local traffic in pasta\fR in the \fBNOTES\fR for more details. > > > > > > +.TP > > > +.BR \-\-no-tap > > > +Do not create a tap device in the namespace. In this mode, only loca= l loopback > > > +traffic between namespaces is forwarded using splice. =20 > > > > "Using splice" isn't really clear, and it's not entirely correct in the > > case of UDP: there's no splice() system call there, even if we call > > some UDP flows "spliced" for analogy with TCP. > > > > Maybe just omit it, say: > > > > [...] In this mode, \fIpasta\fR only > > forwards loopback traffic between namespaces. =20 >=20 > Do you think we still need "Do not create a tap device in the > namespace" after updating it to --splice-only? Yes, I think so, because otherwise it might look like we create the tap device anyway, but discard all traffic from/to it. --=20 Stefano