From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 3/3] igmp: Remove apparently unneeded suppression
Date: Wed, 14 Jan 2026 00:35:03 +0100 [thread overview]
Message-ID: <20260114003503.412fc9d1@elisabeth> (raw)
In-Reply-To: <20260113035415.685242-4-david@gibson.dropbear.id.au>
On Tue, 13 Jan 2026 14:54:15 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> cppcheck-2.19.1 complains that the unusedFunction suppression in igmp.c
> doesn't match. That seems like a cppcheck bug, because the function
> clearly *is* unused. The function exists because otherwise the compiler
> fails because "ISO C forbids an empty translation unit".
>
> mld.c contains an identical unused definition for the same reason, but
> without the suppression. It doesn't seem to have caused unusedFunction
> warnings, so maybe cppcheck counts the non-empty translation unit
> requirement as a "use" of the function?
No idea why, but with this patch and cppcheck 2.16.0 I'm getting:
igmp.c:16:0: style: The function 'unused' is never used. [unusedFunction]
__attribute__((__unused__)) static void unused(void) { }
^
...I guess we needed one and exactly one suppression between mld.c and
igmp.c, even though it's two different translation units.
Anyway, whatever, it's too old to make sense. Upgraded to 2.19.0, no
error there, I guess it should be good enough for everybody.
--
Stefano
next prev parent reply other threads:[~2026-01-13 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 3:54 [PATCH 0/3] cppcheck-2.19.1 fixes David Gibson
2026-01-13 3:54 ` [PATCH 1/3] treewide: Fix more pointers which can be const David Gibson
2026-01-13 3:54 ` [PATCH 2/3] epoll_ctl: Move u64 variant first for safer initialisation David Gibson
2026-01-13 3:54 ` [PATCH 3/3] igmp: Remove apparently unneeded suppression David Gibson
2026-01-13 23:35 ` Stefano Brivio [this message]
2026-01-14 1:11 ` David Gibson
2026-01-14 0:08 ` [PATCH 0/3] cppcheck-2.19.1 fixes Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114003503.412fc9d1@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).