From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=I3EoqUq8; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 26C655A004E for ; Wed, 14 Jan 2026 00:35:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768347308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZICVvMH0vTCSFAWqhqVkv+4CmfHkrSOxPq0pH+gIKo=; b=I3EoqUq8V8bidYqi5CS7tv9+wA7/FADFDK+W5BhysT7LHhrIWZA0MuUYdWddoKEJAVNbBX QzoG8JsFvHkcLmyV4h+JPWMoXOm8PV8T/vouRiaC8NVayaykDe2i/3t3d6K1ZZJZZT9Trk BCHEUfbryRbUbsQUVno2r1CNh67Hqj8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-m01psCmZNSqyvOzmXSqfRg-1; Tue, 13 Jan 2026 18:35:06 -0500 X-MC-Unique: m01psCmZNSqyvOzmXSqfRg-1 X-Mimecast-MFC-AGG-ID: m01psCmZNSqyvOzmXSqfRg_1768347306 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-432586f2c82so170722f8f.0 for ; Tue, 13 Jan 2026 15:35:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768347305; x=1768952105; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1ZICVvMH0vTCSFAWqhqVkv+4CmfHkrSOxPq0pH+gIKo=; b=Z7qVRlwjv0AYH2Y0SC7bwCyzhCHlPiL2lURk7kLlg1mwL1aXnVA9CA1KIbuW68UcUp KZwKdnAgKhsbw8cHGv7cDRR0D8dqPg3DZ194clD2Ze7fSOx6WTz0XkbhRxX7TpPyshvk OmypxUszY5GBPwSF7PyCqm3c+dPAwgo1Vj5DcgUAmr7g5uCnivn7WAaQIkaqtxLsHXlZ LjJGkj8XMP5cO+6TsITDIbnIOo78jh0Zkd5DfwW0kGwSk15KBkbi1bx3w5Hx1+Z5kG7t Uxcw/d5dFeyCf87H0y45B8Sp0/y5Lbv7++lRXOysdYxuzgo/zewmPFV7xzZxb7fALlMB xO1w== X-Gm-Message-State: AOJu0YyVDULtL5vaKT62KU2oAsokwO3CML5pWdM9abj5kirUzMKiskT/ FcIolgweXP+YCx56aOs+7+4UYvGxY9wnVt8rtrw+zQ2kj2mlugULfNy4ppIlT76a7VA+Lcdegxz a8RTw4e49wx2UKrUfmu0qciXZ3Rxteit1AFTs4xQeJUpH5BTwCfq5zg== X-Gm-Gg: AY/fxX4evDn914RkK7ENJfUCxW5by3N+D8iteO6UHUMuVGh4X4QJxvXAGbpzNg4DX2e y3Bp2dhzBlomM8zBgaMM8NS0squ43OypjEZ/LgGIQlJIQqgokDxMqxPgOZ/ydAH1YfPotDSYavt +FgMvFq2W9hlPnblgdHj0ydVFseuVieUOUXkMd4i5dJ4ctbS7s/Le7bHGXb0sa5u3CsM0bPBQEt 1ZtPviCbaxrDqOgiy9iHp1Y3B7tjy08ShWRtkdLgjERb6poYS3DJRs0H6dHONqQJiO1m+jqveM9 RhOHtzlq8GsTzjEaLsSfgOrXdO2xPh1nGtAM/ODH5WR/q59a2yHN8cRUuTOGjHdBefwMmVDE6k4 BRoQO6PvNRrSyta10Xh1b X-Received: by 2002:a5d:5f83:0:b0:430:fbce:4575 with SMTP id ffacd0b85a97d-43423ebb787mr6076940f8f.21.1768347305623; Tue, 13 Jan 2026 15:35:05 -0800 (PST) X-Received: by 2002:a5d:5f83:0:b0:430:fbce:4575 with SMTP id ffacd0b85a97d-43423ebb787mr6076934f8f.21.1768347305152; Tue, 13 Jan 2026 15:35:05 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df90dsm46959727f8f.20.2026.01.13.15.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 15:35:04 -0800 (PST) Date: Wed, 14 Jan 2026 00:35:03 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 3/3] igmp: Remove apparently unneeded suppression Message-ID: <20260114003503.412fc9d1@elisabeth> In-Reply-To: <20260113035415.685242-4-david@gibson.dropbear.id.au> References: <20260113035415.685242-1-david@gibson.dropbear.id.au> <20260113035415.685242-4-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YE2cEPoqG6nQzZbbNU7NJm6sE7n87dEtLgCnnHW9BRk_1768347306 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: B635XYTPIRYQC6UX55DJCQAQEL3XDV5U X-Message-ID-Hash: B635XYTPIRYQC6UX55DJCQAQEL3XDV5U X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 13 Jan 2026 14:54:15 +1100 David Gibson wrote: > cppcheck-2.19.1 complains that the unusedFunction suppression in igmp.c > doesn't match. That seems like a cppcheck bug, because the function > clearly *is* unused. The function exists because otherwise the compiler > fails because "ISO C forbids an empty translation unit". > > mld.c contains an identical unused definition for the same reason, but > without the suppression. It doesn't seem to have caused unusedFunction > warnings, so maybe cppcheck counts the non-empty translation unit > requirement as a "use" of the function? No idea why, but with this patch and cppcheck 2.16.0 I'm getting: igmp.c:16:0: style: The function 'unused' is never used. [unusedFunction] __attribute__((__unused__)) static void unused(void) { } ^ ...I guess we needed one and exactly one suppression between mld.c and igmp.c, even though it's two different translation units. Anyway, whatever, it's too old to make sense. Upgraded to 2.19.0, no error there, I guess it should be good enough for everybody. -- Stefano