public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3 0/6] flow: Introduce flow_epoll_set() to centralize epoll operations
Date: Wed, 14 Jan 2026 01:08:06 +0100	[thread overview]
Message-ID: <20260114010806.52c93742@elisabeth> (raw)
In-Reply-To: <20260109165438.2492285-1-lvivier@redhat.com>

On Fri,  9 Jan 2026 17:54:32 +0100
Laurent Vivier <lvivier@redhat.com> wrote:

> Currently, each protocol handler (TCP, TCP splice, ICMP/ping, UDP) has its
> own code to add or modify file descriptors in epoll.  This leads to
> duplicated boilerplate across icmp.c, tcp.c, tcp_splice.c, and udp_flow.c,
> with each setting up epoll_ref unions and calling epoll_ctl() with
> flow-type-specific details.
> 
> This series introduces flow_epoll_set() in flow.c to handle epoll
> operations for all flow types in a unified way.  The function derives
> the epoll type from the flow type via a mapping array, providing a
> simpler interface where the caller only needs to pass the flow, command,
> events, file descriptor, and side index.
> 
> The API is:
> 
>     int flow_epoll_set(const struct flow_common *f, int command,
>                        uint32_t events, int fd, unsigned int sidei);
> 
> This centralized approach will be essential for queue pair migration in
> the upcoming multithreading work, where flows need to be moved between
> different epoll instances owned by different threads.

Applied.

-- 
Stefano


      parent reply	other threads:[~2026-01-14  0:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 16:54 Laurent Vivier
2026-01-09 16:54 ` [PATCH v3 1/6] tcp: remove timer update in tcp_epoll_ctl() Laurent Vivier
2026-01-09 16:54 ` [PATCH v3 2/6] tcp: cleanup timer creation Laurent Vivier
2026-01-12  4:09   ` David Gibson
2026-01-09 16:54 ` [PATCH v3 3/6] udp_flow: remove unneeded epoll_ref indirection Laurent Vivier
2026-01-09 16:54 ` [PATCH v3 4/6] udp_flow: Assign socket to flow inside udp_flow_sock() Laurent Vivier
2026-01-09 16:54 ` [PATCH v3 5/6] tcp_splice: Refactor tcp_splice_conn_epoll_events() to per-side computation Laurent Vivier
2026-01-09 16:54 ` [PATCH v3 6/6] flow: Introduce flow_epoll_set() to centralize epoll operations Laurent Vivier
2026-01-12  4:16   ` David Gibson
2026-01-14  0:08 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114010806.52c93742@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).