From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SUE3W76A; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id A2D565A004E for ; Wed, 14 Jan 2026 01:08:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768349291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hxIXDTaleBsjXwew6sMA0LnEwvy7Yxupec0ogRhTOw=; b=SUE3W76A8X3iIgPNnO7VvWZ2Ayr9tbJZTBkUOPaJ4dBg7sLBSEekg+ds/Mu8SEcQ41689M U8zPFg9VfiYviV6pxVmrULk//ZvwuRdMQM05oN5PCCbZxPdfH6jPEqlc3CSvrMaR8IAf6j Ou2itcjT6iiYfoqcf9lI381CVE0WlAI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-96P5aTIqN7mGjg77K4M-aQ-1; Tue, 13 Jan 2026 19:08:10 -0500 X-MC-Unique: 96P5aTIqN7mGjg77K4M-aQ-1 X-Mimecast-MFC-AGG-ID: 96P5aTIqN7mGjg77K4M-aQ_1768349289 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-432586f2c82so181802f8f.0 for ; Tue, 13 Jan 2026 16:08:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768349289; x=1768954089; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2hxIXDTaleBsjXwew6sMA0LnEwvy7Yxupec0ogRhTOw=; b=wsUu6jymdHwP+xqd1H7h5y/sNcFzPzYmUCvU3+yhsKpPJOMSc0YOhyTYPr8ar9R0VZ Z+x5gGuVnEzWZLncU6mn7MHaZWgPKrinXZb9NEmj0JilGcgwdCO8Ec6ApZ4vXwg3RNje DPI3uli1rgzqnCrg+MXHZ9nLO6WgAxFHegbsYgTGcIho+7FCKZzbIcu1a/G6iAAidzDR oNdMfILW2mEO5fYW9tPomX9FDG+cf1XCDjyH3vlSQGBks7/+OBEKt0zxTB45plFrMNEz PiFHFWNjZrPqTmIDaIHMk2DQRFlqHY3WxLGYA6cne3oC8W5vVibJ82vzG7KDbIiPvA9f 0feQ== X-Gm-Message-State: AOJu0Yz/FQCnWVaIje/AcE5QNt48HpLM8nV71uhMCO9pKoJteJQV+F58 VWf79/Gb7A7tQ0Vhsv2TbM2E+Z5pubMQnh4fQj0KVspTttJ3gbL1AtwJGYVo82Nh621W3M9x3tB isxyGJRAIaEqxKIx+4ufKOQnrtf0bYrV+hEUBOPoQXRzzTkVgqoAJjg== X-Gm-Gg: AY/fxX7AqeYlqSkWR9Iz2LBu6LbBKTsFj5iHJun3bensmnhHu+ILh4L79SG8NQ7Ndl1 sbJPkzzLgcs9dvPTpEa1ydg4wuDTXfRJ6H1+4WOuhK1syj1YJKv/HgaKJdhoqWWFwYvNbYPlDLZ X3plqcn898mmJwqxbLYMXDehIE95RJ0Cy6+W2aUbBn8mQ49JD8ktfa3D8zgOm4mbpQYs5noagpK ghHkGCDPNPpLLUpxDGOESKJDa16k07NfBtLO5xCgOw9ZJIoYso9TOejrAE3zZw5e/qmvw763Axu Z5Hd8cz713LCdat2NH6Q3Jonjdsqb4tbJfQQaur0PT1V9bkA/1tSbegQuh8HBixQzyAsKol+wxP FA/TKVfg2zVzOiZViv4Y8 X-Received: by 2002:a05:6000:1a8a:b0:430:fdc8:8bd6 with SMTP id ffacd0b85a97d-4342c0ff57cmr923017f8f.31.1768349289029; Tue, 13 Jan 2026 16:08:09 -0800 (PST) X-Received: by 2002:a05:6000:1a8a:b0:430:fdc8:8bd6 with SMTP id ffacd0b85a97d-4342c0ff57cmr923006f8f.31.1768349288578; Tue, 13 Jan 2026 16:08:08 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e17aasm47361835f8f.15.2026.01.13.16.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 16:08:07 -0800 (PST) Date: Wed, 14 Jan 2026 01:08:06 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v3 0/6] flow: Introduce flow_epoll_set() to centralize epoll operations Message-ID: <20260114010806.52c93742@elisabeth> In-Reply-To: <20260109165438.2492285-1-lvivier@redhat.com> References: <20260109165438.2492285-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yumj5xWqlbo95Xt_weQDa80lHpsbYrym5oF58d9EW5M_1768349289 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3DRTYD7KIHZOA6LTVIFBIY2GUJULYUZJ X-Message-ID-Hash: 3DRTYD7KIHZOA6LTVIFBIY2GUJULYUZJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 9 Jan 2026 17:54:32 +0100 Laurent Vivier wrote: > Currently, each protocol handler (TCP, TCP splice, ICMP/ping, UDP) has its > own code to add or modify file descriptors in epoll. This leads to > duplicated boilerplate across icmp.c, tcp.c, tcp_splice.c, and udp_flow.c, > with each setting up epoll_ref unions and calling epoll_ctl() with > flow-type-specific details. > > This series introduces flow_epoll_set() in flow.c to handle epoll > operations for all flow types in a unified way. The function derives > the epoll type from the flow type via a mapping array, providing a > simpler interface where the caller only needs to pass the flow, command, > events, file descriptor, and side index. > > The API is: > > int flow_epoll_set(const struct flow_common *f, int command, > uint32_t events, int fd, unsigned int sidei); > > This centralized approach will be essential for queue pair migration in > the upcoming multithreading work, where flows need to be moved between > different epoll instances owned by different threads. Applied. -- Stefano