Re: [PATCH v5 00/14] Introduce forwarding table

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 16 Jan 2026 11:59:12 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> This creates a new data structure for recording our port forwarding: a
> table of individual forwarding rules.  This is intended to replace the
> existing forwarding mode, map and delta structures.  For now, only the
> delta[] array is removed.  map is still used, but only for automatic
> forwards.  Mode is still used, but only has significance during
> configuration.
> 
> There's still a lot that can be done for flexible forwarding, but this
> introduces the core data structure, and does enough to fix at least
> one concrete defect with the current logic (bug 187).  I think it
> would be a good point to give it a solid review and maybe merge.
> 
> I'm aware that this is a very large complex series, that will be
> difficult to review.  I think that's more or less inevitable
> implementing a feature as broad and complex as "flexible forwarding".
> If it helps at all, I'm fine if it's not reviewed all at once - I
> won't assume review is complete until either you say so, or I get
> comments or R-b on each patch.
> 
> This applies on top of all 3 of my outstanding series in this area:
> "Allow listen functions to return fds", "Clean ups to epoll
> references" (v2) and "Small cleanups to splice forwarding logic".
> 
> Changes in v5:
>  * Fix coverity warning in ifname handling (2/14)
> Changes in v4:
>  * Numerous cosmetic changes
>  * Re-arrange rule hinting to avoid coverity error

Finally applied!

-- 
Stefano