From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ReLlLYjo; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 331995A004E for ; Sun, 18 Jan 2026 14:49:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768744157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YNsc6B++ozvfYATctj2oG2EwVctoUdELqFs/Eej3eXk=; b=ReLlLYjo9sKWcLIRL9v1VDxhKZVy7HxVm7lvj0u+63nt8MYg6bPjLa6zoyGz8+5DlK4F7O ZFmLwhOacCU64LkXKJluUpvNgOy4pYbkFxsLOvVdfwGzFEDKU7YdXnlIRNSXUCeAhbbEUd 5/hhm/SoZTcDOoEROaSVCLgmHk7MQlk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-AedOBdv3NkaZyrkaY7302w-1; Sun, 18 Jan 2026 08:49:15 -0500 X-MC-Unique: AedOBdv3NkaZyrkaY7302w-1 X-Mimecast-MFC-AGG-ID: AedOBdv3NkaZyrkaY7302w_1768744154 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4801d21c280so20064915e9.1 for ; Sun, 18 Jan 2026 05:49:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768744153; x=1769348953; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YNsc6B++ozvfYATctj2oG2EwVctoUdELqFs/Eej3eXk=; b=dSsLpMvf5Fuz9j+CRiVOj684pa9mJweYyZ6ODW46xQITCFTl9ryctjggepyI9Nwrm4 yqzufZPXrm4RNf6/3UMogBDJ8DcCCPQkVwP9ClqbBjuDNj0spJzmIO2Tev67Ql5lUomI B4oZJ9kWmZmWVGww+Web/38fwGySp+fmbBjfRwEWxWRM5Q/KevKmpoeSJBeiYKRmfOvn grtl7tkhCHVGmulhQzOlSozqQ4ywQAriGnEXPJi8CW4zdowS0oVRMCfYFMiYsf3SKSmb QjKDRdyqgnm8a25LV9YPj+d3U61pOvEaIn9+p9Uj4gy3WT/aT+ElumyURoEYm5NTgiqW yaHg== X-Gm-Message-State: AOJu0Yxqpldq7In4VFuSSNNrWZsLstb5zJ7ux88lKgAkk2kbucjqBcWV 7LLt8C/qLsk2ZGJr1sC5A4CmtjEmNPtDkzhvV+cKoruRwYeRkbuXNZ/c0NDVT42PLfhG4+o08DF ctHOCZmxVRgVPvLFFHnpndMoKzn0C31vqDpmOUh6Gzw0wFha8PpzjmunfExiGxg== X-Gm-Gg: AY/fxX5+6qxCNh6ceq5/+cr8Ut7gUag7TqKGy3+AETumoG/wa9JGO7jIJhZfrwkqiAR fWvW9ROP155fhatlR6+sEyNOod7kD+NSiKscdB2D0vkse45KeqrlxdqQKxZVo9phaTfJFIWTnFM mdJAmAbabc2jIHa8WK+s/yIIerfLrCARzghOYMlO9V8P2X5w/sXzGyAvg7/EL1TQ+L9R51z3GeK N+eoWW2WERjaBkWvrN05g5VyY7RCDNulxt1Gdm6e/rPtDvjs4V7kFnPLiQOzfeWea7QKGvieh4o fXJ2OTDW3zbdQQJUVi/ibyizOzsQBYbxebO87D0cVIfQ7tfrv4YEcbuiLolf1UrCWy9oQ+4yVhW y7dl4jpSjM8JJBR1vXCOWEhMwh4rAIvg7iwr/0w== X-Received: by 2002:a05:600c:4fd2:b0:46e:506b:20c5 with SMTP id 5b1f17b1804b1-4801e34c9b4mr113533695e9.26.1768744153542; Sun, 18 Jan 2026 05:49:13 -0800 (PST) X-Received: by 2002:a05:600c:4fd2:b0:46e:506b:20c5 with SMTP id 5b1f17b1804b1-4801e34c9b4mr113533285e9.26.1768744152922; Sun, 18 Jan 2026 05:49:12 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996cf42sm17101497f8f.20.2026.01.18.05.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 05:49:12 -0800 (PST) Date: Sun, 18 Jan 2026 14:49:10 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v5 00/14] Introduce forwarding table Message-ID: <20260118144910.51b28db2@elisabeth> In-Reply-To: <20260116005926.616085-1-david@gibson.dropbear.id.au> References: <20260116005926.616085-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4NohFO7hwUR4dNBsVDVsBfjCi2q2GjLY07p4-dOGCeI_1768744154 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HQXKJLC43VNB44ZVLN7CITOTPMNZ2FQL X-Message-ID-Hash: HQXKJLC43VNB44ZVLN7CITOTPMNZ2FQL X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 16 Jan 2026 11:59:12 +1100 David Gibson wrote: > This creates a new data structure for recording our port forwarding: a > table of individual forwarding rules. This is intended to replace the > existing forwarding mode, map and delta structures. For now, only the > delta[] array is removed. map is still used, but only for automatic > forwards. Mode is still used, but only has significance during > configuration. > > There's still a lot that can be done for flexible forwarding, but this > introduces the core data structure, and does enough to fix at least > one concrete defect with the current logic (bug 187). I think it > would be a good point to give it a solid review and maybe merge. > > I'm aware that this is a very large complex series, that will be > difficult to review. I think that's more or less inevitable > implementing a feature as broad and complex as "flexible forwarding". > If it helps at all, I'm fine if it's not reviewed all at once - I > won't assume review is complete until either you say so, or I get > comments or R-b on each patch. > > This applies on top of all 3 of my outstanding series in this area: > "Allow listen functions to return fds", "Clean ups to epoll > references" (v2) and "Small cleanups to splice forwarding logic". > > Changes in v5: > * Fix coverity warning in ifname handling (2/14) > Changes in v4: > * Numerous cosmetic changes > * Re-arrange rule hinting to avoid coverity error Finally applied! -- Stefano