From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OFyH9Y4l; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 8533F5A0271 for ; Sat, 31 Jan 2026 10:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769852840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6fVF7t1ZhuX8nAruWX6qhqTwMQ46GdGkTx456O/cn3s=; b=OFyH9Y4lm7Tjm1CQkqzyu+jjPNjY2UFt5iGCAB7ovR60vglmBHHrWimrRoL5Be271juGJy /kTZl646nVRalWwdwu3mODP5D/12y2nnV6m+v4RI0G0YntRlkpzPiPlh8puM2YtYMzkLQ5 ToV6G9dvyIo4QHKns0FiuY0Pkhs8/4A= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-DLfCHlCtNpeN3VX2x5J_dw-1; Sat, 31 Jan 2026 04:47:18 -0500 X-MC-Unique: DLfCHlCtNpeN3VX2x5J_dw-1 X-Mimecast-MFC-AGG-ID: DLfCHlCtNpeN3VX2x5J_dw_1769852837 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-482d8e6e13aso14275515e9.3 for ; Sat, 31 Jan 2026 01:47:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769852837; x=1770457637; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6fVF7t1ZhuX8nAruWX6qhqTwMQ46GdGkTx456O/cn3s=; b=iKmDag/WT3d5PqIPvFahvil/7v4R/SXVz5aih3dAIEcwf5SPnEQ4/ezI2Ejq24SXN3 myIWFkfJwguqD0wcZ0qnvkNOxmi8rH7jwjMFiWCKb/pl0Oblmdkps1qRzKmHchBX2Zde dDXEqgXnCckcDzzGqpTzhgAM3ZsT/3cVhfs3FvPt6jZmRxlwgYC6+hadC1s/jP/1Nyd3 wPvGgu2wQSRPYZZIu0uMV2Kv3KNPUfFfOr+rb10gsPYMRwQMtXat4F6T80zfmXzZmHBC 3cNFyRmG8uYFbsHkavFPte0mW2JhNW8dbLXUygi7L5HMbZaDtQUm7qPDTyTYJRxUtMyf 8BDg== X-Gm-Message-State: AOJu0Ywqa9qQz9jwzObvg37za7ksHt1+oALSgk/hJwKNbNgnytDO4S// Iu2+rkw7DS3XUHt+VwgS8QH9bfQUeFQhSsNZTrws5xlq8hONo/kmabsQm1t5buY5hCGzkkrQiGC FbyLNU6zX/5vdBbb6OIkWKbmwKBK8dRCOFyjNG1y6mpXZIDWJwMQtKA== X-Gm-Gg: AZuq6aI4Z0Qu8jpsflc06NmtXB0WalcpLUOUuPUe7apHS5B12YRsWtcHy03FYJ1ZAv0 8+VeNmQ3pOgtOXIKr16kdfnIiuMUDzAciMqY93An7Y79bXjI+VSzSuirvlajgIqc4RpKTZKsafC SZ5jSxSvxAHbZjyKLozes9ifHb8KM/nrnIGP3YC1GFDyqNowLempwycqtn6bgesg6bUhSdMZ1/+ bHAWaBrUbZarfm9J2F8OA1wvYK0rpAF+WhUsYD/Ng3mwK5HCci8HwHTC1uoX3/tv/ze0qrzt5kf eKM9OZ/pLgPFVdoynjPnYejtx2z0uBEGHNyF2/ViFsHSTr+3yh3SqZABrWkR/vgJYfD2XURKM/h OjrKnE6kRt7mjCimYYLGT X-Received: by 2002:a05:600c:3f0b:b0:480:1e9e:f9c with SMTP id 5b1f17b1804b1-482db45fe83mr70710675e9.10.1769852836913; Sat, 31 Jan 2026 01:47:16 -0800 (PST) X-Received: by 2002:a05:600c:3f0b:b0:480:1e9e:f9c with SMTP id 5b1f17b1804b1-482db45fe83mr70710485e9.10.1769852836427; Sat, 31 Jan 2026 01:47:16 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131ce64sm29267317f8f.26.2026.01.31.01.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 01:47:15 -0800 (PST) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/3] Fix errors in FIN timeout logic Message-ID: <20260131104713.563f5426@elisabeth> In-Reply-To: <20260130044104.1793253-1-david@gibson.dropbear.id.au> References: <20260130044104.1793253-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Sat, 31 Jan 2026 10:47:15 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7P1A6h0FMG8Q_7TSReKe3Bqap4jPhM3aIB_TrOg_p8g_1769852837 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ICH4DYJGGRN6QFV5A4VMOSXKUABEJ5Y5 X-Message-ID-Hash: ICH4DYJGGRN6QFV5A4VMOSXKUABEJ5Y5 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 30 Jan 2026 15:41:01 +1100 David Gibson wrote: > While investigating bug 179, I found a number of things that confused > me about the TCP timer handling. One of them, I think I figured out > what's going on and what should be done about it. So, here are the > changes. This is mostly about FIN handling and only tangentially > about the timer, but it does at least slightly simplify the timer > handling while I figure out the rest of it. > > Changes in v2: > * Stefano pointed out some errors in my guesses at the history of > things, evised commit message of 2/3 accordingly > * Added 3/3 checking for shutdown(2) failures > > David Gibson (3): > tcp: Retransmit FINs like data segments > tcp: Eliminate FIN_TIMEOUT > tcp, tcp_splice: Check for failures of shutdown(2) Applied. -- Stefano