From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH 0/2] Fix minimum frame size checks in vhost-user paths
Date: Thu, 12 Feb 2026 12:39:30 +0100 [thread overview]
Message-ID: <20260212113932.1047788-1-lvivier@redhat.com> (raw)
In the vhost-user code paths, buffers from the virtio queue include
a virtio net header prepended to the Ethernet frame. The minimum
frame size checks (ETH_ZLEN, i.e. 60 bytes per IEEE 802.3) must
account for this extra header, otherwise the size requested from
vu_collect() and validated in ASSERT() is too small.
This two-patch series:
1. Introduce a VNET_HLEN macro in virtio.h to replace all open-coded
sizeof(struct virtio_net_hdr_mrg_rxbuf) throughout the vhost-user
code, improving readability and consistency.
2. Fix the minimum frame size calculations in tcp_vu.c and udp_vu.c
to use ETH_ZLEN + VNET_HLEN instead of bare ETH_ZLEN, correctly
accounting for the virtio net header in the buffer size.
Laurent Vivier (2):
virtio: Introduce VNET_HLEN macro for virtio net header length
tcp_vu, udp_vu: Account for virtio net header in minimum frame size
tcp_vu.c | 29 +++++++++++------------------
udp_vu.c | 14 +++++---------
virtio.h | 2 ++
vu_common.c | 13 +++++--------
vu_common.h | 2 +-
5 files changed, 24 insertions(+), 36 deletions(-)
--
2.52.0
next reply other threads:[~2026-02-12 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 11:39 Laurent Vivier [this message]
2026-02-12 11:39 ` [PATCH 1/2] virtio: Introduce VNET_HLEN macro for virtio net header length Laurent Vivier
2026-02-13 11:47 ` Stefano Brivio
2026-02-12 11:39 ` [PATCH 2/2] tcp_vu, udp_vu: Account for virtio net header in minimum frame size Laurent Vivier
2026-02-13 11:48 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212113932.1047788-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).