From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PN59/abA; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 428145A026D for ; Fri, 13 Feb 2026 12:48:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770983280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5yJ50AdtFkKmQVSkQ+1BD3Nq18vhxnVkrhnQEkY2hIA=; b=PN59/abAmDGfE2GOFRGrYKUR7HnRCYAzs6TkZoJNp8rNsdODWcDVg/htRG/aZYok7HhgNR TLqenpxz/lg0YIZjvGE2JfmA/xFHXmiyEeM3qJ52dAxnMVdMr3ZMkiWoJzcfq+ybuUkwnX DoKnZMvi8azJWBdO1ilQWeAj2inY69U= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-KERb4Fm-OReBICeEmH_X_Q-1; Fri, 13 Feb 2026 06:47:58 -0500 X-MC-Unique: KERb4Fm-OReBICeEmH_X_Q-1 X-Mimecast-MFC-AGG-ID: KERb4Fm-OReBICeEmH_X_Q_1770983278 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43768240a29so491067f8f.1 for ; Fri, 13 Feb 2026 03:47:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770983277; x=1771588077; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5yJ50AdtFkKmQVSkQ+1BD3Nq18vhxnVkrhnQEkY2hIA=; b=VHAcnCAKrP+7AMUdh92QSfXoXI9YL5xl7iP/Hss2TBsdmzbhz97IfRM8XrNnPTMbeR ghWu7woeT93oUZuaX9AsGIfiwDjGZ0dyChjQGg/CsNViLHaVPfpuodajffQ0Nd7/mzIf 4eDD/OmYZmM6c9ANtcxJ6thpn9iifi2TnNKlTUzl0uTaT9VYnx/2Uk0VdYTmjsW0DZOd lKXH03LkFQl/NmGfBSkVyEblIPbMtd/OQQFkmDRklDy73MrPo5U7N4SiTY72dIwm4b5D 3zwTv49hdfPDA0OtB/ks1hS5yO+qKWim+1SUHIDXtruoIIKcezf1D4S414ZpHkgsBrmJ UKuA== X-Gm-Message-State: AOJu0YyRkiRf0Y9rUr+UUv7+vIHUbcpL9UytoqVKyF/pygILnqUai/F7 Tqeuk1M6O2u+berfHmddvWAROcLUuG/aEhF+QWRqgHB3ejBD6TF8fWvsSDnexAzGA2Uag9IG9Om 31wMT8YxgrGGnJlo7IZGRr79IaLo4Bubopdt0WFL0UXNp9on/qP4rHXBjymLhb9owF8Ou/o3lmB oefFxFpklgct/Y6+C0kKNxV3VlR2lgaYo1ra2X X-Gm-Gg: AZuq6aJDkJM4kf/IrgM6D0tsZWmoTdlFIthCtTFnwaOXwMxkfswhHFInk65duBDpHCF uo0x17FYxG6iQug4EFEFJ4TTbGirJM1Qq55iXmCDdq+zEwWnb++8M6y0zk0Q+0yTI8PbEWiASML WsfH9JWPYzMXVlv+N/gc2Zxeyrr1+k0fCf+fL1IlsC1IP7Ftu1El0VDRaTl7DkCLmPwzPNPfayO r+0ss1P7iH3soh7kjDmG4yM+H7HaZGWGpEMhuao5ly6yUPrUzu5a3hRN/VoSfG0sxg71lPDqsVM BYvcNB1Mt6I0dJXBwQnRveVscv1F+vnGF2viyLiwvJjaSD7G+DEwzELVg1mD4jjpzMXYFitL74O eD+xumyOLyijFPyflqA8JLyLLtZUjyB+Z+ASGi50u4ZZVM4vkMw== X-Received: by 2002:a05:6000:26cb:b0:435:92c6:d556 with SMTP id ffacd0b85a97d-4379803265emr3007254f8f.16.1770983276702; Fri, 13 Feb 2026 03:47:56 -0800 (PST) X-Received: by 2002:a05:6000:26cb:b0:435:92c6:d556 with SMTP id ffacd0b85a97d-4379803265emr3007196f8f.16.1770983276012; Fri, 13 Feb 2026 03:47:56 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a6a5e5sm5038571f8f.9.2026.02.13.03.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 03:47:55 -0800 (PST) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH 1/2] virtio: Introduce VNET_HLEN macro for virtio net header length Message-ID: <20260213124754.6553216d@elisabeth> In-Reply-To: <20260212113932.1047788-2-lvivier@redhat.com> References: <20260212113932.1047788-1-lvivier@redhat.com> <20260212113932.1047788-2-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 13 Feb 2026 12:47:55 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2NB7WaWCLwduTgRXaJg2BoMN4hJ_LSZz5Z8WplDU3sE_1770983278 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KDRM2OY4N366IPVV7J7S7AMSYJGEICYM X-Message-ID-Hash: KDRM2OY4N366IPVV7J7S7AMSYJGEICYM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 12 Feb 2026 12:39:31 +0100 Laurent Vivier wrote: > Replace all open-coded sizeof(struct virtio_net_hdr_mrg_rxbuf) with a > VNET_HLEN macro. > > Signed-off-by: Laurent Vivier > --- > tcp_vu.c | 21 +++++++-------------- > udp_vu.c | 12 ++++-------- > virtio.h | 2 ++ > vu_common.c | 13 +++++-------- > vu_common.h | 2 +- > 5 files changed, 19 insertions(+), 31 deletions(-) > > diff --git a/tcp_vu.c b/tcp_vu.c > index b9e9b55ed3d3..f7bda4943e43 100644 > --- a/tcp_vu.c > +++ b/tcp_vu.c > @@ -49,8 +49,7 @@ static size_t tcp_vu_hdrlen(bool v6) > { > size_t hdrlen; > > - hdrlen = sizeof(struct virtio_net_hdr_mrg_rxbuf) + > - sizeof(struct ethhdr) + sizeof(struct tcphdr); > + hdrlen = VNET_HLEN + sizeof(struct ethhdr) + sizeof(struct tcphdr); My eyes thank you dearly. -- Stefano