From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] tcp: Move tap header update out of tcp_fill_headers()
Date: Sun, 15 Feb 2026 11:56:17 +0100 (CET) [thread overview]
Message-ID: <20260215115616.136706cb@elisabeth> (raw)
In-Reply-To: <20260210160821.8248-1-lvivier@redhat.com>
On Tue, 10 Feb 2026 17:08:21 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
> tcp_fill_headers() currently calls tap_hdr_update() to set the frame
> length in the tap-specific header. This is backend-specific: the tap
> backend needs this for its frame length header, but the vhost-user
> backend passes NULL for the tap header and doesn't use it at all.
>
> Remove the tap_hdr parameter from tcp_fill_headers() and instead return
> the computed L2 frame length. The tap backend caller,
> tcp_l2_buf_fill_headers(), now calls tap_hdr_update() itself with the
> returned length. The vhost-user callers, tcp_vu_send_flag() and
> tcp_vu_prepare(), no longer need to pass a NULL tap header.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Applied.
--
Stefano
prev parent reply other threads:[~2026-02-15 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 16:08 Laurent Vivier
2026-02-15 10:56 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260215115616.136706cb@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).