From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hTXE+DRS; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 0687B5A026D for ; Sun, 15 Feb 2026 11:56:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771152981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tfSuaGumt6n6R10ZDMmxWFrR93cZgZ2SzWKBpBgrDBk=; b=hTXE+DRSqtsJCcGGGmgVZFSyiOmtQxrb/4Dp18ErkhitDVFVhIPmcDWihxZfGuahI7ZqQs c1cXeMeMeQLrkI4cFeupf5jvJJ9BXbEwKH/NlbuttGqCs8Fjiumegv1+u782jLqJfoga/A PXDxekwPuoG7d/sRcDjiR4pe5VM8aDo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-zIYJBWUWOxmzei7ssG82vg-1; Sun, 15 Feb 2026 05:56:20 -0500 X-MC-Unique: zIYJBWUWOxmzei7ssG82vg-1 X-Mimecast-MFC-AGG-ID: zIYJBWUWOxmzei7ssG82vg_1771152979 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4836cc0b38eso14289585e9.2 for ; Sun, 15 Feb 2026 02:56:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771152978; x=1771757778; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tfSuaGumt6n6R10ZDMmxWFrR93cZgZ2SzWKBpBgrDBk=; b=xMPeHjhbTRImhujCmUpTmiuHeF9o7zqNV/mZEjqKmQyfno7WyJ0WRu77UuDWjzY5gp m89Va/HHcp+7rNnIyLHk131HrvTlhbz6wVxKU1/sGXrlNjMECsdBJTeKxkel2JJYPxnw jVSJBgTBelg75CbxSdMivA6amHBR1laWq5yPZDxEcA6wHLD/vsU6Skga1mAPl6NlEHbt Dz6z3VtAF9VYDuhtFq1JI8OdrSCSpUqtmDr5J7Y3xXHeDhlfnbXPsspK0kVQMC8k6eDk CLFUF2rA+u4+ETd7MU6+PIRj96E1nSERTy+CrEVDvXhmhMlcK3srCN40RSpbK685D1zz 8R8g== X-Gm-Message-State: AOJu0YxRlhurxvEDpGzYjvkeCkzVCn9/zAVVzzDRA36pSBCwFLjwSPzQ fSNyldQDYAJws9V33+rUADhCz0xEU4AQ2v+hQlQ5rG2wfRlzAlOAOIZNGNtbeNS7MH8bBWDe84n ApCBOfnwmxa7pwMCFI2FyJ4eqCzq+C/zH+zQ/DiztJIwkR+quREcGwaWlzu+/uV3NxcRESIO28Q 5vZVKldcRsCXZG8xFIzc40YZy0jussF8IzXr0f X-Gm-Gg: AZuq6aJUtEMD5svJgbmT7ZZFqhT5eFAJnYgvY6eZFrHLm70HqUht2/+ibdGmRqZBXng hQYbNgz+s2dLNE+9Ud62FT2V1RuCs02tWT9dyQdKkWY9sQUCc71KJbHO2DfGJkee0kcvZXZRAAt KtF3yQjS0bCcHWtZnjUwKQV4gNgbj/Az61u31mHIHYFgN4eGKhumBDN+DgUbwZRWvMebl4mPgt0 799KY7zaeoKHZSUDwj9m684NW0476t30bbqoUS5bOZ7UQ+KyoOiy+OP83SWDL4kR8NXGYDbsLll AN0gVB/mnfs4awYHs6pKmu2mItMtfZvZKRH0MiX+4LizPo++2++dZnyQBhleVaG3gpqjwbgPfEo jG/jQvmeCOz7PdxMNJ4Aal0bapCeHXH7ewBCaZWrA8Z7KEKFwbg== X-Received: by 2002:a05:600c:8486:b0:47e:e076:c7a5 with SMTP id 5b1f17b1804b1-48373a1c41emr110144265e9.11.1771152978346; Sun, 15 Feb 2026 02:56:18 -0800 (PST) X-Received: by 2002:a05:600c:8486:b0:47e:e076:c7a5 with SMTP id 5b1f17b1804b1-48373a1c41emr110144015e9.11.1771152977853; Sun, 15 Feb 2026 02:56:17 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4836aa0847asm344176405e9.3.2026.02.15.02.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 02:56:17 -0800 (PST) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] tcp: Move tap header update out of tcp_fill_headers() Message-ID: <20260215115616.136706cb@elisabeth> In-Reply-To: <20260210160821.8248-1-lvivier@redhat.com> References: <20260210160821.8248-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Sun, 15 Feb 2026 11:56:17 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TpyO37CqUUqB8-q7mBuUjZSDK7j1dW6wyBb4iPx7NOU_1771152979 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: DGNB6E2FH4WJ2ZSDFD2YOVMZGDHTCF6B X-Message-ID-Hash: DGNB6E2FH4WJ2ZSDFD2YOVMZGDHTCF6B X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 10 Feb 2026 17:08:21 +0100 Laurent Vivier wrote: > tcp_fill_headers() currently calls tap_hdr_update() to set the frame > length in the tap-specific header. This is backend-specific: the tap > backend needs this for its frame length header, but the vhost-user > backend passes NULL for the tap header and doesn't use it at all. > > Remove the tap_hdr parameter from tcp_fill_headers() and instead return > the computed L2 frame length. The tap backend caller, > tcp_l2_buf_fill_headers(), now calls tap_hdr_update() itself with the > returned length. The vhost-user callers, tcp_vu_send_flag() and > tcp_vu_prepare(), no longer need to pass a NULL tap header. > > Signed-off-by: Laurent Vivier Applied. -- Stefano