From: Stefano Brivio <sbrivio@redhat.com>
To: Peter Foley <pefoley@google.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] Add missing includes to headers
Date: Sat, 21 Feb 2026 18:57:08 +0100 (CET) [thread overview]
Message-ID: <20260221185706.6bb0ade2@elisabeth> (raw)
In-Reply-To: <20260219184454.1501389-1-pefoley@google.com>
On Thu, 19 Feb 2026 13:44:54 -0500
Peter Foley <pefoley@google.com> wrote:
> Support build systems like bazel that check that headers are
> self-contained.
>
> Signed-off-by: Peter Foley <pefoley@google.com>
Thanks for the patch, Peter!
It looks obviously correct to me, but I still have a question: do you
happen to have a Bazel BUILD file somewhere (we could also add it to
passt's contrib/ if it's not in any other repository) to check future
changes against it?
Otherwise we risk breaking Bazel builds again soon.
I'll review and apply within a couple of days regardless of that.
--
Stefano
prev parent reply other threads:[~2026-02-21 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 17:45 Peter Foley
2026-02-21 17:57 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260221185706.6bb0ade2@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
--cc=pefoley@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).