From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Y9Szea/A; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 4FE5B5A004E for ; Sat, 21 Feb 2026 18:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771696634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cI/ip/I8daY9jTuTkXzs5zfNQ8z1k8csXgBpM7LGGX0=; b=Y9Szea/APZNx4yASqsp/W7NF94ClaO+SkTkQ8xgJiYPY0x6JWlID3FytWDKsVBTxtrcYBg iPpfd6X/WLA19zbDQSbzqFekmORM6p4Yt+k8WD/qcG5FUPz9KiuzFqz4Vt8YaDloJDJyJr QaFDfepVmsuLLQL6KskvIIylPnzNnvg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-momOGU-FNmCqvl5KWjNQ7Q-1; Sat, 21 Feb 2026 12:57:12 -0500 X-MC-Unique: momOGU-FNmCqvl5KWjNQ7Q-1 X-Mimecast-MFC-AGG-ID: momOGU-FNmCqvl5KWjNQ7Q_1771696632 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4837f288194so24836965e9.2 for ; Sat, 21 Feb 2026 09:57:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771696630; x=1772301430; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cI/ip/I8daY9jTuTkXzs5zfNQ8z1k8csXgBpM7LGGX0=; b=L8Hep+p15p2cXizCJXIf0FjLIAAZV6HY8PVn5BBxbVTFxH7ZHpzev6IOb8XYpZSbbA mR5KS3Ff0+GkS1WSxHLgvoweaef/+c9OZgDJ0CFuHdNU+2Kr225it4unVRKYm2RZUNtY AF2vLJ706xdH+JzTLo42OVTLpAZmNrNNGNPoSL/6pi7Ug431gzBk7aA8ycvkv45ovfDF bzb1jXff61JgS2ENONt/tx8aZckTyxlvSjQrsz8XJV2c8WvSy3TuIU787kog/YOf8vMT M7grtZtn5HFthVVRyHxiQk5wUebV+4FM8gA0Pf6U73xAETPgxQ1+IwD2Hk/c+hGdoMDs DYQQ== X-Gm-Message-State: AOJu0YxLiYQ6UYIkb9GigrOJ7neWZHC5PGJGRPAHgo90uuWxV6tT6iOr Kr3+AjngsLiDMq0Tc6a1L4m47Iwa8PLU6le7pNxUOxpQP4DGYy28HnWPfid8ss5VnUfPyOocJN9 1Glbq9min0j8DldFLFnP4qVjwg55JcsUbUoNOYK1J4A/ppzK0HoHk4AkcrHVBBw== X-Gm-Gg: AZuq6aKitbTbgC1he6W1SmIpY6UNqKO/MKGyyv97DHZzzJ0/NKoonbDJv7GzREnqQYW yE6kokgbYeRWS3HgO7tJdQDvmvcTf/FRvFg+jtMOu9QssInmVN7urZCEc8VdEIe5gLrUSKwq00o cFS98gIRE4M2kBbq4XL8qyzYIaSjEEPpmxlGU3wt8bPSDHmoRpR2O4H8jc1JEWFdxh5Ke7NRm7I 5T+eCDIHmc3jerZv99HqYKl7tFZDB4BuFWIxRefWIAhfqcuTtbDYicvn79brENIqWCZCeIxbrCU k9AeEwNUX2+6Jp5bDI2pe/RIbAAiMKt7w8cyl5HZ68rIre1k1Rh4YIFI42hidQLrtj5sxAO6F/c KnaGQK81sJrz+dMG19nDQ9Mgma1hwSMlOEhXnJJf4CXzTHZWXNg== X-Received: by 2002:a05:600c:154b:b0:483:7ae2:1737 with SMTP id 5b1f17b1804b1-483a962e486mr49801705e9.17.1771696630499; Sat, 21 Feb 2026 09:57:10 -0800 (PST) X-Received: by 2002:a05:600c:154b:b0:483:7ae2:1737 with SMTP id 5b1f17b1804b1-483a962e486mr49801565e9.17.1771696629986; Sat, 21 Feb 2026 09:57:09 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a9caadd4sm64069495e9.11.2026.02.21.09.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 09:57:09 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260221185706.6bb0ade2@elisabeth> In-Reply-To: <20260219184454.1501389-1-pefoley@google.com> References: <20260219184454.1501389-1-pefoley@google.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Sat, 21 Feb 2026 18:57:08 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ge9ksq0iXK1Klxxft-AGhBGIhXHJnusM9V-U8keVZe4_1771696632 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: UWCWOYOYZPJTG7F2ZTRWNX7HMVP7GDS2 X-Message-ID-Hash: UWCWOYOYZPJTG7F2ZTRWNX7HMVP7GDS2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 19 Feb 2026 13:44:54 -0500 Peter Foley wrote: > Support build systems like bazel that check that headers are > self-contained. > > Signed-off-by: Peter Foley Thanks for the patch, Peter! It looks obviously correct to me, but I still have a question: do you happen to have a Bazel BUILD file somewhere (we could also add it to passt's contrib/ if it's not in any other repository) to check future changes against it? Otherwise we risk breaking Bazel builds again soon. I'll review and apply within a couple of days regardless of that. -- Stefano