From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=V9ZvHen+; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 137535A004E for ; Mon, 23 Feb 2026 18:35:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771868137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oJUUYjx2DzA0fj+EMe4HZ+fsJLA+JXfuUUrB8WK5VF8=; b=V9ZvHen+RnUBdzonPFY4M1u6ri08DeCEzUYLXKS0fVZoML5Y0bx4IcxxNYAnA+zySNnOE3 TAOave+LPnaZPMbAsb6Bx0/RQeTpYI5ZHxux/VbozJkAb8v6MCUFhZHOV+0GVUYmMsB58s RzdlkMXFLZsEedDW7nAIngbjxMxrGjM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-__hFqcuUMeyOEwNge6-00w-1; Mon, 23 Feb 2026 12:35:34 -0500 X-MC-Unique: __hFqcuUMeyOEwNge6-00w-1 X-Mimecast-MFC-AGG-ID: __hFqcuUMeyOEwNge6-00w_1771868134 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4837b6f6b93so34589285e9.3 for ; Mon, 23 Feb 2026 09:35:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771868133; x=1772472933; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oJUUYjx2DzA0fj+EMe4HZ+fsJLA+JXfuUUrB8WK5VF8=; b=YfAnGDePd71+6j8dJ1iNSwYgHZ3fT+2eFL0L0+1wHk8gPDaqhuMNZTzHO+fw3xkT2o ezZp6EC9Ro4ApYdLBzBDooAIa4BMOn8w8kL1vvME89Fr+vvjm+UDN7Da9baLMmrXMkf5 arilk/dG15i6txP8oK71UQGMcj9u2/8pi6YBML4LTIuIqH//c0zZuL6M4ENg64htjERU 1CV6FfrDqTbzmyCr4tKM05qMSSxisCtPXsyaUF3KmHAjaM6Y47FGbBM8wDKU6khWnWB6 krH0V+jHlqeQB7H+/7mwJwlEKUC5iG3gdgFYhwTgeC3HSko5yHjPHGmV8kr80XyDeP4Q pPiw== X-Gm-Message-State: AOJu0Yz5jwFzGtjV+C2iEzdribJwZuSb9Y6srmUZ+EVyG8kDQVcRy6+A R+WBIVVst+W+PDLB2FCtuObj5cB37RMtpYCXZHS3yW4ZWnKxyRTGQdqss8iAA7xDSeSD2zw24o4 OG2a9iBWRSCwMVDZ5ZMf7U2or6sFcoqjB+eSqy8FLh+NbG/MsbtSqDkbSL6X4Hw== X-Gm-Gg: AZuq6aLhTCnX70ye50PF0X5e+iIlmJPNsW+K+2WYnHCfXcU9Nj1v4fjDg4986sBV6+x RPOYWBdbFitXfInQVNMP8IQ3VDYmVxXiroyG9zZhHUlv6Mg0kDcIM5XSw7aeGA5V0VtBj/isR3W K1yVTwkvsr5BayRn2puhLZA4cz/huMXe7apfX7RlFEuRN47pC0gzQG63gwuqi7/87kOrDLTi9Q/ P+ejsD5dph2M13NSeiOal0K/EMlcVW0euBc9znxMBvjWyMijW/iRh4VyJeRRaOa7Q4sQi3wAtZ0 kYQbJus8o1kpm2cl3UUB10me8t3K/WvfYWGyqHirBo3WmYjVoRURaLaJmX4FvNQplcQgguo2I7t Qr3v4X66irG2CfNxKJGQSJ6e3lYvgIga8 X-Received: by 2002:a05:600c:4744:b0:476:d494:41d2 with SMTP id 5b1f17b1804b1-483a9605eb3mr142249145e9.29.1771868133063; Mon, 23 Feb 2026 09:35:33 -0800 (PST) X-Received: by 2002:a05:600c:4744:b0:476:d494:41d2 with SMTP id 5b1f17b1804b1-483a9605eb3mr142248725e9.29.1771868132592; Mon, 23 Feb 2026 09:35:32 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d3ff27sm22392754f8f.22.2026.02.23.09.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 09:35:31 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260223183530.2c040c94@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Mon, 23 Feb 2026 18:35:31 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oYfmOBHAd_WJ7PVXxe7OWx6-hOfEoeeo9m0xjITaT7I_1771868134 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NH3SBJHIIOB74GUJIOWVGK3KDHMTY6DN X-Message-ID-Hash: NH3SBJHIIOB74GUJIOWVGK3KDHMTY6DN X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 23 Feb 2026 12:23:08 -0500 Peter Foley wrote: > On Mon, Feb 23, 2026 at 11:45=E2=80=AFAM Peter Foley = wrote: >=20 > > The primary BUILD file is in Google's internal repository, so I can't > > share that. > > An OSS bazel version looks like > > https://github.com/pefoley2/passt/commit/4f89da6f05c84c9f171689541fd815= 49b4801270 > > Unfortunately in my quick testing, the OSS bazel build doesn't actually > > catch the same layering check violations that Google's internal "Blaze" > > variant of bazel does. > > So I'm not sure how helpful it would be. >=20 > I poked at this some more, and clang-include-cleaner seems to be able to = do > a good job of determining whether the headers compile stand-alone. > I had to make some more fixes to get there though: > https://github.com/pefoley2/passt/commit/5067d86e567851db24dad515cd36b536= 27266ba6 By the way, we already run clang-tidy tests ('make clang-tidy') as part of our tests (test/build/static_checkers.sh). Would it be just a matter of enabling the misc-include-cleaner in the list of tests we give clang-tidy from the Makefile: https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html ? I haven't tried. > If you want, I can fold the two "include fixing" commits together and > re-send. Yes, thanks, that would be appreciated. I would first try to settle on a convenient way to keep Blaze/Bazel happy for the future, though. --=20 Stefano