From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=c3iYbZod; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 73D255A004E for ; Mon, 23 Feb 2026 20:05:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771873535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NOcW0oAKtmjSZqt2ejqJr/LghFW3Va3cgSKuR83z9oE=; b=c3iYbZodlcmR8VXUSNzoW//PRUsLK9PTN+wMB6Bx+op6cVJdVbp6watvkw3U+mE2SkiZZ/ jOz8npkor8sMFcw2nl0LpdGjRxiNW+2kRyn/FFYkNPslyWT2vBMAo6x8E2gicQTSmfEbk3 z2xkhCeHrg2+T/oqaU1pfPglGWPAiPM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-QiRAzVfwNiS8m-GZOBWnxw-1; Mon, 23 Feb 2026 14:05:33 -0500 X-MC-Unique: QiRAzVfwNiS8m-GZOBWnxw-1 X-Mimecast-MFC-AGG-ID: QiRAzVfwNiS8m-GZOBWnxw_1771873533 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4362456500eso4302114f8f.3 for ; Mon, 23 Feb 2026 11:05:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771873532; x=1772478332; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NOcW0oAKtmjSZqt2ejqJr/LghFW3Va3cgSKuR83z9oE=; b=UK10shYl9qUNunYPRSGW+ZjDKCkujAt07TvwSODjBrG0WloRPqADSbx5mtkBKw7gwO xZX7x+eIdAFyUiSXFsPtoIcgKUmJFoKxoncTYSG1MEPaQM9u2hZUpboL/uru806zdcnr lgEG7QG6YU70DBPkGwguJ6exV75w8K0gOxxZtt04WmotC3jfv3awWobU00LcBj3b/+4c 86MO2nESZD2O2/d/zIASyMUOnQYtxbr+PttYwRpKTT+Q1YVpAS0ICzZNkHqn8kL+LkHx Crw6rksKYpQ2dthz55TS2gd1jqLxTSQlcfDt+ZigR7dy/TMlx1Q3TidKIb7VGbVzb4sy Ceqg== X-Gm-Message-State: AOJu0Yw4PCQX4zhFV3giUYXS2UhuP0/En8moxBUt3hpnh36V29POq4C7 vnkCUX15mKWfn8E07pncW79YjOkukw5lj/4rUgV+oyjcrMN39FRkRveXcjKBxPNFZKHU71mm4HX DXHiNAXRdpFV9whe0pgRIDvYX4JmxaB8aMPm89xa5rWvp3B3OZenYPBEjoRFj3w== X-Gm-Gg: ATEYQzwQHambT5HjuF/Rd12hT0otXYKD6s1uBMxpFoQ+ixRwDpr6Ayi1B3VA6Ab5oSp bCZ0iZG/KP9QZ4IKPuRiYGxUSjg3HdIzUkOa0gxQ/8shNQkXJwk4F3CDVUsHfPojhLmTqCjrLTB sRY51rrrhjdWXXg9hjGCQbQW2Vfkstr/K3EqImsrIHJAaX38Z7JQgq2/hQEC5d0eB6sMlVj+0yi xHpRdj3xFVoKDr90OHm045NLmFxckUPzANt0UkfmsWBWNyagsBPSafIYWCyFvRH3nkqvm3c76uY HmXiNo2hJQMK5vXCUEWudgatR7jfk483rX+bxL3sdQ/Qk5tMGGK1xNCm1GHd49VNGvmw3l4sL+R IgAdIsiiCddDmru6SUh7zfNAx24nIBq4x X-Received: by 2002:a05:6000:26cb:b0:435:db6e:e3b2 with SMTP id ffacd0b85a97d-4396f1756acmr18204973f8f.27.1771873532067; Mon, 23 Feb 2026 11:05:32 -0800 (PST) X-Received: by 2002:a05:6000:26cb:b0:435:db6e:e3b2 with SMTP id ffacd0b85a97d-4396f1756acmr18204917f8f.27.1771873531498; Mon, 23 Feb 2026 11:05:31 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970bf9feasm21113456f8f.6.2026.02.23.11.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 11:05:31 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260223200525.79be5cda@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> <20260223183530.2c040c94@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Mon, 23 Feb 2026 20:05:30 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ysvImupyjoBZBATS9A3aOaTcA0rFpAA3bDbPQly7M3s_1771873533 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: B3BNB7GVAAFQE4DGXPTBNZO4JRL7PXLU X-Message-ID-Hash: B3BNB7GVAAFQE4DGXPTBNZO4JRL7PXLU X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 23 Feb 2026 13:08:07 -0500 Peter Foley wrote: > On Mon, Feb 23, 2026 at 12:35=E2=80=AFPM Stefano Brivio wrote: >=20 > > By the way, we already run clang-tidy tests ('make clang-tidy') as part > > of our tests (test/build/static_checkers.sh). > > > > Would it be just a matter of enabling the misc-include-cleaner in the > > list of tests we give clang-tidy from the Makefile: > > > > https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.h= tml > > > > ? I haven't tried. >=20 > It appears so, a local change to pass -checks=3Dmisc-include-cleaner to > clang-tidy resulted in a ton of errors like: > /usr/local/google/home/pefoley/passt/vu_common.c:277:2: error: no header > providing "iov_from_buf" is directly included > > [...] Hmm, "nice". I guess we should find out if it's reasonable / doable to "fix" all those. > > > If you want, I can fold the two "include fixing" commits together and > > > re-send. =20 > > > > Yes, thanks, that would be appreciated. I would first try to settle on > > a convenient way to keep Blaze/Bazel happy for the future, though. >=20 > As I mentioned earlies, Bazel appears to be happy withough the include > fixes, it's just Google's internal Blaze varient that has some kind of > stricter checking that falls over. Oh, I didn't understand, I thought Bazel reported a non-empty subset of the failures from Blaze. > I can send the change out for supporting the Bazel build, but I think usi= ng > misc-include-cleaner would be a better plan. Yeah, I think so too... as long as it's not hundreds of additional warnings / fixes we need to take care of, it's definitely less effort and should be less clunky too. --=20 Stefano