From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=afj/hgEC; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id AF3BA5A004E for ; Mon, 23 Feb 2026 21:47:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771879671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+CQa2qTdj7Kc8K0XExJBFKARHDqe8hkQ/ZrKn6T1qP8=; b=afj/hgECxMkqAd9t0U5+j7ioa09d7qj+4M1ve+pSqFTx8Z2ZxDp9nrvP/JDO83i/C1gFkF 3GYZtgfXlJbK6ZfsiciBeUYeXPb0gLs3UZ7fLvmlVNOOxCRfQffvNKbyELvJVoeGEWGb/6 MbO7XpwEmw80MuyrWBqLQOF6lGYoW+I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-SdexcUPVNyiQ1ess-9y06Q-1; Mon, 23 Feb 2026 15:47:49 -0500 X-MC-Unique: SdexcUPVNyiQ1ess-9y06Q-1 X-Mimecast-MFC-AGG-ID: SdexcUPVNyiQ1ess-9y06Q_1771879669 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4806b12ad3fso35345835e9.0 for ; Mon, 23 Feb 2026 12:47:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771879668; x=1772484468; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+CQa2qTdj7Kc8K0XExJBFKARHDqe8hkQ/ZrKn6T1qP8=; b=MwuWa2FjKUG5UcbeYTYzpYb7gIb2p6G0O5Bce+yjTYl+eABwkNkLFIbobUUl9dnHUq vx9GYzm17s4CGOiEfP0cD+tZXQob20QxE5Kg2HGIL+WuzgEz1OvdzEx7mZW/HDCfg0Q2 hZprzmDXcn0s5WbXBJXZSlNlYcYNV62qXyDHSu5qU7SKt2A+Hser92jKfTw9EY3UtBd1 VhUlBw2dXH7klm2A1JBpXOglOY07Y6hlFyE4fm8QX1ULTxfGMwrFdtoVcxzd9uO6o65E TJ4ZjH7oxd/y4tJwxDmt1bZFN2SZFZ9LavZOzL0Rkl8sHSxdSbi6vFiaV14PBk7zO847 TZAQ== X-Gm-Message-State: AOJu0YyKZckHaGdxo2e7PBHgF1itIGQnY98zhiKHcnDRvEYbq9X4eNX5 FsmuOoGInixvqft1zzSk+WARLCutCeUXVDqeaw7eFigYSU1FRVCYUBF6+EjmKLb7Lh2OLQwJTlf KX3otFMcS00c+lwD1svQhru4SsUyE17TSmeZ2H2tuW5xJu0IC4ZWQlJjFtcHNSA== X-Gm-Gg: AZuq6aIcw4nf6CiJrrQW0VmdXlp739FF51sHWRMiE/C8bYD1lY2OKO02SudYKcEb6Sk nV2gWYedwuA8A18xF3KbF+GKyIgLAY6zwvkzMFqYbK+1jQuF2AcTT5QQ8PQOia71D4yu83/fLmv jNWm+5ZO/OSMxk7eq9Nn6Z3NwTQ8OcELpQBQg33BxAHTKwZfc1kqOryiwA78xZtzBTFTvEPkVkt 4rHx8bMZEOmbdaTP2jX+oGbN6zYmfm3UhYE2SKU5EPVrXLpAKHbeSQXq881t5t4uc8ZDyEeH8gh 6nfe6qjkj1+Crfz3Die3R6j55mpaoD3KBVM5JTycWfQe8M3caZbEvkAiQTgACrEPAIo/zuu4p3j Inms29p/VO45P5whHZB9Ehmfdo+wC2P541gXOFJ309MDsCMjPNA== X-Received: by 2002:a05:600c:6298:b0:480:3bba:1cac with SMTP id 5b1f17b1804b1-483a95eb81fmr152324895e9.6.1771879668071; Mon, 23 Feb 2026 12:47:48 -0800 (PST) X-Received: by 2002:a05:600c:6298:b0:480:3bba:1cac with SMTP id 5b1f17b1804b1-483a95eb81fmr152324285e9.6.1771879666958; Mon, 23 Feb 2026 12:47:46 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31f9475sm263037065e9.14.2026.02.23.12.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 12:47:46 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260223214736.6327e5c7@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> <20260223183530.2c040c94@elisabeth> <20260223200525.79be5cda@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Mon, 23 Feb 2026 21:47:45 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SDRwJXDKApTvUMAPJdOHvB6cY7enNYbfJX09aFYIDOM_1771879669 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JRBY7FO2I3ZKE4UKY4SMOOSKHJCBN54N X-Message-ID-Hash: JRBY7FO2I3ZKE4UKY4SMOOSKHJCBN54N X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 23 Feb 2026 15:22:20 -0500 Peter Foley wrote: > On Mon, Feb 23, 2026 at 2:05=E2=80=AFPM Stefano Brivio wrote: >=20 > > Hmm, "nice". I guess we should find out if it's reasonable / doable to > > "fix" all those. > > I tried just doing clang-include-cleaner --edit, but it's =20 > unfortunately c++ centric, so it added a bunch of stuff like > I can try manually fixing that up and seeing what happens. By the way, I won't have a chance to try this before a couple of days, if needed, but another thought: if we end up adding/changing hundreds of include lines as a result, maybe the cleanup David mentioned would actually be in scope at that point, even from a mere perspective of "noise" we would add, or effort you're spending anyway (let's make it fully worth it I'd say). In any case we could keep a clean clang-include-cleaner output as second step. I think the priorities here should be 1. keep/make things working for everybody while 2. avoiding the risk of recurring fix-ups for future changes and 3. make things pretty/readable/elegant, exactly in this order. If we can tackle all of them together, great, otherwise we can take care of 1. first, and 2. and 3. later. --=20 Stefano