From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GwgN2xsN; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 26C2C5A004E for ; Tue, 24 Feb 2026 00:01:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771887658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rIoX/AO7RYEHIolKmw7ciO/FwoFlzSWYSQYgZQWfE6A=; b=GwgN2xsNnsNjs/GwfI3unTHvc5zFib+knYOBJ50a9QTRkHIBwCUT1vnXGHpb7i9WOnh42e e0i+P52vHHTfhkSWtMNVI2d/aKWS7PyzLHIdoDnUq8IzKWtfhUTJZd5bpeW22z3VlTYVss xD+NN+ELnPSrqjfWnY0DufPsmy3AIvU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-b6Pb6wEKMNGewpbUb0V8zw-1; Mon, 23 Feb 2026 18:00:57 -0500 X-MC-Unique: b6Pb6wEKMNGewpbUb0V8zw-1 X-Mimecast-MFC-AGG-ID: b6Pb6wEKMNGewpbUb0V8zw_1771887656 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4836b7c302fso41695235e9.1 for ; Mon, 23 Feb 2026 15:00:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771887656; x=1772492456; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LWoTAAblbX11ShCyKlAtkjRmDAhE4FK0stegTGl2VX8=; b=EBlNgATmPddIESVXvZU80z/uxSsI7kAs/LX9gTr7POVSuL4X920wAhE/9FjupVsU/T 6kAC7nS8OZQLc46RnlAQCn+jkttnKi5Rc48dq9OQbEuVFTA8VtwPFCCUqKnnvCbYHdcR eQp/qQtSuaR+QivIvWWKSO4jhSiYywz1HNGhO4deCI6B5vF5EU+2kz3uS9pu8AZNR2ui tV00VDMbw5lcC/ym9sdb1/z6VmbinWnAr9q+M0bbMs3eyRUeb7svgTNiDYDcgEjbumOC G3sQ8lKZ9OOuMlpjRBw8q/XHJRRQOdVSheBxtgi0mpaVfbppu7MZIbCaT0PmLCV6Atar sClQ== X-Gm-Message-State: AOJu0Yz1Hwwhx5lT4zpXrIEW6XirZHk5rNzwNaF9PbHvdmJATIxK9uad Yq+1CFf1T57sL083S3Eyg+ryamlUsGRcBJwttieNRl29/MEOUjzel19mxWS3/5nWIr5bmr6LaJB bKW+dOZqSE0dLYInEdbtiHYZXhMUgjbk/XbwYZvifMipCv3nuzfR7Pw== X-Gm-Gg: AZuq6aKe6VmHX96j4/c3goPUBGecyRs3rRGaPOKWrVNUa4glN4mQcfyjI7z/dTxnyOR 3MGOVXZ8KisDxxm82XZlC9VO3wHO5AXqJ8xO4S/jvFlL9qJjYHEkFVo+ESpkqBCeqcpHYlagCx1 WOf97/volS5eUYAcHrrGznB7DA+DXNVvuF+vSHdYRuatAFkKXSgURNmwZSmsIu+bCfDGxx3tWt/ gsAitCOAGSHbwlEVTymujgJYsMIsOkYDMZf/u9OCG3nUNrVuNnJ3iaPV/jR0hOj7GdsPovHCttG hFQz9Iq2mGFL2YVD1Jhr2sApv0627A12AqwD8dwTsmEvF/11kEuI0xEIQf7mubDIrQwSyIJtXBi vODToBoqbN4EfkHhzXzcrTzhCIKfrHL84 X-Received: by 2002:a05:600c:4e12:b0:480:39ad:3b7c with SMTP id 5b1f17b1804b1-483a962e465mr193899975e9.16.1771887655723; Mon, 23 Feb 2026 15:00:55 -0800 (PST) X-Received: by 2002:a05:600c:4e12:b0:480:39ad:3b7c with SMTP id 5b1f17b1804b1-483a962e465mr193899445e9.16.1771887655229; Mon, 23 Feb 2026 15:00:55 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483b8900385sm8202495e9.4.2026.02.23.15.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 15:00:54 -0800 (PST) From: Stefano Brivio To: Peter Foley Subject: Re: [PATCH] Add missing includes to headers Message-ID: <20260224000050.0dc12abc@elisabeth> In-Reply-To: References: <20260219184454.1501389-1-pefoley@google.com> <20260221185706.6bb0ade2@elisabeth> <20260223183530.2c040c94@elisabeth> <20260223200525.79be5cda@elisabeth> <20260223214736.6327e5c7@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 24 Feb 2026 00:00:54 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: czLlVNaKGQ1ea_OQXx8INxjm7SFwY8yjRd1c2n2zEvk_1771887656 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YQJ3MF6MG3LZ4ZTCQRUGGFGE6KN54MK2 X-Message-ID-Hash: YQJ3MF6MG3LZ4ZTCQRUGGFGE6KN54MK2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 23 Feb 2026 16:37:54 -0500 Peter Foley wrote: > On Mon, Feb 23, 2026 at 3:47=E2=80=AFPM Stefano Brivio wrote: >=20 > > By the way, I won't have a chance to try this before a couple of days, > > if needed, but another thought: if we end up adding/changing hundreds > > of include lines as a result, maybe the cleanup David mentioned would > > actually be in scope at that point, even from a mere perspective of > > "noise" we would add, or effort you're spending anyway (let's make it > > fully worth it I'd say). >=20 > I tried running clang-include-cleaner and then massaging it to not includ= e > c++ only headers or stuff from bits/ > That wound up with: > 64 files changed, 349 insertions(+), 189 deletions(-) >=20 > Unfortunatly include-cleaner isn't smart enough to handle things like > #include instead of > So absent adding pragma annotations to glibc headers, I'm not sure a clea= n > clang-include-cleaner check is possible. We could always add suppressions for clang-tidy checks, we already have a bunch, see NOLINTNEXTLINE directives in the code. > That diff is > https://github.com/pefoley2/passt/commit/6ae0bcb2bbdc10384346dda547db60f8= 0c8a9676 > . > I can send it as a proper patch as well if you're interested, but it's a > lot of churn and I'm not sure how to prevent back-sliding... Ouch... yeah. Let me have another look tomorrow (Tuesday) but I think it only makes sense if we use that as a chance to entirely switch to approach #2 David was mentioning (minus perhaps some exceptions), including all the related clean-ups. I'm totally for it by the way, if you can take care of it. Otherwise I'd recommend sticking to a more conservative approach for the moment being. --=20 Stefano