From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Peter Foley <pefoley@google.com>, passt-dev@passt.top
Subject: Re: [PATCH] Avoid clang warnings in fwd.h
Date: Tue, 24 Feb 2026 09:50:56 +0100 (CET) [thread overview]
Message-ID: <20260224095055.4c3be413@elisabeth> (raw)
In-Reply-To: <aZ07nqzLWM6LyAUB@zatzit>
On Tue, 24 Feb 2026 16:48:14 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote:
> > e.g.
> > ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions]
> > 65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> >
> > Signed-off-by: Peter Foley <pefoley@google.com>
> > ---
> > fwd.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fwd.h b/fwd.h
> > index 1607011..7d299b6 100644
> > --- a/fwd.h
> > +++ b/fwd.h
> > @@ -62,7 +62,7 @@ union fwd_listen_ref {
> > };
> > uint32_t u32;
> > };
> > -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> > +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), "");
>
> I'd prefer to see an actual message added here, rather than just
> minimally suppressing the warning.
Can you please suggest a message then? You added this static_assert()
in the first place.
--
Stefano
prev parent reply other threads:[~2026-02-24 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 17:29 Peter Foley
2026-02-24 5:48 ` David Gibson
2026-02-24 8:50 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224095055.4c3be413@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pefoley@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).