From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TNAJ/+Sm; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 92E8E5A0265 for ; Tue, 24 Feb 2026 09:51:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771923061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MP3VxWd32fCNl8FH/1yhtGJn3n4oHVc702s/47ZXIwY=; b=TNAJ/+Sm+sFMBzQAaYn77Zzlb8zz1Rhrv59oeP7mZhkTMehbF967zjTihCAA/iDnPUfek9 XwJy+m61m6zQHaIX46oaSvt5GvPGB6gwKJnVHC667MweuEnxDB5XLkFFcOSTGj6N8LgiOV JPCn0fNj72PPLpooOGHQpvq68Je86CM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-ZoUvDCwBOVOfsra63rWpZA-1; Tue, 24 Feb 2026 03:50:59 -0500 X-MC-Unique: ZoUvDCwBOVOfsra63rWpZA-1 X-Mimecast-MFC-AGG-ID: ZoUvDCwBOVOfsra63rWpZA_1771923058 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48079ae1001so20352025e9.0 for ; Tue, 24 Feb 2026 00:50:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771923058; x=1772527858; h=date:content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MP3VxWd32fCNl8FH/1yhtGJn3n4oHVc702s/47ZXIwY=; b=bTtb/DcPuQCEAKUBu2fVe5j6QlT4kzkF5tuSlQ5KTF9l6SE0wyTfq6r86e59LpGgdW NQtQSVmYbLymv+KpUcRuPF6qohBwiB4U1zIqQ1il//C5YfBLP7yoUv3YsJhnavTq3GSb UyuarCIawmaBvgAq4eHk6ZIt6cJWkuljhKbcPm4wwU8DX0qNeQPRxamYr76V4KBuTm/c bsEo7BOYCqePLjXT3MVlp31dg+nV8c2BrDsoZQzoBI9PGlJv5w3F8FfHj75TB/xXN7ex KvLxHpk+2QLMidQPQ5U1Q+heRwqtY3MQn8kHs5a4IWRDOTk6Xbp2EUIlxCiVbF7RuHFz ZPvg== X-Forwarded-Encrypted: i=1; AJvYcCV8kc+/TM7NWkqdg+uS/wKOYkH9QzP8iLMWaFSwOgEHKMIYF2msOoWMmVIxc5PDic7RJ7jIcGU2ZjI=@passt.top X-Gm-Message-State: AOJu0YzRdKBgDyk6ZYKRwImW4fnkCTwDlNDCZox5sOokCFiL94kKKRHN 2XNhAPfHUdkBwYeoZ0rYh402KN6c3GX1KfnYRiYc4L8vNoPJuojixtBVNbwsCYmDvNcp8R466SK aAZ5b/UmdBDsCNNdzSCyR+gjGIrGrvETwKTzJ54K5/gQBCBHmEiyY/g== X-Gm-Gg: AZuq6aL/HVo7X6hw/7X9NRk5RynpNScGpBNBv8njszxq+V37V0h2Hl+fSKKWx7VUhJq 5A34SElEYkneUuhMkOVHYnBiOU7r21wokKgePzatJo5gRB2BG1DIx5pVDuPWtER5+MiOKV9j2r0 zwddfDsLHAXCAbn78qcbMD5KVeHF5hf5BODl/4tYDczowZOmP40R8gl0z20qD6M866WXjkrt4dS Bi8G8Mlxj4gTGcIEIlpF8RJ/opU6eVMLP4PR9WvaxMApq2byKLUyXZnzGgz2tBHkp5xOzZ4lDRp niWdjLCqVKHF7a3Xx42R064MyHWZ0AJ9JYvEEe+EJGRy6/rNt4RSpU273rDm5NMgAAA/y6hW3vS N3E0PnALVbaAgq7MbWXlwkPIXKI9pOwgi X-Received: by 2002:a05:600c:4454:b0:483:80b0:b245 with SMTP id 5b1f17b1804b1-483a95f89c2mr207808695e9.9.1771923058092; Tue, 24 Feb 2026 00:50:58 -0800 (PST) X-Received: by 2002:a05:600c:4454:b0:483:80b0:b245 with SMTP id 5b1f17b1804b1-483a95f89c2mr207808235e9.9.1771923057523; Tue, 24 Feb 2026 00:50:57 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31b3dd7sm334536765e9.2.2026.02.24.00.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 00:50:56 -0800 (PST) From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] Avoid clang warnings in fwd.h Message-ID: <20260224095055.4c3be413@elisabeth> In-Reply-To: References: <20260223172920.146057-1-pefoley@google.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 24 Feb 2026 09:50:56 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GGuzySJWVE0-YsXg8mnV8M0EyYlKKo9sv77hUGxyW1A_1771923058 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: XGRYAE4TCG6SWSSMCGYDZPPJR53BKXCH X-Message-ID-Hash: XGRYAE4TCG6SWSSMCGYDZPPJR53BKXCH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Peter Foley , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 24 Feb 2026 16:48:14 +1100 David Gibson wrote: > On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote: > > e.g. > > ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions] > > 65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t)); > > > > Signed-off-by: Peter Foley > > --- > > fwd.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fwd.h b/fwd.h > > index 1607011..7d299b6 100644 > > --- a/fwd.h > > +++ b/fwd.h > > @@ -62,7 +62,7 @@ union fwd_listen_ref { > > }; > > uint32_t u32; > > }; > > -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t)); > > +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), ""); > > I'd prefer to see an actual message added here, rather than just > minimally suppressing the warning. Can you please suggest a message then? You added this static_assert() in the first place. -- Stefano