* [PATCH] Avoid clang warnings in fwd.h
@ 2026-02-23 17:29 Peter Foley
2026-02-24 5:48 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Peter Foley @ 2026-02-23 17:29 UTC (permalink / raw)
To: passt-dev; +Cc: Peter Foley
e.g.
./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions]
65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
Signed-off-by: Peter Foley <pefoley@google.com>
---
fwd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fwd.h b/fwd.h
index 1607011..7d299b6 100644
--- a/fwd.h
+++ b/fwd.h
@@ -62,7 +62,7 @@ union fwd_listen_ref {
};
uint32_t u32;
};
-static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
+static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), "");
enum fwd_ports_mode {
FWD_UNSET = 0,
--
2.53.0.371.g1d285c8824-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Avoid clang warnings in fwd.h
2026-02-23 17:29 [PATCH] Avoid clang warnings in fwd.h Peter Foley
@ 2026-02-24 5:48 ` David Gibson
2026-02-24 8:50 ` Stefano Brivio
0 siblings, 1 reply; 3+ messages in thread
From: David Gibson @ 2026-02-24 5:48 UTC (permalink / raw)
To: Peter Foley; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote:
> e.g.
> ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions]
> 65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
>
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
> fwd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fwd.h b/fwd.h
> index 1607011..7d299b6 100644
> --- a/fwd.h
> +++ b/fwd.h
> @@ -62,7 +62,7 @@ union fwd_listen_ref {
> };
> uint32_t u32;
> };
> -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), "");
I'd prefer to see an actual message added here, rather than just
minimally suppressing the warning.
>
> enum fwd_ports_mode {
> FWD_UNSET = 0,
> --
> 2.53.0.371.g1d285c8824-goog
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Avoid clang warnings in fwd.h
2026-02-24 5:48 ` David Gibson
@ 2026-02-24 8:50 ` Stefano Brivio
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Brivio @ 2026-02-24 8:50 UTC (permalink / raw)
To: David Gibson; +Cc: Peter Foley, passt-dev
On Tue, 24 Feb 2026 16:48:14 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote:
> > e.g.
> > ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions]
> > 65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> >
> > Signed-off-by: Peter Foley <pefoley@google.com>
> > ---
> > fwd.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fwd.h b/fwd.h
> > index 1607011..7d299b6 100644
> > --- a/fwd.h
> > +++ b/fwd.h
> > @@ -62,7 +62,7 @@ union fwd_listen_ref {
> > };
> > uint32_t u32;
> > };
> > -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> > +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), "");
>
> I'd prefer to see an actual message added here, rather than just
> minimally suppressing the warning.
Can you please suggest a message then? You added this static_assert()
in the first place.
--
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-24 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-23 17:29 [PATCH] Avoid clang warnings in fwd.h Peter Foley
2026-02-24 5:48 ` David Gibson
2026-02-24 8:50 ` Stefano Brivio
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).